7b0cbfc1f9
DEV: lint file
...
long story but we are sorting out our new GitHub actions so we missed this
2019-12-11 10:48:58 +11:00
bc05d3bcdd
DEV: triggers github actions on pull_request ( #8527 )
2019-12-11 00:24:30 +01:00
2720531750
FIX: Always add username span in quick access item ( #8526 )
...
Generate an empty `<span>` even if there is no username, because the
first `<span>` is styled differently.
2019-12-11 09:44:19 +11:00
505b8b76bc
Build(deps): Bump webpush from 0.3.8 to 1.0.0 ( #8511 )
...
Bumps [webpush](https://github.com/zaru/webpush ) from 0.3.8 to 1.0.0.
- [Release notes](https://github.com/zaru/webpush/releases )
- [Changelog](https://github.com/zaru/webpush/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zaru/webpush/compare/v0.3.8...v1.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-10 12:56:52 -08:00
424cda1433
DEV: Add timeouts to GitHub actions
2019-12-10 20:44:33 +00:00
81a43f2c1e
REFACTOR: use rest serializer for tag-info categories
...
But the "synonyms" can't use the TagSerializer yet. We still have some
code from the discourse-tagging plugin that uses "text" instead of
"name", "count" instead of "topic_count", etc. We should make the js
consistent with the TagSerializer and then stop using tag_counts_json.
2019-12-10 14:58:11 -05:00
f921909595
FIX: Reorder categories not working
...
Ember was throwing this error preventing the reorder categories feature
from working:
```
access theidproperty (of <(unknown):ember1803>). ... the object in question
is a special kind of Ember object (a proxy). Therefore, it is still necessary
to use.get('id')in this case.
```
So I updated it to use the `get` method
https://api.emberjs.com/ember/3.14/functions/@ember%2Fobject/get
Follow up to: 6e5fedb31281fb40e672ffb87e767afcffd35e38
2019-12-10 12:36:47 -07:00
3309a2b564
Build(deps-dev): Bump webmock from 3.5.1 to 3.7.6 ( #8512 )
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.5.1 to 3.7.6.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.5.1...v3.7.6 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-10 10:38:03 -08:00
ba8d8a4f93
FIX: alphabetical tag sorting in mini-tag-chooser
2019-12-10 12:36:49 -05:00
31c6a1528b
Build(deps-dev): Bump listen from 3.1.5 to 3.2.1 ( #8498 )
...
Bumps [listen](https://github.com/guard/listen ) from 3.1.5 to 3.2.1.
- [Release notes](https://github.com/guard/listen/releases )
- [Commits](https://github.com/guard/listen/compare/v3.1.5...v3.2.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-10 08:48:40 -08:00
de69c3c921
DEV: Use push trigger for github actions, but ignore tests-passed
...
The pull_request trigger causes the rubocop annotations to fail
2019-12-10 16:25:45 +00:00
287ba20f3b
Build(deps-dev): Bump parallel_tests from 2.29.2 to 2.30.0 ( #8508 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from 2.29.2 to 2.30.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases )
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.29.2...v2.30.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-10 16:11:49 +00:00
67605b55d5
DEV: Prevent plugin loading when running core db migrations in tests
...
This is required because bin/rake automatically loads plugins when migrating. In our continuous integration, we don't want plugins to break the core build. They should only be loaded for the plugin build.
2019-12-10 16:11:49 +00:00
148970ca9b
DEV: Revert parallel_tests bump ( #8518 )
...
parallel_tests with this version uses `bin/rake`, which auto-loads plugins
2019-12-10 07:58:12 -08:00
20464116ae
FIX: tag input doesn't show all top 5 permitted tags
2019-12-10 10:30:01 -05:00
2605adede0
Build(deps-dev): Bump parallel_tests from 2.29.2 to 2.30.0 ( #8508 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from 2.29.2 to 2.30.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases )
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.29.2...v2.30.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-10 07:12:38 -08:00
da62f87694
Build(deps): Bump rqrcode from 0.10.1 to 1.1.2 ( #8497 )
...
Bumps [rqrcode](https://github.com/whomwah/rqrcode ) from 0.10.1 to 1.1.2.
- [Release notes](https://github.com/whomwah/rqrcode/releases )
- [Commits](https://github.com/whomwah/rqrcode/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-10 06:49:20 -08:00
d2d7bed21d
DEV: Restrict branches for github actions
...
This avoids running duplicate checks when a commit lands in tests-passed
2019-12-10 14:41:55 +00:00
ee1f77d301
Build(deps-dev): Bump uglifier from 4.1.20 to 4.2.0 ( #8510 )
...
Bumps [uglifier](https://github.com/lautis/uglifier ) from 4.1.20 to 4.2.0.
- [Release notes](https://github.com/lautis/uglifier/releases )
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lautis/uglifier/compare/v4.1.20...v4.2.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-10 06:28:15 -08:00
bd17a3a8e7
DEV: introduces Github Actions for CI ( #8441 )
...
Co-Authored-By: David Taylor <david@taylorhq.com >
2019-12-10 14:45:47 +01:00
dfb9fa3b98
Update translations
2019-12-10 13:10:55 +01:00
5fbd52cf8a
DEV: Cleanup unused config files ( #8515 )
...
- codeclimate is not used for this repository
- .env.sample was added for Heroku deployment, which is no longer supported
2019-12-10 11:20:38 +00:00
7891da7848
DEV: Remove unused pkgr.io config files ( #8514 )
2019-12-10 11:20:26 +00:00
47731175f4
FIX: ensures slug and id are not arrays ( #8495 )
...
If for some reason an URL was create in this format:
```
?slug[]=foo&slug[]=bar
```
This would have create an exception of this kind:
```
NoMethodError (undefined method `tr' for ["foo", "bar"]:Array
Did you mean? try)
```
2019-12-10 09:28:51 +01:00
f5396e2700
DEV: Sidekiq::Logging is gone use Sidekiq.logger instead
...
This 6.0 upgrade of sidekiq moved this around.
2019-12-10 15:09:51 +11:00
33ae9679d8
DEV: Bump excon from 0.64.0 to 0.70.0 ( #8503 )
...
Bumps [excon](https://github.com/excon/excon ) from 0.64.0 to 0.70.0.
- [Release notes](https://github.com/excon/excon/releases )
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v0.64.0...v0.70.0 )
Most changes are minor and update should be pretty safe.
2019-12-10 12:34:00 +11:00
3e0454c97b
DEV: add a note about sprockets being held back
...
We want to upgrade to version 4, but it does not work atm.
2019-12-10 12:31:16 +11:00
84c251c778
DEV: Bump sidekiq from 5.2.7 to 6.0.3 ( #8499 )
...
Bumps [sidekiq](https://github.com/mperham/sidekiq ) from 5.2.7 to 6.0.3.
- [Release notes](https://github.com/mperham/sidekiq/releases )
- [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md )
- [Commits](https://github.com/mperham/sidekiq/compare/v5.2.7...v6.0.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
The big thing for us with this update is that it makes sidekiq a bit faster.
2019-12-10 12:05:02 +11:00
c923c49964
DEV: Bump sassc-rails from 2.1.1 to 2.1.2 ( #8501 )
...
Bumps [sassc-rails](https://github.com/sass/sassc-rails ) from 2.1.1 to 2.1.2.
- [Release notes](https://github.com/sass/sassc-rails/releases )
- [Commits](https://github.com/sass/sassc-rails/compare/v2.1.1...v2.1.2 )
Minor fixes in the gem
2019-12-10 11:50:34 +11:00
0c52537f10
DEV: update rubocop to version 0.77
...
We like to stay as close as possible to latest with rubocop cause the cops
get better.
This update required some code changes, specifically the default is to avoid
explicit returns where implicit is done
Also this renames a few rules
2019-12-10 11:48:39 +11:00
8e489ec8f8
DEV: mark discourse-rss-polling as official
2019-12-10 11:48:39 +11:00
ee9afb87f2
DEV: Bump mock_redis from 0.19.0 to 0.22.0 ( #8504 )
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.19.0 to 0.22.0.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.19.0...v0.22.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Mock redis update adds better parity for redis mock, we use it during tests.
2019-12-10 11:36:36 +11:00
81c7d6a462
FIX: Muted tags are respected by TopicTrackingState ( #8467 )
...
When the tag is muted and topic contains that tag, we should not mark that message as NEW.
There are 3 possible settings which site admin can set.
remove_muted_tags_from_latest - always
It means that if the topic got at least one muted tag, we should not mark that topic as NEW
remove_muted_tags_from_latest - only muted
Similar to above, however, if at least one tag is not muted, the topic is marked as NEW
remove_muted_tags_from_latest - never
Basically, mute tag setting is ignored and all topics are set as NEW
2019-12-10 09:50:05 +11:00
6740e08caa
DEV: Revert 3 dependabot suggestions ( #8506 )
2019-12-09 14:40:54 -08:00
642c17a4b2
DEV: revert webpush version bump ( #8505 )
2019-12-09 13:53:25 -08:00
f5cca4930d
DEV: Remove buffered rendering from admin backup logs
...
This is another refactoring in the multi-step process to remove all uses
of our custom Render Buffer.
Previous commit: da66950cf523adddf707f5b6768e1a189ffb40bd in this
series.
This commit affects the display of the backup logs. It is just a
refactor and does not change any functionality.
2019-12-09 14:45:36 -07:00
5e29ae3ef5
FEATURE: Warning when component is added and not assigned ( #8482 )
...
When a component is installed and not assigned to any theme and the user is changing page, we should display a warning.
If the user decides to skip warning or come back later, a warning should not be shown anymore.
Also, when the user clicks "delete" button right after installation, warning about forgotten themes should not be shown.
2019-12-10 08:43:26 +11:00
413a49fe06
Build(deps-dev): Bump rspec-html-matchers from 0.9.1 to 0.9.2 ( #8494 )
...
Bumps [rspec-html-matchers](https://github.com/kucaahbe/rspec-html-matchers ) from 0.9.1 to 0.9.2.
- [Release notes](https://github.com/kucaahbe/rspec-html-matchers/releases )
- [Changelog](https://github.com/kucaahbe/rspec-html-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kucaahbe/rspec-html-matchers/compare/v0.9.1...v0.9.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-09 12:22:55 -08:00
866b634f22
Build(deps): Bump webpush from 0.3.8 to 1.0.0 ( #8491 )
...
Bumps [webpush](https://github.com/zaru/webpush ) from 0.3.8 to 1.0.0.
- [Release notes](https://github.com/zaru/webpush/releases )
- [Changelog](https://github.com/zaru/webpush/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zaru/webpush/compare/v0.3.8...v1.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-09 12:21:49 -08:00
6dd1d63671
Build(deps): Bump sassc from 2.0.1 to 2.2.1 ( #8493 )
...
Bumps [sassc](https://github.com/sass/sassc-ruby ) from 2.0.1 to 2.2.1.
- [Release notes](https://github.com/sass/sassc-ruby/releases )
- [Changelog](https://github.com/sass/sassc-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/sassc-ruby/compare/v2.0.1...v2.2.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-09 12:19:39 -08:00
bf847e680a
Build(deps-dev): Bump uglifier from 4.1.20 to 4.2.0 ( #8489 )
...
Bumps [uglifier](https://github.com/lautis/uglifier ) from 4.1.20 to 4.2.0.
- [Release notes](https://github.com/lautis/uglifier/releases )
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lautis/uglifier/compare/v4.1.20...v4.2.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-09 12:16:03 -08:00
16de46f8d4
Build(deps): Bump omniauth-google-oauth2 from 0.7.0 to 0.8.0 ( #8488 )
...
Bumps [omniauth-google-oauth2](https://github.com/zquestz/omniauth-google-oauth2 ) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/zquestz/omniauth-google-oauth2/releases )
- [Changelog](https://github.com/zquestz/omniauth-google-oauth2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zquestz/omniauth-google-oauth2/compare/v0.7.0...v0.8.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-09 12:13:07 -08:00
9be3945c91
Build(deps-dev): Bump rspec from 3.8.0 to 3.9.0 ( #8487 )
...
Bumps [rspec](https://github.com/rspec/rspec ) from 3.8.0 to 3.9.0.
- [Release notes](https://github.com/rspec/rspec/releases )
- [Commits](https://github.com/rspec/rspec/compare/v3.8.0...v3.9.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-09 11:34:30 -08:00
3092cdc2bd
Build(deps-dev): Bump simplecov from 0.16.1 to 0.17.1 ( #8486 )
...
Bumps [simplecov](https://github.com/colszowka/simplecov ) from 0.16.1 to 0.17.1.
- [Release notes](https://github.com/colszowka/simplecov/releases )
- [Changelog](https://github.com/colszowka/simplecov/blob/master/CHANGELOG.md )
- [Commits](https://github.com/colszowka/simplecov/compare/v0.16.1...v0.17.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-09 11:32:25 -08:00
41f4159cc7
Build(deps): Bump multi_json from 1.13.1 to 1.14.1 ( #8485 )
...
Bumps [multi_json](https://github.com/intridea/multi_json ) from 1.13.1 to 1.14.1.
- [Release notes](https://github.com/intridea/multi_json/releases )
- [Changelog](https://github.com/intridea/multi_json/blob/master/CHANGELOG.md )
- [Commits](https://github.com/intridea/multi_json/compare/v1.13.1...v1.14.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2019-12-09 11:30:30 -08:00
14cb386f1e
FEATURE: Featured topic for user profile & card ( #8461 )
2019-12-09 11:15:47 -08:00
b5236591e9
FIX: Don't try to create an empty tag when updating a topic ( #8481 )
...
Fixes an issue where updates to the first post in a topic would be visible only for staff.
Before, because the empty tag would find its way to `PostRevisor`, `TopicsController#update` would create a hidden revision, and later `PostsController#update` would only update that revision.
After this change, `TopicsController` doesn't create a revision at all (unless necessary), so `PostsController` can create it (and correctly decide whether the revision should be hidden or not).
2019-12-09 19:55:08 +01:00
34ccd9ecbb
DEV: Export imageNameFromFileName
2019-12-09 18:19:55 +02:00
78d67f34f9
FIX: default draft key in openComposerWithTopicParams ( #8496 )
2019-12-09 07:53:05 -08:00
aa24be1a9a
DEV: Extend plugin API for uploads ( #8440 )
...
* DEV: Add API to alter uploads Markdown
* DEV: Extract data attributes from image / download Markdown
For example '[test|attachment|hello=world]' will generate an 'a' element
with a data attribute: 'data-hello=world'.
This commit also makes MarkdownIt to transform '|attachment' into
'class="attachment"'. This transformation used to be a part of the
process which resolves short URLs (i.e. upload://).
* DEV: Export imageNameFromFileName
2019-12-09 16:20:03 +02:00
