81a3129ffb
ARIA - add aria-label on topic input and post textarea ( #10057 )
...
Add reply form role with label as create/reply, and aria-labels on text inputs
2020-06-17 08:55:19 -07:00
76b05ef8ad
DEV: Use short_date helper for email post template ( #10063 )
2020-06-17 11:29:37 -04:00
e29afa200a
FIX: Cleanup migrations with timestamps in the future
...
A future-dated migration was accidently introduced by me in 45c399f0. This was removed in b9762afc, but other migrations had already been generated based on its incorrect date. This commit removes the offending data in the schema_migrations table, and corrects the version in the published_pages migration.
This commit also adds a check to db:migrate which raises an error when invalid migration timestamps are used.
2020-06-17 15:58:22 +01:00
159fc41f40
FIX: Restore missing translation keys
...
These were accidentally removed/renamed in 5bfe1ee4
2020-06-17 14:24:22 +01:00
9518d6b587
fix spec ( #10061 )
2020-06-17 15:10:07 +02:00
6caad5c083
FIX: Do not send staff welcome message if user already has role
2020-06-17 12:12:55 +01:00
9da3a7f436
FEATURE: allows published pages to be public ( #10053 )
2020-06-17 12:42:20 +02:00
7d289a4f3e
UX: Style video elements, show descriptions ( #10040 )
...
It's a stop gap – ideally we would generate a thumbnail for uploaded videos. For now, a bit of intentionality in the style and a pinch of context should do.
2020-06-17 12:38:00 +02:00
a859d507e7
FIX: Prevent producing "undefined" strings ( #10042 )
...
Fixes a bug in search-menu-results (type: "group"), where:
```javascript
const fullName = escapeExpression(group.fullName);
const name = escapeExpression(group.name);
const groupNames = [h("span.name", fullName || name)];
```
`groupNames` could end up having value "undefined" if a group doesn't have a `fullName`.
2020-06-17 12:37:06 +02:00
d66ccabdb1
DEV: Added topic-list-after-title outlet in the mobile template ( #10059 )
2020-06-17 10:05:37 +01:00
45eb97c202
FIX: Thread safety issues with multisite:migrate and SeedFu.
2020-06-17 16:15:43 +08:00
86b43c5329
DEV: Remove rubocop_todo which doesn't seem to work with plugins.
2020-06-17 15:47:44 +08:00
828ceab64b
DEV: Make rubocop happy.
2020-06-17 15:47:05 +08:00
28f6c59612
DEV: Load rubocop_todo after default config.
2020-06-17 15:31:26 +08:00
9c385a3599
Update rubocop_todo.
2020-06-17 15:19:50 +08:00
f096181653
Upgrade rubocop and generate rubocop todo.
2020-06-17 14:50:34 +08:00
3e888cbb5d
DEV: Properly reset column information before seeding.
2020-06-17 13:23:45 +08:00
52580605d8
FIX: select-kit components not being hidden.
2020-06-17 09:39:51 +08:00
ad447677ed
Build(deps): Bump sanitize from 5.2.0 to 5.2.1
...
Bumps [sanitize](https://github.com/rgrove/sanitize ) from 5.2.0 to 5.2.1.
- [Release notes](https://github.com/rgrove/sanitize/releases )
- [Changelog](https://github.com/rgrove/sanitize/blob/master/HISTORY.md )
- [Commits](https://github.com/rgrove/sanitize/compare/v5.2.0...v5.2.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-06-17 09:39:04 +08:00
5610792704
Build(deps): Bump loofah from 2.5.0 to 2.6.0
...
Bumps [loofah](https://github.com/flavorjones/loofah ) from 2.5.0 to 2.6.0.
- [Release notes](https://github.com/flavorjones/loofah/releases )
- [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flavorjones/loofah/compare/v2.5.0...v2.6.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-06-17 09:38:41 +08:00
e5da2d24e5
FIX: Add attachment content-disposition for all non-image files ( #10058 )
...
This will make it so the original filename is used when downloading all non-image files, bringing S3Store into line with the to_s3 migration and local storage. Video and audio files will still stream correctly in HTML players as well.
See https://meta.discourse.org/t/cannot-download-non-image-media-files-original-filenames-lost-when-uploaded-to-s3/152797 for a lot of extra context.
2020-06-17 11:16:37 +10:00
dcb816b548
FIX: add table name to topic view query ( #10052 )
...
When plugin is hooking into TopicView joining other tables, it may fail because `created_at` is potentially available on 2 tables. Therefore we should explicitly define which `created_at` we want.
2020-06-17 10:40:01 +10:00
b62ad003ce
Always require pry gems in rails_helper
...
* remove IMPROVED_SPEC_DEBUGGING env var guard
2020-06-17 10:08:53 +10:00
a3e812453e
FEATURE: new category-list-above-each-category plugin outlet ( #10037 )
2020-06-16 11:53:36 -07:00
7f8c5cf70b
FIX: Allow plugins to provide test directories with transpiled .js
2020-06-16 14:31:01 -04:00
c52191d49e
PERF: improve loading a imported_ids in bulk imports
...
- Stream the queries that load the imported_ids
- Use an array instead of a hash for keeping the mapping between imported_ids and new ids
- Ensure we always treat the imported_ids as integers instead of strings
2020-06-16 19:55:08 +02:00
669c940ec3
Revert "DEV: Remove the remaining ENV["TRAVIS"] usage ( #10041 )"
...
This reverts commit 78aff841e3215c875e79692fbeaf8d18c4514006.
See https://review.discourse.org/t/dev-remove-the-remaining-env-travis-usage-10041/12737/4?u=cvx
2020-06-16 19:42:00 +02:00
78aff841e3
DEV: Remove the remaining ENV["TRAVIS"] usage ( #10041 )
2020-06-16 17:41:15 +02:00
9b30e8126e
Build(deps): Bump excon from 0.73.0 to 0.74.0 ( #10046 )
...
Bumps [excon](https://github.com/excon/excon ) from 0.73.0 to 0.74.0.
- [Release notes](https://github.com/excon/excon/releases )
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v0.73.0...v0.74.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-16 11:40:12 -04:00
df0e3b4ed4
FIX: Allow opening FAQ in a new tab ( #10039 )
2020-06-16 17:35:04 +02:00
ce37561e10
UX: Improve revert label in post history modal ( #10038 )
2020-06-16 11:31:25 -04:00
06e5fd5627
Build(deps): Bump aws-sdk-sns from 1.23.0 to 1.25.1 ( #10033 )
...
Bumps [aws-sdk-sns](https://github.com/aws/aws-sdk-ruby ) from 1.23.0 to 1.25.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-sns/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-16 11:24:15 -04:00
8bd787646b
Build(deps): Bump rubocop-rspec from 1.39.0 to 1.40.0 ( #10029 )
...
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec ) from 1.39.0 to 1.40.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.39.0...v1.40.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-16 11:05:45 -04:00
4b4f568ec0
add showPreview to composer fields plugin outlet ( #10019 )
...
showPreview is necessary because we need to add 50% width class similar to: class="title-and-category with-preview" on the category and title div if the preview is shown.
2020-06-16 10:50:55 -04:00
11fa0cc16b
Build(deps-dev): Bump parallel_tests from 2.32.0 to 3.0.0 ( #10018 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from 2.32.0 to 3.0.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases )
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.32.0...v3.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-16 10:49:03 -04:00
859d9b75a7
FIX: Restoring backup from PG12 could fail on PG10
...
The `EXECUTE FUNCTION` syntax for `CREATE TRIGGER` statements was introduced in PostgreSQL 11. We need to replace `EXECUTE FUNCTION` with `EXECUTE PROCEDURE` in order to be able to restore backups created with PG12 on PG10.
2020-06-16 16:04:14 +02:00
4cff4892e8
Locale checks were disabled by mistake
2020-06-16 16:04:14 +02:00
f1b97202d4
FIX: Ensure users can confirm new emails using security keys
2020-06-16 14:19:21 +03:00
84dfaad137
FIX: Fill acting_user field instead of target_user in history
2020-06-16 13:30:58 +03:00
219bb0b6a7
DEV: Fix build
...
Follow-up to 62584064190c4e7e5543ef0d11ff070f5b8d488c.
2020-06-16 13:00:09 +03:00
6258406419
FIX: secondary_emails, unconfirmed_emails, group_users are private fields
...
Those fields should be only visible to the user.
2020-06-16 12:46:27 +03:00
b9762afc10
FIX: Change version of incorrect datetime migration ( #10051 )
...
* Fix create_missing_badge_indexes migration filename and version
* Delete additional migration that is unnecessary
2020-06-16 08:55:21 +01:00
2bbb870b11
copyedit on push icon help text
2020-06-15 22:43:55 -07:00
def4cd33ea
DEV: Disable Redis warnings.
2020-06-16 12:53:04 +08:00
c611f3703c
DEV: Don't use logster when logging in Redis failover.
2020-06-16 11:53:52 +08:00
b08a0d15c4
DEV: Fix undefined method due to rails_failover.
2020-06-16 11:03:57 +08:00
092ae858af
DEV: Bump rails_failover.
...
Avoid configuring AR stuff if `replica_host` and `replica_port` hasn't
been provided.
2020-06-16 10:51:21 +08:00
a2713578dd
DEV: Allow plugins to exclude seed data
...
This allows plugins to specify if they would like to filter out any seed
data files from running during migrations.
2020-06-15 15:30:25 -06:00
a2f80670e1
FIX: Do not count youtube thumbnail when counting post images ( #10049 )
2020-06-15 20:25:30 +01:00
298393a5bc
FIX: Keep onebox styling in edit history
2020-06-15 15:23:14 -04:00
