933dd06b4f
Build(deps): Bump google-protobuf from 4.30.2 to 4.31.0 ( #32735 )
...
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf )
from 4.30.2 to 4.31.0.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases )
-
[Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl )
-
[Commits](https://github.com/protocolbuffers/protobuf/compare/v4.30.2...v4.31.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-15 09:14:14 +08:00
7e246996ae
Build(deps-dev): Bump mime-types-data from 3.2025.0507 to 3.2025.0514 ( #32736 )
...
Bumps [mime-types-data](https://github.com/mime-types/mime-types-data )
from 3.2025.0507 to 3.2025.0514.
-
[Changelog](https://github.com/mime-types/mime-types-data/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/mime-types/mime-types-data/compare/v3.2025.0507...v3.2025.0514 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-15 09:13:12 +08:00
4df5638b3f
DEV: Remove discourse-logster-rate-limit-checker from official plugins ( #32727 )
...
This is a plugin that is no longer maintained.
2025-05-15 09:10:15 +08:00
02a805c3ad
DEV: Revert unintended changes to GroupsController #add_members and its corresponding route ( #32732 )
...
Reverted unintended changes to group routes made
[here](https://github.com/discourse/discourse/pull/32442/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5 )
2025-05-14 16:31:19 -05:00
a9c648dff4
FIX: this was hiding the top of the composer on iOS ( #32734 )
2025-05-14 22:46:00 +02:00
f291452c9a
DEV: bump max attachment size to 10MB ( #32730 )
...
Brings it in line with `max_image_size_kb`.
2025-05-14 14:00:53 -04:00
ded2938700
UX: Focus on sign up form in social auth flow ( #32728 )
...
If user returns to the signup form with data from their social login,
then we shouldn't show the right side column, because it is confusing to
have buttons there that restart the social login flow. This PR makes it
so we only show the signup form.
Internal ticket: /t/154184
---------
Co-authored-by: Régis Hanol <regis@hanol.fr >
2025-05-14 13:28:43 -04:00
267736e5bc
DEV: Show login-required splash in root route (take 2) ( #32629 )
2025-05-14 11:25:43 -04:00
c881bdb340
Revert "DEV: Speed up "having working core features" shared example by ~30%"
...
This reverts eff31e0d42c535ee115317f5b63ff70d90097911.
While it passes our build, it breaks too many custom themes and plugins.
2025-05-14 15:49:58 +02:00
2066e8619f
REFACTOR: merge mobile reviewables css into common ( #32714 )
...
This moves the mobile styles into common under the relevant breakpoint.
No major visual changes should result.
2025-05-14 09:36:35 -04:00
e806cfbe1f
Update translations ( #32703 )
2025-05-14 14:34:07 +02:00
33fbf19d05
FIX: ensure we can lookup identical ip addresses ( #32725 )
...
This has been broken in
b6aad28ccf
2025-05-14 11:48:01 +02:00
c8d49a4d0a
UX: split admin logo and fonts to separate pages ( #32700 )
...
Before we had logo and fonts page merged together. Decided to split
them.
2025-05-14 14:02:34 +08:00
02d0febf3a
DEV: Fix full page search core features system test ( #32722 )
...
Follow-up to eff31e0d42c535ee115317f5b63ff70d90097911
This removes the assumption that the search dropdown is present across
all themes and plugins.
2025-05-14 12:19:08 +08:00
8e1357068b
DEV: Improve core features spec ( #32721 )
...
This commit removes the assumption that the sidebar will always be
present as that may not always be the case in certain themes.
2025-05-14 12:36:52 +10:00
a445e8cce5
DEV: Port the about page extra groups functionality into core ( #32659 )
...
We want to merge the theme component that allows admins to display extra groups on the about page. The settings for this are now under About your site.
All the code is lift-and-shift, with some minor adjustments, e.g. theme components can't use the group_list setting type, but it has been converted to that here.
Also the system tests for the admin controls are new.
This whole thing is gated behind a hidden site setting to avoid double rendering while we deprecate the theme component.
2025-05-14 09:44:25 +08:00
404e2598b3
DEV: Fix flaky system tests ( #32720 )
...
We were not correctly relying on capybara matchers leading to test
flakiness
```
ailure/Error: super
Capybara::Playwright::Node::StaleReferenceError:
Element is not attached to the DOM
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/capybara-playwright-driver-0.5.6/lib/capybara/playwright/node.rb:91:in `rescue in assert_element_not_stale'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/capybara-playwright-driver-0.5.6/lib/capybara/playwright/node.rb:81:in `assert_element_not_stale'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/capybara-playwright-driver-0.5.6/lib/capybara/playwright/node.rb:124:in `visible_text'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/capybara-3.40.0/lib/capybara/node/element.rb:60:in `block in text'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/capybara-3.40.0/lib/capybara/node/base.rb:84:in `synchronize'
./spec/rails_helper.rb:421:in `synchronize'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/capybara-3.40.0/lib/capybara/node/element.rb:60:in `text'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/capybara-3.40.0/lib/capybara/result.rb:44:in `each'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/capybara-3.40.0/lib/capybara/result.rb:44:in `each'
./spec/system/page_objects/modals/sidebar_edit_categories.rb:45:in `map'
./spec/system/page_objects/modals/sidebar_edit_categories.rb:45:in `has_categories?'
./spec/system/editing_sidebar_categories_navigation_spec.rb:161:in `block (2 levels) in <main>'
```
2025-05-14 09:14:29 +08:00
736f247511
Build(deps): Bump terser from 5.39.0 to 5.39.1 ( #32716 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.39.0 to 5.39.1.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.39.0...v5.39.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-14 07:48:54 +08:00
94932de163
Build(deps-dev): Bump ember-qunit from 9.0.2 to 9.0.3 ( #32718 )
...
Bumps [ember-qunit](https://github.com/emberjs/ember-qunit ) from 9.0.2
to 9.0.3.
- [Release notes](https://github.com/emberjs/ember-qunit/releases )
-
[Changelog](https://github.com/emberjs/ember-qunit/blob/main/.release-plan.json )
- [Commits](https://github.com/emberjs/ember-qunit/commits )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-14 07:15:18 +08:00
fdf3d8ea5d
FIX: wrong class in schema setting editor stylesheet file ( #32715 )
...
relates to https://github.com/discourse/discourse/pull/32707 and
https://github.com/discourse/discourse/pull/32706
I've retested manually and all should be fine now.
2025-05-13 19:00:28 -03:00
105f5eca8c
UX: Modal to inherit border radius ( #32709 )
2025-05-13 15:27:51 -05:00
2a738620c4
UX: minor style adjustments for experimental translation feature ( #32708 )
...
Before:
After:
2025-05-13 16:10:37 -04:00
51c687e6db
UX: add missing import to admin_base.scss ( #32707 )
...
While re-reviewing what I did in
https://github.com/discourse/discourse/pull/32706 , I noticed that the
import for customize_show_schema in `admin_base.scss` file was missing.
Probably removed by mistake in the rebase.
2025-05-13 16:41:13 -03:00
5072615290
FEATURE: Add the group show endpoint to search groups by id instead of only the slug name ( #32442 )
...
**Description**
As part of a customer request, we have added the option to search groups
by ID when doing API calls. However, in doing so we have decided to
correct the confusion around the group's routes. Previously the route
would look like `g/:id` while taking the `name` of the group as the
param. For example, when getting a group the route would be like this:
```
GET /g/admins
```
This would make the code in the controller seem as if it was handling
the group IDs instead of names. With these changes, this should be
addressed.
2025-05-13 14:22:06 -05:00
4d99c839b6
FEATURE: porting type object to site settings ( #32706 )
2025-05-13 14:30:24 -03:00
c688554cdd
Build(deps-dev): Bump ember-async-data from 2.0.0 to 2.0.1 ( #32699 )
...
Bumps
[ember-async-data](https://github.com/tracked-tools/ember-async-data )
from 2.0.0 to 2.0.1.
- [Release
notes](https://github.com/tracked-tools/ember-async-data/releases )
-
[Changelog](https://github.com/tracked-tools/ember-async-data/blob/main/CHANGELOG.md )
- [Commits](https://github.com/tracked-tools/ember-async-data/commits )
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Discourse CI <ci@ci.invalid >
2025-05-13 15:25:30 +02:00
7e3b2c4738
Build(deps-dev): Bump testem from 3.15.2 to 3.16.0 ( #32697 )
...
Bumps [testem](https://github.com/testem/testem ) from 3.15.2 to 3.16.0.
- [Release notes](https://github.com/testem/testem/releases )
- [Commits](https://github.com/testem/testem/compare/v3.15.2...v3.16.0 )
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Discourse CI <ci@ci.invalid >
2025-05-13 15:22:58 +02:00
9328ab54a0
Build(deps-dev): Bump playwright-ruby-client from 1.51.0 to 1.52.0 ( #32694 )
...
Bumps
[playwright-ruby-client](https://github.com/YusukeIwaki/playwright-ruby-client )
from 1.51.0 to 1.52.0.
-
[Commits](https://github.com/YusukeIwaki/playwright-ruby-client/compare/1.51.0...1.52.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-13 15:21:55 +02:00
0e7b9df9a6
DEV: bump max_image_size_kb to 10MB ( #32688 )
...
This allows, in particular, for larger animated image uploads. Due to
optimizing (clientside and serverside), the actual size of the uploaded
(non-animated) image often ends up being smaller than the o riginal
size. I.e. it may already be optimized before hitting this limit.
2025-05-13 08:47:38 -04:00
da956937d0
Build(deps): Bump json from 2.11.3 to 2.12.0 ( #32691 )
...
Bumps [json](https://github.com/ruby/json ) from 2.11.3 to 2.12.0.
- [Release notes](https://github.com/ruby/json/releases )
- [Changelog](https://github.com/ruby/json/blob/master/CHANGES.md )
- [Commits](https://github.com/ruby/json/compare/v2.11.3...v2.12.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-13 19:44:44 +08:00
9319b8c704
Build(deps-dev): Bump diff-lcs from 1.6.1 to 1.6.2 ( #32692 )
...
Bumps [diff-lcs](https://github.com/halostatue/diff-lcs ) from 1.6.1 to
1.6.2.
-
[Changelog](https://github.com/halostatue/diff-lcs/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/halostatue/diff-lcs/compare/v1.6.1...v1.6.2 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-13 19:44:32 +08:00
f734cdc6cf
Build(deps): Bump psych from 5.2.5 to 5.2.6 ( #32693 )
...
Bumps [psych](https://github.com/ruby/psych ) from 5.2.5 to 5.2.6.
- [Release notes](https://github.com/ruby/psych/releases )
- [Commits](https://github.com/ruby/psych/compare/v5.2.5...v5.2.6 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-13 19:44:18 +08:00
b585033a49
Build(deps-dev): Bump language_server-protocol from 3.17.0.4 to 3.17.0.5 ( #32695 )
...
Bumps
[language_server-protocol](https://github.com/mtsmfm/language_server-protocol-ruby )
from 3.17.0.4 to 3.17.0.5.
-
[Changelog](https://github.com/mtsmfm/language_server-protocol-ruby/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/mtsmfm/language_server-protocol-ruby/compare/v3.17.0.4...v3.17.0.5 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-13 19:14:31 +08:00
6f9e765ff2
Build(deps): Bump loofah from 2.24.0 to 2.24.1 ( #32696 )
...
Bumps [loofah](https://github.com/flavorjones/loofah ) from 2.24.0 to
2.24.1.
- [Release notes](https://github.com/flavorjones/loofah/releases )
-
[Changelog](https://github.com/flavorjones/loofah/blob/main/CHANGELOG.md )
-
[Commits](https://github.com/flavorjones/loofah/compare/v2.24.0...v2.24.1 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-13 19:14:11 +08:00
7315a2fc70
UX: add fixed scrollbar gutter to avoid jump with modals ( #32702 )
2025-05-13 11:43:55 +02:00
70a0cc4d7a
DEV: better error message when "becoming" an inactive user ( #32689 )
...
In development mode, when 'DISCOURSE_DEV_ALLOW_ANON_TO_IMPERSONATE' is
enabled, and going to /session/:username/become, we will now show an
error message when trying to impersonate an inactive user.
This was not obvious why trying to impersonate a user wasn't working
locally because I would hit the URL and be redirected back to the index
without any error and without being logged in.
2025-05-13 11:10:12 +02:00
32ba12a408
DEV: prevent files being watched warning when using devenv ( #32690 )
...
Ignore any files/directories in '.devenv' like we do for those in
'node_modules' to 1) speed-up watching files and 2) prevent files from
being watched multiples times (due to symlinks).
No specs since this is only a warning that is being shown in development
when using devenv.
---
Here's an example of the 100s of warning you get when using devenv
```plain
** ERROR: directory is already being watched! **
Directory: /Users/zogstrip/Poetry/discourse/plugins/discourse-login-client/.devenv/profile
is already being watched through: /nix/store/jp4qhxc2f98nyq90kia200mrygl2ndcy-devenv-profile
MORE INFO: https://github.com/guard/listen/blob/master/README.md
```
2025-05-13 11:09:53 +02:00
2f41cdd2f7
FIX: header search mobile z-index issue ( #32683 )
...
Follow up fix for #32401
2025-05-13 10:11:15 +02:00
c2ae2e244c
DEV: Fix cooked content rendering issues in the Glimmer Post Stream ( #32670 )
2025-05-12 16:23:08 -03:00
0658773056
DEV: use DButton for user header avatar menu ( #32687 )
...
We were using a vanilla `button` tag here, but can use `DButton` now,
this helps us be more consistent with classes... we had a minor issue
where class differences changed the active state between buttons here...
Before (hamburger and avatar forced active):
After (hamburger and avatar forced active):
I also noticed we have a useless title attribute on the image here, the
title should be on the button and the image doesn't need one.
I've also cleaned up the titles:
* hamburger menu was previously just `menu` but we refer to this as
`Navigation menu` generally, and that provides a lot more context
* the notification menu was "Username's account" but more accurately
it's "Notifications and account" (and I don't think we need the username
present)
2025-05-12 15:12:11 -04:00
c16bc66e1a
DEV: Enable iOS media optimization by default ( #32686 )
...
Tests following
fa03d7719ff3c41af772
2025-05-12 14:21:43 -04:00
6551bd8155
DEV: clean up review queue button classes ( #32685 )
...
These reject/approve buttons were getting `btn-default` classes rather
than `btn-danger` or `btn-success`, which meant the styles for the
colors had to be applied separately to `.approve-post` and
`.reject-post`. This also meant the styles needed an additional override
in themes.
Moving to our common button classes helps centralize the styles and
avoids a manual override being needed in themes.
Button appearance is the same before/after
2025-05-12 13:20:22 -04:00
d213cd1b00
DEV: Refactor content-tag usage in theme-transpiler, and upgrade ( #32684 )
...
This strategy allows us to synchronously init the wasm, without needing
a patch on the npm package
---------
Co-authored-by: Jarek Radosz <jarek@cvx.dev >
2025-05-12 17:54:48 +01:00
de32f00b30
DEV: add value transformer for hamburger click outside exceptions ( #32673 )
...
This allows themes to add exceptions for menus that may be triggered
from the hamburger menu... like this
```js
api.registerValueTransformer(
"hamburger-dropdown-click-outside-exceptions",
({ value }) => {
return [...value, ".topic-drafts-menu-content"];
}
);
```
2025-05-12 10:12:30 -04:00
46093eddf3
DEV: Bump linting dependencies and fix violations ( #32682 )
...
template-lint ignores added to workaround bug. Fix is pending release in https://github.com/ember-template-lint/ember-template-lint/pull/3248
2025-05-12 14:14:07 +01:00
5883085af3
DEV: Replace all @breakpoint with @viewport.* ( #32649 )
2025-05-12 12:52:45 +01:00
4e41dc87ce
Build(deps): Bump psych from 5.2.4 to 5.2.5 ( #32679 )
...
Bumps [psych](https://github.com/ruby/psych ) from 5.2.4 to 5.2.5.
- [Release notes](https://github.com/ruby/psych/releases )
- [Commits](https://github.com/ruby/psych/compare/v5.2.4...v5.2.5 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-12 11:08:50 +01:00
d915dd72f2
Build(deps-dev): Bump parallel_tests from 5.1.0 to 5.2.0 ( #32678 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from
5.1.0 to 5.2.0.
-
[Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md )
-
[Commits](https://github.com/grosser/parallel_tests/compare/v5.1.0...v5.2.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-12 11:08:20 +01:00
d8bef9450a
Build(deps-dev): Bump @ember/test-helpers from 5.2.1 to 5.2.2 ( #32680 )
...
Bumps
[@ember/test-helpers](https://github.com/emberjs/ember-test-helpers )
from 5.2.1 to 5.2.2.
- [Release
notes](https://github.com/emberjs/ember-test-helpers/releases )
-
[Changelog](https://github.com/emberjs/ember-test-helpers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/emberjs/ember-test-helpers/commits )
---------
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Discourse CI <ci@ci.invalid >
2025-05-12 11:07:58 +01:00
43872ac210
UX: search CSS refactor + fixes ( #32401 )
...
* change spacing to use consistent values
* change font weight and colours for search results
* updated copy for mobile to reflect the removal of the search icon
(using native keyboard CTA now)
* results are full-width, in line with other dropdowns; noticable in
hover effects
* trying to make sure all search results items are of equal height, were
possible
* fixing missing `in-this-topic` context button
**Ignore the silly emoji in the screenshots on mobile – different
problem, alrdy fixed on main**
## Desktop
### Search Header
| Before | After |
|--------|--------|
| 
| 
|
| |
|
| 
| 
|
| 
| 
|
| 
| 
|
### Search Welcome Banner
| Before | After |
|--------|--------|
| 
| 
|
| 
| 
|
| 
| |
| 
| |
| 
| 
|
### Search in Topic
| Before | After |
|--------|--------|
| 
| 
|
| 
| 
|
| 
| 
|
| 
| 
|
| 
| 
|
| 
| |
## Mobile
| Before | After |
|--------|--------|
| 
| 
|
| 
| 
|
| 
| 
|
| 
| 
|
| 
| 
|
| 
| 
|
---------
Co-authored-by: Yuriy Kurant <yuriy@discourse.org >
2025-05-12 11:28:12 +02:00
