Commit Graph

59279 Commits

Author SHA1 Message Date
94ea8a3158 DEV: Add appEvents trigger for flag:created (#32710)
## Changes 

This PR adds an appEvents trigger for 'flag:created'.
2025-05-16 12:13:16 -05:00
6169ac2683 UX: make the notification panel consistent with new search panel styles (#32753)
This eliminates menu panel container padding, which gets us a closer
match to the recent search panel adjustments. I've also eliminated the
menu-panel box-shadow variant — if we're not going to use it on the
search panel we should consolidate and eliminate the variance.




Before:

![image](https://github.com/user-attachments/assets/07122788-61a4-4767-a697-47cc3118d84e)


After:

![image](https://github.com/user-attachments/assets/a6f66c6f-37cd-4144-930d-d05546bba801)
2025-05-16 12:50:12 -04:00
9e17b0bc1e REFACTOR: merge desktop and mobile topic-footer.scss into common (#32712)
This moves the desktop and mobile css into common with the relevant
breakpoints. There should be no major visual changes as a result.
2025-05-16 12:31:53 -04:00
77c240e4b6 DEV: Drop deprecated PluginOutlet @tagName argument (#32770)
This has been deprecated with an admin warning for some time
2025-05-16 16:30:42 +01:00
975fb9214d UX: improve spacing of text in topic list items (#32755)
This tightens up some topic list spacing — our line height for titles
has been kind of on the large size, we've got too much space between
wrapping metadata, and sometimes not enough space between the right of
titles and avatars.
 
Generally headline line-height is recommended to be within 1.1 - 1.3,
and we were at 1.4, this puts it at 1.2
 
Before:

![image](https://github.com/user-attachments/assets/cc71ef47-5492-4aea-9caf-3b768e326b67)


After: 

![image](https://github.com/user-attachments/assets/f274a0bc-0077-41bf-abda-ddde71d805b6)
2025-05-16 10:15:44 -04:00
071ec5a240 FIX: Bug with 2FA setup right after signup (#32754) 2025-05-16 09:00:39 -04:00
41363a2a18 DEV: Silence scss mixed-decls for themes/plugins (#32750)
Fixing this everywhere will be a very large undertaking, so we're
deferring it until there is a concrete timeline for it becoming an error
in sass.

In the meantime, we'll be adding a stylelint rule to enforce ordering of
declarations/nested-blocks/mixins, so that will go some way towards
avoiding this deprecation.
2025-05-16 13:06:10 +01:00
d60ba9a948 Build(deps-dev): Bump jsuites from 5.9.1 to 5.10.0 (#32717)
Bumps [jsuites](https://github.com/jsuites/jsuites) from 5.9.1 to
5.10.0.
- [Release notes](https://github.com/jsuites/jsuites/releases)
-
[Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md)
- [Commits](https://github.com/jsuites/jsuites/commits)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-16 13:37:15 +02:00
e6f9a53b5d Build(deps-dev): Bump ember-modifier from 4.2.0 to 4.2.2 (#32758)
Bumps [ember-modifier](https://github.com/ember-modifier/ember-modifier)
from 4.2.0 to 4.2.2.
- [Release
notes](https://github.com/ember-modifier/ember-modifier/releases)
-
[Changelog](https://github.com/ember-modifier/ember-modifier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ember-modifier/ember-modifier/commits)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-16 13:36:45 +02:00
772268647c Build(deps): Bump terser from 5.39.1 to 5.39.2 (#32759)
Bumps [terser](https://github.com/terser/terser) from 5.39.1 to 5.39.2.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/compare/v5.39.1...v5.39.2)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-16 11:02:08 +02:00
b7865cdfe1 DEV: Run plugin system tests job on 16 core runners (#32767)
This is the bottleneck for the `tests` workflow now so we are throwing
more cores at the job
2025-05-16 16:33:01 +08:00
fee57fe1c3 DEV: Update labels for our self hosted runners (#32766)
We have 8 and 16 cores runner now but 16 core runners are not quite
ready for prime time yet.
2025-05-16 15:46:14 +08:00
7820dd2b8f FIX: Reset password link broken for non-staff user in confirm session dialog (#32765) 2025-05-16 15:09:03 +08:00
672007549b FIX: Allow existing users to accept invites that add them to a group. (#32762)
Check to see if the user needs to be added to any groups before redirecting. To avoid introducing a CSRF issue, force the user through the normal invite acceptance flow, ensuring there's user interaction before being added to any groups.

This change also tweaks the behaviour of 2e10fe9 to not follow redirects of expired invitations.

Co-authored-by: Krzysztof Kotlarek <kotlarek.krzysztof@gmail.com>
2025-05-16 16:42:02 +10:00
c3d0756df8 DEV: Add ca2dee5 to .git-glame-ignore-revs (#32764)
ca2dee5 was a reformatting commit that can be ignored in `git blame`.
2025-05-16 16:19:03 +10:00
f90ed6424f Build(deps-dev): Bump rubocop from 1.75.5 to 1.75.6 (#32756)
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.75.5 to
1.75.6.
- [Release notes](https://github.com/rubocop/rubocop/releases)
-
[Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
-
[Commits](https://github.com/rubocop/rubocop/compare/v1.75.5...v1.75.6)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-16 13:16:41 +08:00
e0132d1baf Build(deps): Bump bootsnap from 1.18.5 to 1.18.6 (#32757)
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.18.5 to
1.18.6.
-
[Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/Shopify/bootsnap/compare/v1.18.5...v1.18.6)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-16 13:16:29 +08:00
Sam
8437288b54 FIX: correctly guard for missing close method (#32760)
`?.close()` is an unsafe pattern

```
test = {}
test?.close()
VM363:1 Uncaught TypeError: test?.close is not a function
    at <anonymous>:1:7
```
2025-05-16 13:04:23 +10:00
3519226539 UX: Refactor the edit topic title UI (#32339) 2025-05-15 13:10:42 -05:00
9cb3e2c5d2 DEV: Refactor tests & add animation (#32547) 2025-05-15 13:10:29 -05:00
1f131fb854 UX: more consistent admin search hover/focus color (#32752)
little follow-up to 264b9db18896d4125fa9a75898867bd127d80316 to make
admin search match topic search hover/focus styles


Before:

![image](https://github.com/user-attachments/assets/070643f6-eee4-4671-a891-c0e4d5695c03)


After: 

![image](https://github.com/user-attachments/assets/8637ee7b-9d62-44a7-ab08-a062dd63f4f1)
2025-05-15 13:30:22 -04:00
264b9db188 UX: improve admin search focus states (#32751)
Before:

![image](https://github.com/user-attachments/assets/7fee4e81-433a-4783-9055-a6ecdd7f4e10)


After: 

![image](https://github.com/user-attachments/assets/2924e54c-438c-409d-85ae-3257ee608bd7)
2025-05-15 13:18:31 -04:00
8918537b55 FIX: adds missing search-input-wrapper (#32749)
This node has been incorrectly removed in
215a129b68

Before:

![Screenshot 2025-05-15 at 18 30
59](https://github.com/user-attachments/assets/f7a7a544-59da-49ed-8c87-4f821984f140)

After:

![Screenshot 2025-05-15 at 18 30
27](https://github.com/user-attachments/assets/de77a888-8f48-410b-a26a-7abe2e08f9e6)
2025-05-15 18:51:05 +02:00
d564386066 UX: Add discourse text icon (#32744)
![CleanShot 2025-05-15 at 12 02
49@2x](https://github.com/user-attachments/assets/eacf0376-4491-4fcd-8e7e-c052564f0093)
2025-05-15 15:58:32 +02:00
ce2729e676 DEV: trigger single event when multiple posts are destroyed at once (#32731)
a complement to the :post_destroyed event - customer needed an action to
happen just once when the wrench icon was used to delete one or more
posts ...
2025-05-15 09:57:07 -04:00
305ebedfa1 Allow passing a redirect path to a param on the /login route (#32711)
Detects the `redirect` queryParam on the /login route. If the user is
already logged in, navigates to that page. Otherwise, sets the
"destination_url" cookie so that the user will be redirected after
logging in.

If the param doesn't start with a single slash, ignore it and follow
previous behavior (navigate to "/" or log in then navigate there)

Respects subfolder configs.
2025-05-15 08:48:06 -05:00
2e4076f586 DEV: standardise toasts duration (#32741)
Toasts can now have two durations:
- `short` -> 3000ms
- `long` -> 5000ms

For backwards compatibility integer values still work but will display a deprecation message in the browser console.
2025-05-15 14:59:37 +02:00
215a129b68 Revert UX: header search mobile support (#32748)
This reverts the complete work on "Improvements to mobile search" while
respecting all the related changes that were made after the next two
PRs:

- https://github.com/discourse/discourse/pull/32306
- https://github.com/discourse/discourse/pull/31711
2025-05-15 14:27:40 +02:00
5a8ab0b007 Build(deps): Bump prosemirror-view from 1.39.2 to 1.39.3 in the prosemirror group (#32738)
Bumps the prosemirror group with 1 update:
[prosemirror-view](https://github.com/prosemirror/prosemirror-view).


Updates `prosemirror-view` from 1.39.2 to 1.39.3
-
[Changelog](https://github.com/ProseMirror/prosemirror-view/blob/master/CHANGELOG.md)
-
[Commits](https://github.com/prosemirror/prosemirror-view/compare/1.39.2...1.39.3)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-15 14:16:33 +02:00
11b740be89 DEV: Resolve content-tag initSync deprecation (#32746) 2025-05-15 13:04:52 +01:00
d90b03f3bf DEV: Remove deprecated/archived theme from CI (#32747) 2025-05-15 13:04:43 +01:00
358fc9631c DEV: Raise error if lib/viewport is imported (#32745) 2025-05-15 12:46:12 +01:00
eed9e1674b Build(deps): Bump @faker-js/faker from 9.7.0 to 9.8.0 (#32739)
Bumps [@faker-js/faker](https://github.com/faker-js/faker) from 9.7.0 to
9.8.0.
- [Release notes](https://github.com/faker-js/faker/releases)
- [Changelog](https://github.com/faker-js/faker/blob/next/CHANGELOG.md)
- [Commits](https://github.com/faker-js/faker/compare/v9.7.0...v9.8.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-15 13:40:02 +02:00
51ebe7064c FEATURE: Show localized posts and topics based on user's locale (#32618)
Related:
- https://github.com/discourse/discourse-translator/pull/205
- https://github.com/discourse/discourse-translator/pull/274
- https://github.com/discourse/discourse-translator/pull/294

With this PR, we will start showing localized posts (if available) based
on the user's locale.

This work had been done in discourse-translator, but is now moving to
core.
2025-05-15 19:11:06 +08:00
752f9a867b Build(deps): Bump bootsnap from 1.18.4 to 1.18.5 (#32737)
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.18.4 to
1.18.5.
-
[Changelog](https://github.com/Shopify/bootsnap/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/Shopify/bootsnap/compare/v1.18.4...v1.18.5)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-15 11:27:14 +02:00
7558e2c7cd DEV: revert admin users list change (#32723)
This change was unfortunately introduced in
b6aad28ccf (diff-5c7ecbec34de2166b60c5381df93a4e8438a2dbb6dcb8af0203cff4462fbc64b)
to prevent a failing spec due to the lack of last message bus id.

This commit reverts the change associated to it which was causing the
JSON response to be an object instead of an array.
2025-05-15 09:48:01 +02:00
231b3943d3 UX: simplify admin search, make more accessible (#32733)
This simplifies the admin search and adds some basic accessibility

Simplification: 
* Removes the filters for now, both in the modal and full-screen 
* Removes the link to full-screen from the modal
* Simpler input placeholder text
* Positioned to sit higher on the page, similar to a command palette 

Accessibility: 
* Results (or lack of) announced for screenreaders after query 

Bonus: 
* Makes the modal input sticky on scroll 
* Combined some styles shared between this and the chat menu (modifier +
k) under a `--quick-palette` class



Before:

![image](https://github.com/user-attachments/assets/0af2d741-e870-4ad2-b305-57dc4afc3946)


After:


![image](https://github.com/user-attachments/assets/a8492aed-03c7-4d73-a3d3-ae89834b82bc)

---------

Co-authored-by: Krzysztof Kotlarek <kotlarek.krzysztof@gmail.com>
2025-05-15 16:31:03 +10:00
29eb2eb096 FIX: Lock Bullet gem to a compatible version (#32724)
Because we use a custom ContentSecurityPolicy middleware, the latest versions (> 8.0.3) of Bullet error out on load.

This PR locks the gem to the latest compatible version.
2025-05-15 10:03:24 +08:00
933dd06b4f Build(deps): Bump google-protobuf from 4.30.2 to 4.31.0 (#32735)
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf)
from 4.30.2 to 4.31.0.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
-
[Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
-
[Commits](https://github.com/protocolbuffers/protobuf/compare/v4.30.2...v4.31.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-15 09:14:14 +08:00
7e246996ae Build(deps-dev): Bump mime-types-data from 3.2025.0507 to 3.2025.0514 (#32736)
Bumps [mime-types-data](https://github.com/mime-types/mime-types-data)
from 3.2025.0507 to 3.2025.0514.
-
[Changelog](https://github.com/mime-types/mime-types-data/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/mime-types/mime-types-data/compare/v3.2025.0507...v3.2025.0514)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-15 09:13:12 +08:00
4df5638b3f DEV: Remove discourse-logster-rate-limit-checker from official plugins (#32727)
This is a plugin that is no longer maintained.
2025-05-15 09:10:15 +08:00
02a805c3ad DEV: Revert unintended changes to GroupsController #add_members and its corresponding route (#32732)
Reverted unintended changes to group routes made
[here](https://github.com/discourse/discourse/pull/32442/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5)
2025-05-14 16:31:19 -05:00
a9c648dff4 FIX: this was hiding the top of the composer on iOS (#32734) 2025-05-14 22:46:00 +02:00
f291452c9a DEV: bump max attachment size to 10MB (#32730)
Brings it in line with `max_image_size_kb`.
2025-05-14 14:00:53 -04:00
ded2938700 UX: Focus on sign up form in social auth flow (#32728)
If user returns to the signup form with data from their social login,
then we shouldn't show the right side column, because it is confusing to
have buttons there that restart the social login flow. This PR makes it
so we only show the signup form.

Internal ticket: /t/154184

---------

Co-authored-by: Régis Hanol <regis@hanol.fr>
2025-05-14 13:28:43 -04:00
267736e5bc DEV: Show login-required splash in root route (take 2) (#32629) 2025-05-14 11:25:43 -04:00
c881bdb340 Revert "DEV: Speed up "having working core features" shared example by ~30%"
This reverts eff31e0d42c535ee115317f5b63ff70d90097911.

While it passes our build, it breaks too many custom themes and plugins.
2025-05-14 15:49:58 +02:00
2066e8619f REFACTOR: merge mobile reviewables css into common (#32714)
This moves the mobile styles into common under the relevant breakpoint.
No major visual changes should result.
2025-05-14 09:36:35 -04:00
e806cfbe1f Update translations (#32703) 2025-05-14 14:34:07 +02:00
33fbf19d05 FIX: ensure we can lookup identical ip addresses (#32725)
This has been broken in
b6aad28ccf

We correctly access the users object and added a test to prevent future
regressions.
2025-05-14 11:48:01 +02:00