9d172eeaa5
REFACTOR: removes implicit operand conversion ( #9700 )
2020-05-08 09:19:36 +02:00
6359a5f8a9
DEV: Fix poll plugin causing error when server reloads in dev env.
2020-05-08 14:59:55 +08:00
d8d54a92f1
FEATURE: tighten rate limiting rules for forgot password
...
1. Total 6 attempts per day per user
2. Total of 5 per unique email/login that is not found per hour
3. If an admin blocks an IP that IP can not request a reset
2020-05-08 13:30:51 +10:00
1840023c28
UX: Improve banner & alert close button alignment and consistency
2020-05-07 22:57:52 -04:00
609e929186
Revert "Revert "DEV: upgrade to Rails 6.0.3""
...
This reverts commit 2ff8b4f5d9dd72a55d7ebdc23a3758dd5ec4682d.
Attempt #2 at a Rails update this time we also update the
rails_multisite gem to allow for cleaner reordering
2020-05-08 11:49:22 +10:00
efd0e4d02b
FIX: Don't trigger user_updated event for bot users.
2020-05-08 09:28:16 +08:00
a3e1e9ef16
FIX: remove deprecated URI.escape ( #9697 )
...
During Nokogumbo changes I introduced back URI.escape which is deprecated.
2020-05-08 11:14:59 +10:00
22dffe6f69
FIX: Do not allow null options for bookmark manager
2020-05-08 15:24:59 +00:00
e83dc75238
FIX: Migration to set column NOT NULL for delete_when_reminder_sent on bookmarks ( #9696 )
...
Also fix typo in original migration.
Meta: https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542/152?u=mjrbrennan
2020-05-08 10:43:23 +10:00
ef94b0f1a7
FIX: Incorrect CSS class
2020-05-07 16:29:09 -04:00
94d10b46ca
Admin popup menu needs a higher z-index than the bg cloak on mobile
2020-05-07 16:24:47 -04:00
f9608c0af5
DEV: Remove INLINE_ONEBOX_* constants
...
There were two constants here, `INLINE_ONEBOX_LOADING_CSS_CLASS` and
`INLINE_ONEBOX_CSS_CLASS` that were both longer than the strings they
were DRYing up: `inline-onebox-loading` and `inline-onebox`
I normally appreciate constants, but in this case it meant that we had
a lot of JS imports resulting in many more lines of code (and CPU cycles
spent figuring them out.)
It also meant we had an `.erb` file and had to invoke Ruby to create the
JS file, which meant the app was harder to port to Ember CLI.
I removed the constants. It's less DRY but faster and simpler, and
arguably the loss of DRYness is not significant as you can still search
for the `inline-onebox-loading` and `inline-onebox` strings easily if
you are refactoring.
2020-05-07 16:14:38 -04:00
3567a90661
DEV: Ember Addon needs a vendor dir
2020-05-07 15:45:35 -04:00
744bbf6904
FEATURE: exclude muted categories from the "top" topics list.
2020-05-08 00:34:53 +05:30
4891276742
Reduce the width of the input field on desktop
2020-05-07 20:36:36 +02:00
788e305469
FIX: parenthesis were wrong, resulting in an always true expression ( #9690 )
2020-05-07 19:56:35 +02:00
79c64eaeff
DEV: Move pretty-text into an ember-addon format ( #9689 )
2020-05-07 12:37:47 -04:00
781e3f5e10
DEV: Use response.parsed_body in specs ( #9615 )
...
Most of it was autofixed with rubocop-discourse 2.1.1.
2020-05-07 17:04:12 +02:00
69ef0da4c2
FIX: preload-store was removed
2020-05-07 11:00:47 -04:00
3cd412ae02
REFACTOR: removes useless variable assignment ( #9666 )
2020-05-07 16:41:26 +02:00
1dd9df9cd0
REFACTOR: removes overwritten properties and duplicates fn ( #9686 )
2020-05-07 16:39:53 +02:00
265baa40c6
REFACTOR: useless conditional as 'data' always evaluates to true ( #9685 )
2020-05-07 16:38:38 +02:00
99c3ce03cb
REFACTOR: removes superfluous argument ( #9684 )
...
hideTooltip doesnt accept any argument
2020-05-07 16:38:23 +02:00
206d45fd96
REFACTOR: removes superfluous argument ( #9683 )
2020-05-07 16:38:09 +02:00
9846c43d93
REFACTOR: removes use of undeclared variable ( #9682 )
2020-05-07 16:37:56 +02:00
af78d188b8
REFACTOR: removes useless self assignment ( #9681 )
2020-05-07 16:37:20 +02:00
23d585f255
REFACTOR: removes unreachable statement ( #9680 )
2020-05-07 16:37:02 +02:00
8be0ba3aa4
REFACTOR: function was incorrectly called as a constructor ( #9679 )
2020-05-07 16:36:29 +02:00
e74170cd9e
REFACTOR: Superfluous arguments passed to function resolveSize ( #9678 )
...
resolveSize accepts only one param
2020-05-07 16:36:15 +02:00
affc79bb68
REFACTOR: removes useless assignment to local variable ( #9676 )
2020-05-07 16:35:54 +02:00
08e8ae82cc
REFACTOR: removes useless conditional ( #9677 )
2020-05-07 16:34:49 +02:00
a078b086ba
REFACToR: removes useless assignment to local variable ( #9675 )
2020-05-07 16:34:36 +02:00
a04b226c2b
REFACTOR: removes useless conditional ( #9674 )
...
We already check if there's a post in the line before.
2020-05-07 16:34:25 +02:00
d5fe1279bd
REFACTOR: value assigned to precision here is unused ( #9673 )
2020-05-07 16:34:14 +02:00
a2109bd9b2
REFACTOR: value assigned to cp here is unused. ( #9672 )
2020-05-07 16:30:51 +02:00
930989d462
REFACTOR: variable '_postSnapshot' always evaluates to true ( #9671 )
2020-05-07 16:28:28 +02:00
d020e70643
REFACTOR: removes unreachable return statement ( #9670 )
2020-05-07 16:27:53 +02:00
48375db848
REFACTOR: removes superfluous argument passed to findWidget ( #9669 )
...
findWidget accepts only one argument
2020-05-07 16:27:15 +02:00
5a201082c7
REFACTOR: removes useless conditional ( #9667 )
...
This use of variable 'content' always evaluates to true.
2020-05-07 16:25:44 +02:00
864f48b2e6
REFACTOR: removes useless conditional ( #9668 )
...
Given we will return true on the line before if inlineEmoji, this will always be false.
2020-05-07 16:25:23 +02:00
01272f2085
REFACTOR: removes unreachable code ( #9665 )
...
* REFACTOR: removes unreachable code
* this one too
2020-05-07 16:24:54 +02:00
ac4251fc9d
REFACTOR: publishedPage property was duplicated ( #9664 )
2020-05-07 16:24:35 +02:00
3debb576d4
REFACTOR: require-valid-alt-text was duplicated ( #9663 )
2020-05-07 16:24:15 +02:00
2ff8b4f5d9
Revert "DEV: upgrade to Rails 6.0.3"
...
This was causing issues during multisite:migrate
https://meta.discourse.org/t/multisite-migrate-broken-since-rails-6-0-3-update/150691
This reverts commit 136a5456534c7e468b8052f865ce970a3bf375e9.
2020-05-07 11:44:39 +01:00
87b1d435d2
FIX: improves positioning of sk in mobile when inside a modal ( #9657 )
2020-05-07 09:10:29 +02:00
136a545653
DEV: upgrade to Rails 6.0.3
...
Upgrades Rails to latest, this version has better compatibility
with Ruby 2.7
During the upgrade we needed a new cleaner mechanism for configuring
message bus.
All tests are green.
If anything weird pops up please revert.
2020-05-07 15:53:40 +10:00
37be2958f7
DEV: Allow specifying if a notification is high_priority on create ( #9660 )
...
This allows for special cases where we may not want a certain notification type to ALWAYS be high priority (e.g. a topic timer).
2020-05-07 14:35:32 +10:00
be48e503fd
FIX: Show the Bookmark button for PM topics ( #9659 )
...
There is no point in suppressing this now that we have bookmark reminders.
2020-05-07 14:30:10 +10:00
6fb0f36ce1
FEATURE: Optionally delete bookmark when reminder sent ( #9637 )
...
We now show an options gear icon next to the bookmark name.
When expanded we show the "delete bookmark when reminder sent" option. The value of this checkbox is saved in local storage for the user.
If this is ticked, when a reminder is sent for the bookmark the bookmark itself is deleted. This is so people can use the reminder functionality by itself.
Also remove the blue alert reminder section from the "Edit Bookmark" modal as it just added clutter, because the user can already see they had a reminder set:
Adds a default false boolean column `delete_when_reminder_sent` to bookmarks.
2020-05-07 13:37:39 +10:00
423802fbce
UX: Fix modal positioning when iOS keyboard is visible
2020-05-06 23:06:57 -04:00
