Commit Graph

32369 Commits

Author SHA1 Message Date
9d2e2867cc s/fa-icon/d-icon (#7337) 2019-04-08 15:51:38 +02:00
0d2a1fce51 REFACTOR: Pass down currentUser to post-cooked widget (#7333)
* REFACTOR: Pass down `currentUser` to `post-cooked` widget
2019-04-08 14:50:53 +01:00
fd6b594625 Fix the build. 2019-04-08 21:30:17 +08:00
2ae87a27fa make rubocop happy 2019-04-08 17:03:26 +05:30
f0f3deb32b PERF: Simplify query of UserStat#update_topic_reply_count.
For a user with alot of posts, we get a 25% speed up.
2019-04-08 17:48:19 +08:00
f524f8f811 Remove Yahoo login support from core and deprecate OpenID2.0 (#7310)
- Plugin developers using OpenID2.0 should migrate to OAuth2 or OIDC. OpenID2.0 APIs will be removed in v2.4.0

- For sites requiring Yahoo login, it can be implemented using the OpenID Connect plugin: https://meta.discourse.org/t/103632

For more information, see https://meta.discourse.org/t/113249
2019-04-08 10:38:25 +01:00
6a05f190c6 PERF: Do not create staged users for most rejected incoming emails (#7301)
Previously we would create users, then destroy them at the end of the job if the post was rejected. Now we do not create users unless required.
2019-04-08 10:36:39 +01:00
108c231d1c FIX: Clean up topic_search_data of trashed topics.
This keeps the index and table smaller.
2019-04-08 16:53:39 +08:00
c4997ce85f FIX: Don't try and reindex posts that have been trashed. 2019-04-08 16:38:43 +08:00
b7d8bbc095 PERF: Add index for post_search_data and topic_search_data. 2019-04-08 16:37:54 +08:00
4791d992dc PERF: Add index id DESC, baked_version ON posts.
A scheduled job runs `Post.rebake_old` with a limit of 80 which does a
look up for the latest posts that have not been baked to the latest
version. Before this commit, the query would run using the primary key's
index and does a reverse scan. However the query performance quicky
becomes bad as more and more of the latest posts have been baked to the
latest version.
2019-04-08 15:33:16 +08:00
ca57e18f42 UX: display signup cta even if 'must_approve_users' setting enabled. 2019-04-08 12:27:56 +05:30
d53cc07de1 Version bump to v2.3.0.beta8. v2.3.0.beta8 2019-04-08 12:28:34 +08:00
33fa249fa5 SECURITY: Remove XSS in composer preview when applying image scale buttons. 2019-04-08 11:22:14 +08:00
13c6bf54d0 FIX: Sometimes queued post would have a string for a category
In this case, don't migrate the old queued post category
2019-04-06 20:38:38 -04:00
6525613b89 PERF: Use joins for Post.for_mailing_list instead of NOT IN.
Joining on the topics table and then filtering the topics against a large set of
ids is so much slower than doing a join on a sub query.
2019-04-06 07:58:55 +08:00
84eb9bc1c9 UX: Only highlight close icon on hover, not lock 2019-04-05 17:43:14 -04:00
10314cbb86 UX: Add "consecutive" to visit badge short descriptions 2019-04-05 16:25:08 -04:00
a1c2181232 UX: Better close button positioning in alerts, some cleanup 2019-04-05 16:21:16 -04:00
a6f283da30 UX: Show tags on flags too 2019-04-05 14:22:45 -04:00
8181ad646b FIX: Queued Posts were not saving tags properly 2019-04-05 14:07:47 -04:00
06e3b25d04 FIX: 'currentUser' is a property of the 'widget' 2019-04-05 18:43:04 +02:00
347e3e5a46 Version bump to v2.3.0.beta7 v2.3.0.beta7 2019-04-05 12:24:14 -04:00
b005a84530 FIX: decoratorHelper.widget is not always present 2019-04-05 12:07:24 -04:00
acce7330a3 Typo fix 2019-04-05 11:23:22 -04:00
43a905279f FIX: Layout was off in single-page user-preferences 2019-04-05 10:59:52 -04:00
cbc311e4ed UX: Update the reviewable count before the message bus
In certain edge cases, the message bus won't send the message to the
user about the updated review count and it can go out of sync.

This patch synchronizes the review count every time:

1. The user visits the "Needs Review" page

2. Every time the user performs an action
2019-04-05 10:35:38 -04:00
19a1d35f66 fix linting (#7329) 2019-04-05 15:28:41 +01:00
131eba0366 FIX: Hide post replies content for ignored users (#7320) 2019-04-05 16:13:36 +02:00
9c2e6b9a54 FIX: Migrated flags should be reviewable by moderators 2019-04-05 10:04:23 -04:00
e7a6f0698d Update translations 2019-04-05 10:02:54 -04:00
9dd325f805 FIX: skip some checks for CJK locale in TextSentinel (#7322) 2019-04-05 15:07:49 +02:00
ca33d091b3 FIX: don't trigger notifications when changing category/tags of unlisted topics (#7323) 2019-04-05 15:06:38 +02:00
8f4527c1f1 FIX: recover from migration failure
If the migration somehow failed halfway then just run through, when ddl
transactions are disabled stuff can get somewhat odd.
2019-04-05 21:53:07 +11:00
a7a5f90e20 Annotate models. 2019-04-05 17:13:12 +08:00
0bd480c600 UX: displays exact date on title attribute of topic timer info (#7326) 2019-04-05 09:44:10 +02:00
9b288613ae DEV: remove span from inside <tr> and move meta info to a td (#7324) 2019-04-05 09:32:11 +02:00
6f1652bb53 add header cloak after all panels are added (#7325) 2019-04-04 22:54:05 -07:00
0744d2ef73 PERF: speed up suggested unread
Previously we tried using a sub-query which has some terrible performance
implications, by adding 1 extra query we can eliminate the PG issue

A join to user_stats also is prone to the same slowdown
2019-04-05 15:55:29 +11:00
ca4c9abec7 PERF: Add index for (action_type,created_at) on user_actions` table.
Speeds up counting of likes in `About#stats`.
2019-04-05 12:49:45 +08:00
81a1bafe54 PERF: Speed up home page unread+new query
restructure query so it avoids ORs

It appears postgres is picking suboptimal indexes if too many ORs exist
despite how trivial the condition is.

This bypasses conditional in the query and evals them upfront.

On meta for my user this made a 10x perf difference.

This boils down to either having `OR u.admin` or not having `OR u.admin` in
the query.
2019-04-05 15:25:19 +11:00
5b837f620b correct unread resetting to handle nulls
Note, to avoid race conditions we are setting last_unread to 10 minutes ago
if there is nothing unread.

This is safer in case of in progress transactions
we don't want to lose unread for any window of time.
2019-04-05 13:42:41 +11:00
5f896ae8f7 PERF: Keep track of when a users first unread is
This optimisation avoids large scans joining the topics table with the
topic_users table.

Previously when a user carried a lot of read state we would have to join
the entire read state with the topics table. This operation would slow down
home page and every topic page. The more read state you accumulated the
larger the impact.

The optimisation helps people who clean up unread, however if you carry
unread from years ago it will only have minimal impact.
2019-04-05 12:44:45 +11:00
d299197392 DEV: Add missing test cases for Topic.for_digest and Topic.secured. 2019-04-05 09:00:48 +08:00
c9ddc6ce30 FIX: Make sure the site setting works and fix build 2019-04-04 17:44:10 -04:00
aa4a38b08a FIX: computed is not used 2019-04-04 17:38:27 -04:00
a0f7953f0c remove extra lines 2019-04-04 17:03:57 -04:00
8af7237092 FIX: Only perform logic on create commits 2019-04-04 17:01:47 -04:00
2c7a50860f DEV: disable missing post uploads check by default. 2019-04-05 02:29:10 +05:30
47eefb9f37 remove wip comments 2019-04-04 16:47:02 -04:00