Commit Graph

37535 Commits

Author SHA1 Message Date
a239900522 UI: reduces category row description margin (#9834) 2020-05-19 20:44:54 +02:00
05d8091bd3 DEV: adds triggerOnChangeOnTab option to select-kit (#9833)
Usage:

```
options=(hash triggerOnChangeOnTab=false)
```

This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
42229fecad Build(deps): Bump rbtrace from 0.4.12 to 0.4.13 (#9827)
Bumps [rbtrace](https://github.com/tmm1/rbtrace) from 0.4.12 to 0.4.13.
- [Release notes](https://github.com/tmm1/rbtrace/releases)
- [Commits](https://github.com/tmm1/rbtrace/compare/v0.4.12...v0.4.13)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-19 12:46:16 -04:00
b23fe547ab Build(deps): Bump puma from 4.3.3 to 4.3.4 (#9824)
Bumps [puma](https://github.com/puma/puma) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v4.3.3...v4.3.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-19 12:40:39 -04:00
01c27d991a Build(deps-dev): Bump minitest from 5.14.0 to 5.14.1 (#9807)
Bumps [minitest](https://github.com/seattlerb/minitest) from 5.14.0 to 5.14.1.
- [Release notes](https://github.com/seattlerb/minitest/releases)
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc)
- [Commits](https://github.com/seattlerb/minitest/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-19 11:34:53 -04:00
ab6737c44a UX: improves topic-notifications-button loading behavior (#9832) 2020-05-19 17:13:40 +02:00
38c05a4f07 FIX: Check backtrace and backtrace_locations before trying to print an error
... during plugin initialization.
2020-05-19 14:27:22 +01:00
f038f8f154 FIX: description for 'uncategorized' category was blank 2020-05-19 18:45:43 +05:30
b4c5ff17a3 FIX: Show a useful message when starting a plugin fails without a backtrace 2020-05-19 14:03:54 +01:00
7c3663ff73 UX: adds visual feedback when changing topic notifications level (#9831) 2020-05-19 13:27:57 +02:00
05ca0c908f FIX: GroupArchivedMessage belongs to Group, not User 2020-05-19 14:13:28 +03:00
e9f579bd3f DEV: Clean up thumbnail tests correctly 2020-05-19 11:04:02 +01:00
725e38f9d7 DEV: Allow plugins to request topic thumbnail sizes (#9828)
In plugin.rb, you can register new sizes like

```
register_topic_thumbnail_size [512, 512]
```

For more information about thumbnails see 03818e642a
2020-05-19 10:38:58 +01:00
f2574736a2 FEATURE: Add same site cookie 'None' option to make cross domain systems possible (#9374)
Previously reverted in cb8f8de4, but can be re-applied now that Rack has been updated
2020-05-19 10:33:46 +01:00
1647ba4624 FIX: applies flex on topic-footer-main-buttons (#9829) 2020-05-19 11:29:38 +02:00
7b7c0ef52f DEV: removes brittle test (#9826) 2020-05-19 10:02:40 +02:00
3623a395dc UI: refinements to topic footer buttons (#9780) 2020-05-19 09:51:34 +02:00
779dc30d2e FIX: Join bookmarks migration on users to avoid missing user records
* the post_actions table has no FK to users, so if a user has been
  deleted we may end up with dangling post_action records, which then
  interferes with the bookmarks migration because bookmarks DO have
  an FK to users
2020-05-19 16:31:05 +10:00
062cb1e1cb UX: Remove caret from notifications-button. 2020-05-19 13:41:13 +08:00
864fb45ff0 Improve mobile friendliness of crawler view 2020-05-19 00:24:17 -04:00
05beaa7f45 DEV: Remove override of flushdb in DiscourseRedis. 2020-05-19 10:26:23 +08:00
96c02caba7 DEV: Change use of Redis flushall to flushdb.
FLUSHALL removes all keys from all databases. Instead we only want to
remove keys from the current Redis database.
2020-05-19 10:20:00 +08:00
f99f6ca111 FIX: randomize file name when created from fixtures (#9731)
* FIX: randomize file name when created from fixtures

When a temporary file is created from fixtures it should have a unique name.
It is to prevent a collision in parallel specs evaluation

* FIX: use /tmp/pid folder to keep fixture files
2020-05-19 09:09:36 +10:00
16f6240782 FIX: Bump rack version from 2.0.8 to 2.2.2 (#9811)
Version 2.1.1 was not working with our Sidekiq but version 2.2.2 is fine
2020-05-19 08:43:45 +10:00
6d5e9db883 FIX: Restoring backup didn't clear cached translation overrides 2020-05-18 18:51:51 +02:00
27c611b1d1 FIX: Reverting multiple translation overrides didn't clear cache 2020-05-18 18:51:29 +02:00
cfad38184d FIX: improves and fixes a regression with category-selector (#9821) 2020-05-18 17:44:47 +02:00
96848b7649 UX: Allow secure media URLs to be cached for a short period of time
Signed S3 URLs are valid for 15 seconds, so we can safely allow the browser to cache them for 10 seconds. This should help with large numbers of requests when composing a post with many images.
2020-05-18 15:00:41 +01:00
303dece5ee DEV: skip this test for now (#9818)
It seems to be involved in various random failures
2020-05-18 15:37:58 +02:00
1876b3cc4c FIX: more resilient/consistent date-picker loading (#9817) 2020-05-18 15:29:24 +02:00
48ed1b40cf REFACTOR: ensures later is correctly canceled (#9796) 2020-05-18 14:20:23 +02:00
9482ddff73 UX: show caret only in topic footer buttons dropdown select boxes (#9816) 2020-05-18 14:07:40 +02:00
f968155288 FIX: Ensure no image downloads during topic thumbnail serialization
If image uploads are missing a width/height, we re-download them to update the width/height in the database. However, this takes significant resources so we don't want to run this logic during topic serialization.
2020-05-18 12:04:29 +01:00
918bd75909 FIX: allows to remove a topic timer with delete_replies as type (#9800) 2020-05-18 11:47:08 +02:00
d01c336899 DEV: Clean up some Redis leaks in test env. 2020-05-18 17:27:37 +08:00
320b21ab5b UX: allows dropdown-select-box to display a caret (#9803)
```
selectKitOptions: {
  showCaret: true // default false
}
```
2020-05-18 10:50:33 +02:00
e5dc843185 FIX: ensures hide is called when card is destroyed (#9814) 2020-05-18 10:10:40 +02:00
862773ec83 FIX: do not remove stop words when using English locale
PG already handles English stop words, the list in cppjieba is
bigger than the list PG uses, which in turn causes confusion cause
words such as "volume" are stripped using cppijieba stop word list

We will follow up with another commit here to apply the Chinese
word stopwords, but for now to eliminate the confusion we are
skipping applying the stopword list when the dictionary in PG is
in English.
2020-05-18 10:54:56 +10:00
ea63fa7de7 FIX: extract reset_last_seen_cache! in user_spec (#9808)
Helper method to avoid code duplication
2020-05-18 09:13:37 +10:00
e81a4048e3 REFACTOR: s/focusAfterOnchange/focusAfterOnChange (#9801) 2020-05-16 11:20:37 +02:00
db8e872bda DEV: Move select kit to an addon (#9797) 2020-05-15 16:07:35 -04:00
7f07c513a7 FIX: Switching composer action does not refresh composer actions content (#9791) 2020-05-15 13:54:44 -04:00
6b04760572 FIX: Component was still used by data explorer 2020-05-15 13:52:03 -04:00
eee20a9814 FIX: Include plugin CSS assets when previewing themes 2020-05-15 18:12:53 +01:00
f86b123cfc DEV: Remove use of const in untranspiled js 2020-05-15 17:55:34 +01:00
ac042c2bbe UX: Fetch higher-resolution youtube thumbnails where available
We have been using YouTube's 'hqdefault.jpg' image which works consistently to provide a 480x360 thumbnail. YouTube does provide larger thumbnails, but not consistently for every video. By using og:image, we will fetch the best resolution YouTube can provide for each video.

This commit also refactors lazy-yt to re-use the thumbnail already existing in the cooked content. This means we get lazy-loading for free, and avoid hotlinking images to YouTube (when download remote images is enabled on the site).
2020-05-15 17:49:27 +01:00
7edd312f85 UX: focus category name when editing category (#9795) 2020-05-15 18:27:06 +02:00
b07f1bfd93 FIX: displays a title on sk header if no selected name (#9794)
none has to be defined.
2020-05-15 17:36:00 +02:00
9810ca1dbd UX: Add copied text upon copy button click (#9793) 2020-05-15 17:08:46 +02:00
3a615a8bdd Update description of level 0 user limitations
With the default configuration new users can post 1 image.
2020-05-15 22:48:17 +08:00