Commit Graph

30438 Commits

Author SHA1 Message Date
a3f8ef89a6 FIX: Setting DISCOURSE_S3_REGION env variable had no effect 2018-11-21 23:15:28 +01:00
0381e99b71 UX: improving theme upload modal alignment, markup 2018-11-21 16:50:49 -05:00
c376670bd2 FIX: a search term containing '& could lead to errors
This also makes sure that the search term in front or after special characters isn't ignored.
2018-11-21 22:07:56 +01:00
58c795ef30 DEV: adds test for image-short-url (#6642) 2018-11-22 07:48:52 +11:00
a0f0bac752 Add a comment to run the 'import:ensure_consistency' rake task after a bulk import 2018-11-21 16:28:35 +01:00
715b2e85fc FIX: make danger locale warning work with plugin locales (#6639) 2018-11-21 10:13:25 +01:00
61eff22b29 FIX: raise Discourse::NotFound unless the user is present 2018-11-21 10:57:42 +05:30
10cc698df3 FIX: respond with proper error message if user not found 2018-11-21 10:47:37 +05:30
539f1c6252 FIX: raise Discourse::NotFound unless the topic is present 2018-11-21 09:48:38 +05:30
439b3fe10a Fix MigratePollsData failing when poll-votes have duplicated options. 2018-11-21 10:52:21 +08:00
f4020d9134 UX: Contain site setting uploads within the div. 2018-11-21 10:09:53 +08:00
Sam
966d3c8437 remove unneeded code
```
irb(main):001:0> def test; if false; puts "hi"; end; end
=> :test
irb(main):002:0> test
=> nil

```
2018-11-21 12:57:34 +11:00
598ac69773 Stop Sidekiq first before reloading unicorn master. 2018-11-21 09:53:00 +08:00
Sam
0a86ef69bb FIX: browser infinite recursion when editing post
This was a result of:

c4ed353fae

jQuery map on a jQuery object, returns a jQuery object http://api.jquery.com/map/

So you need to convert it to an array prior to mapping
2018-11-21 12:51:14 +11:00
Sam
20268385a5 FIX: never attempt to log invalid post numbers
Previously in some cases we would queue logging of invalid post numbers

The impact would be we would miss logging an incoming link and would leak
an error.
2018-11-21 11:58:47 +11:00
Sam
86255faa08 FEATURE: do not switch to JPEG unless you meet 75k byte savings
This also adjusts the algorithm to expect

- 30% saving for JPEG conversion

AND

- Minimum of 75K bytes saved

The reasoning for increase of saving requirements is cause PNG may have been
uploaded unoptimized, 30% saving on PNG is very possible
2018-11-21 11:01:08 +11:00
1def6c08ec Fix copy due to 050dd57494. 2018-11-21 08:00:15 +08:00
df72674f24 Warn when migrate url site settings job encounters an error. 2018-11-21 07:55:50 +08:00
15e793fd3b FEATURE: Terms of Service v1.0.0
Co-authored-by: Gerhard Schlager <mail@gerhard-schlager.at>
2018-11-21 00:45:16 +01:00
52a5a5983a Update narrative bot copy 2018-11-21 00:04:54 +01:00
050dd57494 update wizard intro copy step 2018-11-20 13:43:18 -08:00
17bc21abff trashing an empty wrapper 2018-11-20 15:42:18 -05:00
17f3080d01 UX: More consistent category setting layout 2018-11-20 15:16:17 -05:00
5951e111ad FIX: handle nil topic value when removing allowed users 2018-11-20 22:55:39 +05:30
92100f82eb FIX: properly disable serializable attributes when poll plugin is disabled 2018-11-20 17:28:41 +01:00
22a7f1e7f2 FIX: handle nil user value on password reset 2018-11-20 21:49:47 +05:30
592f8c1637 FIX: escape sso_secret string when migrating to sso_provider_secret (#6634) 2018-11-20 15:28:37 +01:00
9672c92045 DEV: removes _.each from codebase (#6629) 2018-11-20 14:46:58 +01:00
a2042c8e7d strip unused string from an deleted site setting 2018-11-20 14:28:42 +01:00
a0022a1771 FIX: Use count variable for pluralized string. 2018-11-20 14:17:31 +02:00
eacbe28f55 FIX: Skip gsub for normalizing whitespaces when text is nil (#6631) 2018-11-20 09:12:32 +01:00
bc41057949 minor copy edit 2018-11-20 12:07:56 +05:30
1a57be3248 Avoid deprecated site setting logging in SiteSetting.settings_hash. 2018-11-20 11:59:38 +08:00
81b3bdaabd FIX: Remove site settings override for deprecated url site settings. 2018-11-20 11:42:39 +08:00
e25b3965a7 do not overwrite hostname in development (#6623) 2018-11-20 14:34:02 +11:00
Sam
1b4f2029d7 FIX: clear theme cache when restoring
Previously old themes may be cached incorrectly, this also forces
a rebake of old themes to ensure version can compile cleanly
2018-11-20 13:37:58 +11:00
d1e50b3f8e Remove condensed suggested topics, hide secondary table head 2018-11-19 11:26:21 -05:00
95d8a421be fixes linting 2018-11-19 16:29:15 +01:00
4459665dee REFACTOR: use tables instead of custom fields for polls (#6359)
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
2018-11-19 14:50:00 +01:00
86dafc1f25 DEV: removes _.reduce from codebase (#6628) 2018-11-19 13:04:57 +01:00
0a8227d19c DEV: removes _.some from codebase (#6627) 2018-11-19 12:32:51 +01:00
e860c8b844 FIX: adds support for missing reports from old dashboard (#6624) 2018-11-19 12:20:05 +01:00
4c8cfe0f29 DEV: removes _.include from codebase (#6620) 2018-11-19 12:08:54 +01:00
b1727537b2 DEV: removes _.find from codebase 2018-11-19 11:46:26 +01:00
30e0d744db DEV: removes _.delay from codebase (#6619) 2018-11-19 10:47:00 +01:00
c4ed353fae DEV: removes _.map from codebase (#6616) 2018-11-19 10:46:46 +01:00
907cf3ee2f DEV: replaces setTimeout by Ember.run.later (#6618) 2018-11-19 10:46:38 +01:00
f2c227432c FIX: Do not show nested user cards. (#6621) 2018-11-19 10:01:22 +01:00
ba63cca747 DEV: add danger warning if PR contains changes to non-English locales (#6625) 2018-11-19 10:00:17 +01:00
cf21c7f5aa DEV: Fix typo in specs. 2018-11-19 15:13:54 +08:00