Commit Graph

38421 Commits

Author SHA1 Message Date
a78b256e8b FIX: Raw jQuery usage in tests 2020-07-20 15:13:49 -04:00
71b0400501 FIX: deleted is a computed property of Topic 2020-07-20 14:43:37 -04:00
e625aeeb0d FIX: Report was overwriting a CP 2020-07-20 14:42:16 -04:00
a0c6f1b2b4 FIX: category-drop tests were broken and overwriting CPs 2020-07-20 14:39:42 -04:00
ac9fa4a056 FIX: Overwritten computed properties 2020-07-20 14:14:52 -04:00
537cfb7ef6 FIX: Missing favicon in test 2020-07-20 13:25:26 -04:00
6623794dab Build(deps-dev): Bump test-prof from 0.11.3 to 0.12.0
Bumps [test-prof](https://github.com/palkan/test-prof) from 0.11.3 to 0.12.0.
- [Release notes](https://github.com/palkan/test-prof/releases)
- [Changelog](https://github.com/palkan/test-prof/blob/master/CHANGELOG.md)
- [Commits](https://github.com/palkan/test-prof/compare/v0.11.3...v0.12.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-20 12:12:55 -04:00
874c8ffd0f Build(deps): Bump rubocop-ast from 0.1.0 to 0.2.0
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 0.1.0 to 0.2.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.1.0...v0.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-20 12:01:40 -04:00
0f6405745a DEV: re-enable test skipped in 7dce4bfd
Leak in lib:sharing tests was the likely cause of failure.
2020-07-20 09:55:30 -04:00
0b800d307f SECURITY: Bound the amount of work that embed#topics can do
This commit adds a hidden site setting that limits the maximum number of
topics that can be fetched at once via the embed controller.
2020-07-20 13:25:34 +01:00
8f2f9e6afa DEV: Remove the <details> polyfill (#10260)
Per the linked site (http://mths.be/details) and https://caniuse.com/#feat=details the <details> element is supported since Chrome 12/Safari 6/Firefox 49/Edge 79. IE 11 doesn't handle them, but we dropped the support for that browser.
2020-07-20 13:18:00 +02:00
5f3dfce4eb FIX: Listing topics with muted mixed-case tags (#10268)
When visiting a tag page directly, we should display all topics, even if that tag is muted. This was not working for mixed-case tags.
2020-07-20 11:01:29 +01:00
9313706649 DEV: Enable preserve_email_structure_when_styling by default
In 1bd8a075, a hidden site setting was added that causes Email::Styles
to treat its input as a complete document in all cases.

This commit enables that setting by default.

Some tests were removed that were broken by this change. They tested the
behaviour of applying email styles to empty strings. They weren't useful
because:

 * Sending empty email is not something we ever intend to do,
 * They were testing incidental behaviour - there are lots of
   valid ways to process the empty string,
 * Their intent wasn't clear from their descriptions,
2020-07-20 10:21:32 +01:00
383537a2fa DEV: Force ActiveRecord reading role on Redis failover take 2. 2020-07-20 16:11:20 +08:00
5adf2ccaca DEV: Force ActiveRecord reading role on Redis failover. 2020-07-20 15:10:53 +08:00
7f05720e91 Bump logster.
Pulls in "FIX: Missing application backtrace in chained loggers."
2020-07-20 13:30:11 +08:00
2e9474e60f Update rails_failover to 0.5.3.
Changelong

- FIX: Incorrectly rescuing from `PG::ServerError`.
2020-07-20 11:05:11 +08:00
7dce4bfd88 DEV: Skip failing qunit test. 2020-07-20 10:15:27 +08:00
edc6c09500 FIX: correct stream counter when load more posts (#10264)
Small bug in that fix in which we started loading posts in partial:
https://github.com/discourse/discourse/pull/10240

We should add only displayed partial to stream counter to have a correct total number.
2020-07-20 09:52:06 +10:00
de79f19947 Revert "UX: Style video elements, show descriptions (#10040)" (#10258)
This reverts commit 7d289a4f3e9531a0c7e458a52af85d0ae5affab9.

Now that 36bad0c31f6fb1afce2d311b72f5f9661be6af97 is in and we have video previews on all platforms, the commit that's being reverted is no longer needed. In the worst case scenario, the video description is clipped under the video poster if the video aspect ratio is other than 16:9. This commit removes descriptions and the custom style for the video elements.

# Conflicts:
#	app/assets/javascripts/pretty-text/addon/engines/discourse-markdown-it.js
#	test/javascripts/lib/pretty-text-test.js
2020-07-17 23:31:01 +02:00
72c44b3b19 FIX: Fewer broken image paths in tests 2020-07-17 15:43:17 -04:00
683a1210e3 FIX: Don't use prototype extensions like .observes 2020-07-17 15:23:26 -04:00
394b5db848 FIX: Tests involving dates were logging warnings 2020-07-17 15:20:45 -04:00
8fd1ba2b0a FIX: passwordRequired is a computed property 2020-07-17 15:07:49 -04:00
1c33f07e92 FIX: Poll tests were overwriting a couple of computed properties 2020-07-17 15:05:36 -04:00
2a4a2a2ab7 FIX: More 404 image requests in test
A few tests were removed that were testing a subforum for the logo,
which I don't think gain us much anymore. We use `getURL` everywhere and
needn't test it so much. Plus, over time it's always good to remove
a few tests here and there :)
2020-07-17 14:58:32 -04:00
bf22f7080d FEATURE: optional quote sharing buttons (#10254) 2020-07-17 14:44:31 -04:00
6e94f28cf0 FIX: Error in test mode with missing topic 2020-07-17 14:37:08 -04:00
f68ea29236 FIX: Don't load images that don't exist in test
This makes 404 requests and fills up the logs with junk
2020-07-17 14:33:38 -04:00
0ecca3a2d2 FIX: tooltip is no longer used
It has been deprecated and now it's time to remove it.
2020-07-17 14:08:45 -04:00
edff796e87 FIX: Discourse.Site is deprecated 2020-07-17 14:03:59 -04:00
8e3f667d7c FIX: Show background images for both slug formats
It seems there was a discrepancy in that background images were attached
to the full slug category class: `category-:slug-:id` and our body class
only had `category-:slug`.

This fix adds support for both formats.
2020-07-17 13:42:30 -04:00
db9162610a FIX: missing title when inserting hyperlinks 2020-07-17 10:41:58 -04:00
85d1677b26 DEV: Drop unsupported-browser plugin (#10261)
Discourse 2.6 will not have support for older browsers (e.g. IE11)
2020-07-17 15:04:06 +01:00
fab8b8649e PERF: Combine avatar_lookup and primary_group_lookup into user_lookup (#10253)
These two classes were running very similar queries, which could be expensive on large topics
2020-07-17 10:48:08 +01:00
716ccf7fe4 FIX: Bookmark search fixes (#10239)
* Remove unneeded bookmark name index.
* Change bookmark search query to use post_search_data. This allows searching on topic title and post content
* Tweak the style/layout of the bookmark list so the search looks better and the whole page fits better on mobile.
2020-07-17 15:55:07 +10:00
ff7678e210 FIX: Reindex posts when Topic#title or Category#name changes. 2020-07-17 11:12:31 +08:00
39fef99c37 FIX: add topic title back to choose-topic 2020-07-16 20:19:33 -04:00
15c4f6e4cf FIX: update meh-o icon to far-meh (#10256) 2020-07-16 16:26:17 -07:00
cf16173eca Remove extra blank line 2020-07-16 14:57:29 -06:00
cc8540701e FIX: Be sure to use same units when comparing thumbnail size 2020-07-16 14:30:29 -06:00
e1bc709dc3 FIX: Fewer 404s in JS tests 2020-07-16 16:23:54 -04:00
4656812e00 FIX: More errors being logged in tests 2020-07-16 16:19:20 -04:00
b7fe5f04ba FIX: Deprecation usernames is now recipients 2020-07-16 16:11:52 -04:00
b5735f98e9 FIX: Remove more computed properties being set
Note: This also removes a test. The test had not properly stubbed its
request and was erroring in dev mode, and the test was relying on the
erronous result.
2020-07-16 16:06:27 -04:00
6ba1c64130 FIX: deprecation - usernames is now recipients 2020-07-16 15:42:51 -04:00
f13ec11c64 FEATURE: Add scopes to API keys (#9844)
* Added scopes UI

* Create scopes when creating a new API key

* Show scopes on the API key show route

* Apply scopes on API requests

* Extend scopes from plugins

* Add missing scopes. A mapping can be associated with multiple controller actions

* Only send scopes if the use global key option is disabled. Use the discourse plugin registry to add new scopes

* Add not null validations and index for api_key_id

* Annotate model

* DEV: Move default mappings to ApiKeyScope

* Remove unused attribute and improve UI for existing keys

* Support multiple parameters separated by a comma
2020-07-16 15:51:24 -03:00
766cb24989 FIX: Overwriting more computed properties 2020-07-16 13:22:13 -04:00
01cd371be5 FIX: Remove computed property setting from hamburger test 2020-07-16 12:17:15 -04:00
d99355deca FIX: Don't use jQuery directly in a test 2020-07-16 12:00:29 -04:00