ab374fff72
DEV: Move imap_helper to spec/support directory ( #14776 )
2021-10-29 20:46:25 +02:00
d760c86031
DEV: Load rails_helper in pbkdf2_spec ( #14775 )
...
Fixes failing tests in CI, where this spec file was first in a batch.
2021-10-29 20:15:10 +02:00
f6a3c22a89
DEV: Allow replacing share icons separately ( #14774 )
2021-10-29 13:35:27 -04:00
e3e0d025ea
FIX: Include topic details when PMing
...
We used to do this and at some point regressed when we lost a reference
to the `post` object. This restores the old behaviour.
2021-10-29 12:42:27 -04:00
cfc62dbace
FIX: allowed_theme_ids should not be persisted in GlobalSettings ( #14756 )
...
* FIX: allowed_theme_ids should not be persisted in GlobalSettings
It was observed that the memoized value of `GlobalSetting.allowed_theme_ids` would be persisted across requests, which could lead to unpredictable/undesired behaviours in a multisite environment.
This change moves that logic out of GlobalSettings so that the returned theme IDs are correct for the current site.
Uses get_set_cache, which ultimately uses DistributedCache, which will take care of multisite issues for us.
2021-10-29 11:46:52 -04:00
724f1ee9d1
UX: Fix short post width on mobile ( #14771 )
2021-10-29 11:39:19 -04:00
488511479e
UX: Show quick search hint more consistently ( #14769 )
2021-10-29 11:08:31 -04:00
1c3c0f04d9
FEATURE: Pull hotlinked images in user bios ( #14726 )
2021-10-29 17:58:05 +03:00
19ef6995a8
FIX: Do not replace words in hashtags and mentions ( #14760 )
...
Watched words were replaced inside mentions and hashtags when watched
word regular expressions were enabled.
2021-10-29 17:53:09 +03:00
cb0958fcea
FIX: Hide links to muted topics and in categories list ( #14761 )
...
* FIX: Hide links to muted topics
* FIX: Hide muted topics in categories list on mobile
2021-10-29 17:52:23 +03:00
095421a1e1
REFACTOR: Use IntersectionObserver to calculate topic progress position ( #14698 )
2021-10-29 09:23:15 -04:00
19c9b892dc
DEV: Instantiate relation early to save a query ( #14766 )
...
Previously it would do `SELECT 1 AS one` and then `SELECT "color_scheme_colors".*`. Now it only does the latter.
2021-10-29 03:03:22 +02:00
b1603c8667
FIX: Regression introduced in #14715 ( #14765 )
2021-10-29 03:03:11 +02:00
85d0ddb9eb
FIX: Avoid another N+1 query in Site.json_for ( #14763 )
...
A follow-up to #14729 , this time for logged-in users and/or non-login-required sites.
2021-10-28 20:28:31 +02:00
deee715a2c
FIX: update flair group of all members if primary group setting changed. ( #14762 )
...
Previously, if we enable the `primary_group` setting on a group then the `flair_group_id` of its' members are not affected.
2021-10-28 22:56:44 +05:30
c62242c6b3
FIX: should not receive topic invites from ignored users. ( #14746 )
...
Previously, ignored users can send notifications by inviting the ignorer to topics or PMs.
2021-10-28 21:03:00 +05:30
00b99c6613
DEV: Use Rails query builder ( #14759 )
2021-10-28 15:14:23 +03:00
148ee1d162
FIX: Do not perform link lookup for replaced links ( #14742 )
...
A link that was added because a watched word was replaced could create
a notice if the same link was present before.
2021-10-28 13:27:31 +03:00
efc23b6a8d
Update translations ( #14757 )
2021-10-28 11:24:55 +02:00
9e19b22f64
DEV: prevents Firefox ESR tests to crash on ||= ( #14758 )
...
A follow up PR should investigate why `proposal-logical-assignment-operators` is not getting used here (test file?) but this should be enough to get things running.
2021-10-28 10:55:22 +02:00
ba3078e098
PERF: Use different column for better query plan ( #14748 )
...
Using topics.id provides a better query plan than posts.topic_id which
speeds up search by almost 50%.
2021-10-28 11:30:30 +03:00
a2851b5d4c
FIX: include new tags in validation if user can create one. ( #14744 )
...
Previously, users who have enough trust level are unable to create topics with new tags if the selected category required a minimum number of tags.
2021-10-28 11:59:46 +05:30
b659e94a8e
DEV: Delete vacate_legacy_prefix_backups code ( #14735 )
...
Introduced in 3037617327147602d84e584c56a7d69dd001da0a, we no
longer need this code, as all of the backups have been
migrated.
2021-10-28 07:53:21 +10:00
92f4cdd330
FEATURE: bypass topic bump when disable_category_edit_notifications is enabled ( #14754 )
2021-10-27 17:05:10 -04:00
5a851dec0e
Build(deps): Bump rubocop from 1.22.2 to 1.22.3 ( #14753 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.22.2 to 1.22.3.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.22.2...v1.22.3 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-27 22:29:16 +02:00
ab64022d25
Build(deps): Bump excon from 0.87.0 to 0.88.0 ( #14751 )
...
Bumps [excon](https://github.com/excon/excon ) from 0.87.0 to 0.88.0.
- [Release notes](https://github.com/excon/excon/releases )
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v0.87.0...v0.88.0 )
---
updated-dependencies:
- dependency-name: excon
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-27 22:29:07 +02:00
fd187f2de3
PERF: There was a large performance regression in Logster
...
I'm not sure what other environments it shows up in, but I discovered it
on Apple Silicon. It might be useful in other environments, too.
2021-10-27 15:42:09 -04:00
9fa5077805
DEV: Remove unneeded qunit-helper override
...
This was leaking on every test... and also doesn't seem to be required. The `examineDockHeader` doesn't exist any more in core, so this was a no-op.
2021-10-27 18:34:04 +01:00
8bb911e038
DEV: Teardown appEvent listener in edit-notification-clicks-tracker
2021-10-27 18:34:04 +01:00
8af0674b68
DEV: teardown event listeners in click-interceptor
2021-10-27 18:34:04 +01:00
cc18a5439c
DEV: Ensure core initializers with .reopen are only called once
2021-10-27 18:34:04 +01:00
0bec323204
DEV: Teardown leaky page:changed appEvents between tests
2021-10-27 18:34:04 +01:00
d2ddb82022
UX: Remove animation in admin theme list ( #14743 )
2021-10-27 13:09:34 -04:00
df3eb93973
DEV: Sanitize HTML admin inputs ( #14681 )
...
* DEV: Sanitize HTML admin inputs
This PR adds on-save HTML sanitization for:
Client site settings
translation overrides
badges descriptions
user fields descriptions
I used Rails's SafeListSanitizer, which [accepts the following HTML tags and attributes](018cf54073/lib/rails/html/sanitizer.rb (L108)
2021-10-27 11:33:07 -03:00
184ccf4490
DEV: nullify cachedCookFunction to prevent retains ( #14737 )
2021-10-27 16:29:36 +02:00
79ad0860a2
FIX: Cleanup PresenceChannel instances when composer closed ( #14741 )
...
I was previously relying on `this.isDestroying` returning `true` during `willDestroyElement`. This was an incorrect assumption.
This commit refactors the logic into an explicit `cleanup` function, and also adds some cleanup for empty keys in the `subscribedProxy` array
2021-10-27 15:17:10 +01:00
103de1f20d
UX: Change login tabindex, follow-up to 6aa6275 ( #14734 )
2021-10-27 09:15:49 -04:00
4272eb7ffc
FIX: prevents a circular json error in tests ( #14738 )
...
The flow goes from:
- getting current user object
- creating a POJO using some of the current user keys
- passing this POJO around, which end up being used in message bus
- the processing fn associated ens up doing User.create on this object will both create a User object, but also inject store in it, store is holding a reference to currentUser Object and...
BOOM, we have an object holding a reference to the same object, which JSON.stringify used in prepareBody of pretender doesn't like.
2021-10-27 14:01:41 +01:00
0f71a43434
Update translations ( #14714 )
2021-10-27 14:24:43 +02:00
48a08cc397
FIX: Vanilla importer fixes ( #14699 )
...
Import script was out of date
2021-10-27 14:22:37 +02:00
7f79727090
DEV: rename refresh action to avoid regressions in the future ( #14721 )
2021-10-27 14:53:04 +04:00
19d95c64af
DEV: simplify username suggester ( #14531 )
...
This PR doesn't change any behavior, but just removes code that wasn't in use. This is a pretty dangerous place to change, since it gets called during user's registration. At the same time the refactoring is very straightforward, it's clear that this code wasn't doing any work (it still needs to be double-checked during review though). Also, the test coverage of UserNameSuggester is good.
2021-10-27 14:41:24 +04:00
69f0f48dc0
DEV: Fix rubocop issues ( #14715 )
2021-10-27 11:39:28 +03:00
6aa6275f3f
UX: change tabindex on login to skip email login link ( #14732 )
2021-10-26 20:46:53 -04:00
50f4f43825
DEV: Use double quotes for js-flags ( #14693 )
...
Single quotes seem to be raising parse errors in some CI situations. Switching to double quotes seems to fix the problem.
2021-10-27 11:09:30 +11:00
c7768b6d16
FIX: Avoid N+1 query in Site.json_for ( #14729 )
2021-10-26 22:46:53 +02:00
31aa071e54
UX: Apply tags during PM creation ( #14731 )
2021-10-26 16:46:02 -04:00
e073451eae
UX: Make PresenceChannel changes more responsive ( #14733 )
...
For very fast-paced things (e.g. replying... indicators), 5s resolution is not great. This commit improves the resolution to 1 update per second.
2021-10-26 21:15:20 +01:00
d067ee1c5a
UX: Never show back button if less than current position
2021-10-26 15:45:55 -04:00
46d96c9feb
DEV: Apply rubocop to script/import_scripts/phorum.rb ( #14727 )
...
Followup to b24002018a10e12b7bdee3a8f5218345716af6ff
2021-10-26 19:16:52 +01:00
