aea2d8bbeb
FIX: properly secure poll message bus
...
Co-authored-by: Sam <sam.saffron@gmail.com >
2018-12-05 21:27:49 +01:00
8aff99761a
FIX: Ignore query parameters when displaying counter on internal links
...
This matches the server-side behaviour, so that the links display counters correctly
2018-12-05 18:29:54 +00:00
a1d9aeda8b
REFACTOR: split TopicLink#extract_from into multiple methods
...
Also rename some confusing variables
2018-12-05 18:54:30 +01:00
37249c9a32
FIX: Do not reset link counts when post is rebaked
...
This was an indentation mistake introduced in 44eba0b. Pretty understandable, considering we are indented 8 levels deep in this method. Will follow-up with a refactor to improve this.
2018-12-05 18:54:30 +01:00
978f0db109
SECURITY: Require groups to be given when inviting to a restricted category. ( #6715 )
2018-12-05 16:43:07 +01:00
57ba4b7cb2
DEV: remove unnecessary safe nav operators ( #6730 )
2018-12-05 20:07:18 +05:30
97e6e3b133
DEV: duplicate and unreachable code after return
2018-12-05 09:17:20 -05:00
1d8266a623
very minor copyedit
2018-12-05 03:18:11 -08:00
fb78414229
Add missing safe navigation operator
2018-12-05 16:23:43 +05:30
d33d031742
FEATURE: Filter topic and post web hook events by tags ( #6726 )
...
* FEATURE: Filter topic and post web hook events by tags
* Add a spec test with unmatched tags
2018-12-05 14:44:06 +05:30
1a71f98d28
DEV: only publish logs error count to admins
2018-12-05 17:03:37 +11:00
82e45f5485
FIX: method extraction caused push notifications to include incorrect post
...
Previously the push notification code path was not tested for notification
collapsing. This happens if you get multiple replies to a topic you are
watching.
2018-12-05 16:40:10 +11:00
ec26a59eac
FIX: variable name typo in subcategory image
2018-12-05 10:41:06 +05:30
99117d664c
FEATURE: Multisite support for S3 backup store ( #6700 )
2018-12-05 10:10:39 +08:00
ba762ea87f
minor copyedit
2018-12-04 16:36:47 -08:00
e0aac75607
Restrict width of category heading to prevent mobile overflow
2018-12-04 19:01:27 -05:00
f1050350ed
FIX: clamp integers to prevent 'PG::NumericValueOutOfRange' errors
2018-12-04 22:51:56 +01:00
28ddaf80d2
Adding max-width to category logos
2018-12-04 13:01:27 -05:00
e117deb2ba
FIX: Improve avatar loading, and add tests
...
Follow-up from 4e2cc9c
2018-12-04 15:09:32 +00:00
22001b3c50
DEV: Run tests with default value for max_consecutive_replies ( #6723 )
2018-12-04 12:07:27 +00:00
3c9c95ac83
Update Rubocop to 0.60
2018-12-04 10:48:16 +01:00
72bd388ff7
UX: truncate long topic tiles to prevent badges and date from wrapping
2018-12-04 15:27:23 +08:00
aa97f6fdba
FEATURE: disable notifications for small actions that are whispers
...
Previously we would notify on small actions if they were whispers
this inconsistently lead to all sorts of problems including
- collapsed "N replies" after assign
- empty push notifications
New behavior adds an api to explicitly send push notifications as well
if needed: create_notification_alert
2018-12-04 17:54:42 +11:00
cfa0321aaa
FIX: Increase timeout when trying to reload unicorn.
...
Also fail better when reloading takes too long by sending
unicorn a TERM.
2018-12-04 13:43:14 +08:00
5c17e46274
FEATURE: allow advanced specification of excerpts for posts
...
Previously users could control excerpt with `<span class='excerpt'>`
in Markdown, this is somewhat limited for plugins that need to define this
across a section. This adds support for DIV as well
2018-12-04 15:13:34 +11:00
9248ad1905
DEV: Enable Style/SingleLineMethods and Style/Semicolon in Rubocop ( #6717 )
2018-12-04 11:48:13 +08:00
56948896ff
UX: replace FA5 compress/expand icons
...
Adds a new SVG sprite file that contains non-FontAwesome 5 icons to our subset.
Adds the FontAwesome 4.7.0 icons for expand / collapse.
2018-12-03 22:29:20 -05:00
4831c4c2ee
FIX: Use safe navigation operator throughout statement
2018-12-03 20:00:28 +00:00
e32cdb00cb
Fix the build
2018-12-03 18:51:07 +00:00
b373ff47e2
FIX: Topic is nil when first post is being created
2018-12-03 18:30:52 +00:00
4e2cc9caf0
FIX: Use safe navigation operator when looking for avatar URL
2018-12-03 17:28:21 +00:00
404acef6e3
DEV: Move run-qunit.js out of the vendor directory
2018-12-03 16:16:37 +00:00
923692d45a
FIX: tooltip regression in admin dashboard
...
- adds registerHoverTooltip in tooltip qunit test
2018-12-03 11:15:31 -05:00
1a4676c6e0
FIX: Fixed tests. ( #6716 )
2018-12-03 17:03:11 +01:00
f8e6a37858
FIX: raise exception when getting dimensions of missing image
...
- follow-up on 0eacd45ab15cbd20ed9f444fd447886a7fc6dccb
2018-12-03 10:19:49 -05:00
9125b5fbc4
DEV: Reformat single line method definition
...
Following comments on 71aaed272c
2018-12-03 15:03:00 +00:00
3f8fa4ad4e
FEATURE: Do not check consecutive replies for original poster. ( #6714 )
2018-12-03 02:32:29 -08:00
142361d6da
FIX: don't steal focus when text in editor is replaced ( #6712 )
2018-12-03 09:49:17 +01:00
503ae1829f
FIX: All multisite upload paths should start with /uploads/default/.. ( #6707 )
2018-12-03 12:04:14 +08:00
6121d11187
FIX: make staff_edit_locks_post work with download_remote_images_to_local
2018-12-03 14:14:59 +11:00
125bb46052
Remove unused constant in the codebase.
2018-12-03 11:04:47 +08:00
12f5889c85
DEV: stop logging warning when overriding open scope
...
ActiveRecord defines automatic scopes for enums, the Poll model defines
an enum for `{open: 1}` this mean Rails wants the scope `Poll.all.open`
to work which in turn means it has to override `open` which is defined
privately.
Rails feature req exists for: https://github.com/rails/rails/issues/34599
which will allow us to define enums without scopes which would resolve this
a lot more cleaner.
2018-12-03 13:52:09 +11:00
f555582eb2
DEV: add extra diagnostics for intermittent test fail
2018-12-03 11:46:31 +11:00
f94c3aef7b
DEV: upgrades highlight.js from v9.12.0 to v9.13.1
2018-12-03 09:45:52 +11:00
1073634271
FIX: show generic title when quoting off-topic secure category posts
2018-12-03 09:42:32 +11:00
cc04c86859
UX: do not restrict width of category image, only height
...
This was a recent visual regression which caused a fair amount of pain.
Previously we only restricted height
2018-12-03 09:35:16 +11:00
236c755d62
FIX: do not store key tracking last seen time indefinitely
...
UserStat has some special logic to keep adding time read if repeat calls
are made in intervals less than 100 seconds. This is called regularly
when we update read timings on a topic.
We only need to cache this key in redis for 100 seconds, however previously
we would keep it forever, 1 key per user. This has potential of bloating
a very large amount of keys for no longer active users in redis.
2018-12-03 08:35:26 +11:00
26e9b628b8
post-infos alignment fix
2018-11-30 21:31:36 -05:00
7efc1b7bf7
Removing added text from commit a113777
2018-11-30 19:56:10 -05:00
a113777003
Extra margin isn't needed on mobile
2018-11-30 19:49:26 -05:00
