Commit Graph

30097 Commits

Author SHA1 Message Date
c219a5fb1e Add btn-default class to all default buttons (#6521) 2018-10-24 16:09:36 -04:00
0140844eb0 Remove whitespace in template so we can use :empty psuedo 2018-10-24 16:00:22 -04:00
addf6f6d17 FIX: support comma in 'sso_provider_secrets' site setting 2018-10-24 21:23:18 +02:00
05438d99a8 FIX: Ensure the like button always has a title, for accessibility (#6525)
The like button previously didn't have a title for anonymous users,
because the `canToggleLike` flag wasn't set, but the `liked` flag wasn't
set either. This made the button inaccessible to blind users.
2018-10-24 13:58:42 +00:00
Sam
e955a7b49d Revert "Revert "FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523)""
This reverts commit 322b27b6dcba0ec37323b3fef64fec6075c68fe6.

Oops rushed on the revert here... should be good
2018-10-24 15:14:01 +11:00
Sam
322b27b6dc Revert "FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523)"
This reverts commit 63356d883ebf6d37b8f9c6a813a240920b6e304c.

This caused an outage, got to revert
2018-10-24 15:03:58 +11:00
63356d883e FIX: GlobalPath#upload_cdn_path when S3 bucket has a folder (#6523) 2018-10-24 14:34:10 +11:00
Sam
5fd94d3211 PERF: limit unread count to 99 in blue circle
This revises: e605542c4e

Previous commit was faulty
2018-10-24 12:10:27 +11:00
Sam
e605542c4e PERF: limit unread count to 99 in the blue circle
This safeguard is in place to avoid very expensive queries on the server
side
2018-10-24 11:53:28 +11:00
Sam
29fdb50338 FIX: if poll has not options do not break serializer
Note: we have a proper rewrite of this plugin in progress
it will address this issue in a proper way
2018-10-24 10:04:17 +11:00
64aca0dc1b FIX: remove duplicate referrer policy
Rails already ships with strict-origin-when-cross-origin, no need
to also add no-referrer-when-downgrade

see: https://meta.discourse.org/t/harden-referrer-policy-header/100172
2018-10-24 08:38:39 +11:00
0b4edfc7d6 UX: improve spacing on composer controls 2018-10-23 16:37:36 -04:00
a82dfbd2dc Mobile timeline fix 2018-10-23 07:59:00 -04:00
541b6a8446 UX: Allow vertical timeline to fit on narrower screens 2018-10-22 22:16:59 -04:00
Sam
de6b585368 minor, bypass gravatar update if user does not match
this protects against a race condition that can happen when a user record
is destroyed reasonably quickly
2018-10-23 12:20:41 +11:00
cee51672c9 FIX: Strip accents from search query
4481836 introduced accent stipping in search_indexer,
but we need to strip it from the query itself as well

TODO in search with diacritics:
 - Still need to fix excerpts on search page
 - need to support accent stripping in in_topic search
 - need to make sure that in:title works correctly
 - need to fix "word boldening" in titles
2018-10-23 12:10:33 +11:00
7d2e582b28 FIX: validates import theme form (#6513) 2018-10-23 12:09:06 +11:00
Sam
b74dd7d379 FIX: stop logging every 404 error when searching for gravatars 2018-10-23 11:43:14 +11:00
Sam
adab7a3a48 improve test, also ensure no zero size is generated 2018-10-23 08:50:07 +11:00
Sam
bea8d337b2 DEV: ensure resizing test does not raise bad error
Current resizing test was showing binary diff in terminal and failing
in latest image magick 7, this fixes both issues
2018-10-23 08:45:06 +11:00
bafe3cd99a Revert "DEV: Lint official plugins in CI (#6519)"
This reverts commit 093cab2db04675dc9f9ccc52a3ceee5f85156f45.
2018-10-22 22:30:33 +01:00
093cab2db0 DEV: Lint official plugins in CI (#6519) 2018-10-22 21:28:38 +01:00
2cc195f3d9 prettier linting fix 2018-10-22 14:18:26 -04:00
37fa7775f1 FIX: Fix order of recently connected devices. (#6517) 2018-10-22 17:30:23 +00:00
e9a971a2b6 FEATURE: [Experimental] Content Security Policy (#6514)
do not register new MIME type, parse raw body instead
2018-10-22 13:22:23 -04:00
ec2613699f Change box category view to use flexbox 2018-10-22 10:15:31 -07:00
b9261588f9 make the code prettier 2018-10-22 19:07:41 +02:00
3e232412e3 UX: show error when hitting the rate limit on password reset 2018-10-22 19:00:30 +02:00
db26fe1527 FIX: Proper naming for the GNU/Linux OS 2018-10-22 13:34:01 -03:00
99b43f281b FIX: Fix browser detection for Microsoft Edge. (#6516)
cool!
2018-10-22 23:15:41 +11:00
3377f26eba FIX: Clean tag before searching for matches 2018-10-22 11:09:06 +01:00
37b7afa522 FIX: Sanitize tags before creation 2018-10-22 10:53:42 +01:00
597d4863d6 fix the build 2018-10-22 15:09:25 +05:30
c39a1022cc PERF: user imports would slow down the more users were imported 2018-10-22 11:14:13 +02:00
afa22a0c6f REFACTOR: more 'fake_email' to base importer 2018-10-22 11:12:40 +02:00
ce0a51665e FIX: count emoji shortcuts in topic title
https://meta.discourse.org/t/max-emojis-in-title-set-to-0-conflicting-with-emoji-shortcuts/98368/3?u=techapj
2018-10-22 13:44:05 +05:30
dca830cb73 Revert "FEATURE: [Experimental] Content Security Policy (#6504)"
This reverts commit fb8231077a07fe9b3bcdce150c6615b1897166c7.
2018-10-19 11:53:29 -04:00
b35c8fb336 Add offset to topic footer admin menu, to avoid header overlap 2018-10-19 11:30:11 -04:00
0dd717e641 Revert "FIX: Sanitize tags before creation"
This reverts commit 18ae8de9e5f8d04f32bf2f0781bfaf6ab833e2c9.
2018-10-19 15:49:05 +01:00
18ae8de9e5 FIX: Sanitize tags before creation 2018-10-19 15:43:31 +01:00
fb8231077a FEATURE: [Experimental] Content Security Policy (#6504) 2018-10-19 10:39:22 -04:00
3d5085c045 Prevent warning when bundling for imports 2018-10-19 16:03:22 +02:00
8b20e2500a Remove unnecessary line 2018-10-19 15:48:48 +02:00
b69652278f FEATURE: Add Wiki Editor badge. (#6511) 2018-10-19 15:30:27 +02:00
637123ff6f Merge users based on their email in vBulletin importer 2018-10-19 15:16:45 +02:00
7166d7de9a FIX: Prevent duplicate tags in tag-choosers (#6512)
* FIX: Prevent duplicate tags in tag-choosers

This reverts 5685b45, which fixes the duplicate tags problem.
The fix introduced by 5685b45 is re-implemented on the server.
2018-10-19 13:44:43 +01:00
5f86564da1 FEATURE: adds latest to user-api-key session scope 2018-10-19 09:54:06 +02:00
65faff5832 DEV: Improve specs to provide a better error message. 2018-10-19 14:31:17 +08:00
Sam
9bfc939692 cleanup so gravatar download failures are consistent
previously we would ignore socket error, but this would mean that
there could be conditions where we would keep trying to download
gravatars forever (in an hourly job)
2018-10-19 12:51:55 +11:00
85ef8e5a9f auto is not a valid value for min/max height (#6509) 2018-10-18 21:33:45 -04:00