Commit Graph

33478 Commits

Author SHA1 Message Date
c3a38d2304 DEV: Make groups/new extensible by plugins (#7642)
* Expose a new plugin outlet. Pass group model to the group-member-dropdown so it can be accessed by plugins

* Added controller tests for group custom fields. update custom fields when updating a group
2019-06-06 12:05:33 +10:00
7bd8f715bc DEV: Prefer this.site.notification_types. 2019-06-06 09:39:59 +08:00
d9d36f241d DEV: Use this.site.get("notification_types") instead.
Follow up to fcb7422213025f2c3ddb7d76175e7cf8bd1cb76b.
2019-06-06 08:18:25 +08:00
54db23e4ff UX: Make input caret color match text color 2019-06-05 14:27:27 -04:00
58ff7216ca UX: Display "Queued Topic" if a Queued Post will create a topic 2019-06-05 14:11:28 -04:00
f0e73cb126 SECURITY: Bump Handlebars to version 4.1.2
WS-2019-0064: Versions of handlebars prior to 4.0.14 are vulnerable to Prototype Pollution. Templates may alter an Objects prototype, thus allowing an attacker to execute arbitrary code on the server.
2019-06-05 13:54:52 -04:00
d902c4eb9f FEATURE: Can sort reviewable queue
Choices are Priority / Created At (and desc versions.)
2019-06-05 13:21:05 -04:00
de013262a7 DEV: refactors textarea-selection helper to prevent leaking (#7709) 2019-06-05 19:20:46 +02:00
35d0fd038e FIX: Add unit to width and height CSS properties. 2019-06-05 19:51:31 +03:00
c0e8950fdb UX: Shrink oneboxes and other wide content in custom post messages 2019-06-05 12:48:06 -04:00
ea5767e935 FIX: Broken serializer spec with no payload 2019-06-05 12:44:56 -04:00
f1d547c301 FEATURE: Show "in reply to" on the review queue
We now show if a queued or flagged post is a reply to another when in
the review queue. It's especially helpful for queued posts where
normally they are linked to the topic where they are created, and you
have no context about the reply.

Note that this will only apply to new queued posts going forward.
Previously queued posts will not show the "in reply to"
2019-06-05 12:34:41 -04:00
cdd2c8ef4a TYPO: Don't say code twice 2019-06-05 12:12:09 -04:00
be464f753c UX: Lighten OS icons in recently used devices 2019-06-05 10:56:25 -04:00
ad876880e1 FIX: Ember was raising an error without a .set here 2019-06-05 10:23:39 -04:00
0082a57718 REFACTOR: computed lib (#7702) 2019-06-05 15:50:22 +02:00
df95457468 DEV: d-editor helper should be synchronous (#7706)
Also ensures trigger has happened before assertion and prevents leaking formatTextWithSelection into global context
2019-06-05 14:52:38 +02:00
a77d8bee68 FIX: Use correct locale when translating without cache
follow-up to 6d8eb9c1
2019-06-05 14:19:56 +02:00
4d1204b5e8 SPEC: Add bucket folder path only if not exists
be0555cc17ce59918a1374c78af64d722f2c1836
2019-06-05 17:21:51 +05:30
f506843074 REFACTOR: user route (#7704) 2019-06-05 13:05:27 +02:00
1178f4865b REFACTOR: login-method model (#7703) 2019-06-05 12:35:41 +02:00
80459d83a4 REFACTOR: discourse-location lib (#7700) 2019-06-05 11:46:36 +02:00
32f878db69 COPY: remove unnecessary "title" in links to topics on meta
Follow-up to 969d6af88e66ab26009b614d911dd185004de025
2019-06-05 11:29:41 +02:00
faef660631 REFACTOR: invite model (#7699) 2019-06-05 11:24:06 +02:00
df6d46b235 FIX: regression and attempts to have clearer naming (#7701) 2019-06-05 11:23:30 +02:00
0fd7f74664 REFACTOR: post model (#7659) 2019-06-05 11:04:35 +02:00
69f75b2a81 REFACTOR: preferences/account controller (#7698) 2019-06-05 10:37:51 +02:00
19e3b3b1bc PERF: speed up topic poster lookups
During profiling looking up topic users popped up as a hot path, this
change more than halved the amount of work it does

It reduces object allocations and method calls and avoids repeate translation
of common terms
2019-06-05 18:28:36 +10:00
ce79a71c5d typo s/faivcon/favicon (#7697) 2019-06-05 09:46:07 +02:00
b9df7a2257 FIX: if favicon is missing due to bad url we would return a 500 on favicons
This ensures that the error logging does not corrupt the cache
2019-06-05 16:43:40 +10:00
62141b6316 FEATURE: enable_performance_http_headers for performance diagnostics
This adds support for DISCOURSE_ENABLE_PERFORMANCE_HTTP_HEADERS
when set to `true` this will turn on performance related headers

```text
X-Redis-Calls: 10     # number of redis calls
X-Redis-Time: 1.02    # redis time in seconds
X-Sql-Commands: 102   # number of SQL commands
X-Sql-Time: 1.02      # duration in SQL in seconds
X-Queue-Time: 1.01    # time the request sat in queue (depends on NGINX)
```

To get queue time NGINX must provide: HTTP_X_REQUEST_START

We do not recommend you enable this without thinking, it exposes information
about what your page is doing, usually you would only enable this if you
intend to strip off the headers further down the stream in a proxy
2019-06-05 16:08:11 +10:00
6d8eb9c144 PERF: bypass slow locale lookups in various cases
Previously as soon as any override was defined we would regress to the slow
path for locale lookups. Additionally if `raise: true` was specified which
rails likes to add in views we would bypass the cache

The new design manages to use the fast path for many more cases
2019-06-05 14:30:25 +10:00
78509eacb7 DEV: lint file
followup to 9779307e
2019-06-05 11:32:47 +10:00
b2b66d645b UX: Move archive button in topic controls dropdown (mobile view). (#7681) 2019-06-05 11:30:06 +10:00
3407445831 FIX: Prevent deadlock (#7691)
Before the locking here was added, replying to a post and liking a post
at roughly the same time could cause a deadlock.

Liking a post grabs an update lock on the post and then on the topic (to
update like counts).

We now lock the replied to post before getting the topic lock so that we
can update the replied to post later without causing a deadlock.
2019-06-05 11:29:27 +10:00
9779307efc DEV: simpler spec for wayback machine crawler layout (#7696)
follow-up on 42809f4d
2019-06-05 11:24:52 +10:00
1cf0b549ab FIX: don't send post edit notification when hidden tags are changed
Create a hidden revision so staff can see the changed, but don't send
notifications to non-staff.
2019-06-04 15:48:15 -04:00
dd1a034e7b Revert "FIX: don't send post edit notification when hidden tags are changed" 2019-06-04 15:48:15 -04:00
98a3e61a2d FIX: Remapping URLs didn't affect upload site settings 2019-06-04 18:37:10 +02:00
f03a547a89 REFACTOR: topic-entrance component (#7694) 2019-06-04 17:50:02 +02:00
6de3824b46 REFACTOR: group model (#7692) 2019-06-04 17:41:46 +02:00
68147cedd1 REFACTOR: username-validation mixin (#7693) 2019-06-04 17:41:33 +02:00
7b19e63ce7 REFACTOR: badge model (#7690) 2019-06-04 17:12:02 +02:00
1bca6fdf51 UX: Z-index fix for preview on iOS 2019-06-04 11:08:49 -04:00
e7fe7010b8 FIX: use hijack for processing bulk invites (#7679)
FIX: do not store bulk invite CSV file on server
2019-06-04 20:19:46 +05:30
ecc9c76692 FEATURE: dynamically update the topic heat settings monthly (#7670)
The site settings beginning with "topic views heat" and "topic post like
heat" are set to defaults when installing Discourse, but there has not
been a process or guidance for updating these values based on
community activity.

This feature will update them once a month. The low, medium, and
high settings will be based on the minimums of the 45th, 25th, and
10th percentile topics respectively, so that 45% of topics will have
some "heat".

Disable automatic changes with the automatic_topic_heat_values setting.
2019-06-04 10:34:07 -04:00
e66024bd3b Update theme component URL 2019-06-04 10:04:27 -04:00
4201329f1e REFACTOR: topic-from-params route (#7689) 2019-06-04 15:51:22 +02:00
f7a2648694 FEATURE: Migrate uploads to S3 during restore 2019-06-04 15:47:36 +02:00
fb121815a5 DEV: Allow rebaking oncooked posts of single site 2019-06-04 15:47:36 +02:00