cbd72d51b4
fix translations impacting other tests ( #9321 )
2020-03-31 09:26:35 +02:00
acc0a9673e
FIX: the correct action for group-member-dropdown is now actOnGroup ( #9320 )
2020-03-31 09:21:59 +02:00
4f6d722e45
DEV: adds a new dropdown widget usable in any widget ( #9297 )
2020-03-31 09:13:16 +02:00
9bbaaea1e8
UX: better customize emoji layout on mobile ( #9319 )
2020-03-31 08:55:47 +02:00
a0f59a55cc
FIX: when a post is moved copy notifications level ( #9311 )
...
This is a revert of 2c011252f1https://meta.discourse.org/t/when-a-reply-is-moved-to-a-new-topic-the-followers-of-the-previous-topic-are-automatically-follower-of-the-new-topic-as-well/130025
2020-03-31 16:19:47 +11:00
6d3d9ecf6c
DEV: adjust rake autospec to work with renamed es6 files
...
We no longer use es6 files, update autospec
2020-03-31 14:40:58 +11:00
fcc5ef9625
FIX: when switching reply type update options
...
Previously we were not correctly updating reply types leading to inconsistent
behavior when using drop down in composer (for reply type)
2020-03-31 14:40:57 +11:00
d282233d31
UX: Add flair styles to latest topic list
2020-03-30 21:40:11 -04:00
a34711c23a
FIX: do not save draft while it is loading
...
When editing a post we were incorrectly saving a draft prior to user typing
This caused a bloat in the amount of drafts saved per user and inconsistency
around behavior of "escape" button.
It also lead to lots of warnings about draft conflicts when copying stuff
between posts.
The code is improved to use promises more appropriately, however further
changes are needed to clean up internals so methods consistently return
promises.
Too many methods in the controller sometimes return a promise and sometimes
an object. Long term the methods will become async and all of this will be
corrected.
2020-03-31 11:49:10 +11:00
5f1c95329e
DOCS: Update DEVELOPER-ADVANCED.md ( #9313 )
...
Update correct python software-properties-common package post Ubuntu 12.04
2020-03-31 09:52:23 +11:00
8f4b54fedd
fix d-button tests ( #9316 )
2020-03-30 23:42:21 +02:00
5b6cdd6fb5
DEV: adds a loading property to d-button ( #9072 )
...
Usage:
```
{{d-button icon="times" label="foo.bar" isLoading=true}}
```
Note that a button loading without an icon will shrink text size to prevent button to jump in size.
A button while loading is disabled.
2020-03-30 23:17:00 +02:00
2a2555e598
DEV: Partial 'block-indentation' linting fixes
2020-03-30 14:13:33 -07:00
2afb95fe3e
DEV: Enable and fix the 'no-multiple-empty-lines' lint
2020-03-30 14:13:33 -07:00
f900efaa4a
DEV: composer.hbs: fix indentation
2020-03-30 14:13:33 -07:00
1703270055
DEV: Enable and fix no-trailing-spaces lint
2020-03-30 14:13:33 -07:00
29e733832d
FIX: error when changing a topic's category and creating a tag
2020-03-30 16:43:01 -04:00
339ddb8701
FIX: makes clicking and displaying date picker more reliable ( #9302 )
2020-03-30 22:02:24 +02:00
db35baba26
FEATURE: Display "Last Updated At" on user directory
2020-03-30 14:34:48 -04:00
0996c3b7b3
FEATURE: allows multiple custom emoji groups ( #9308 )
...
Note: DBHelper would fail with a sql syntax error on columns like "group".
Co-authored-by: Jarek Radosz <jradosz@gmail.com >
2020-03-30 20:16:10 +02:00
fa5ba6beb8
FIX: ensures mini-tag-chooser display min tags req if no selection ( #9303 )
2020-03-30 19:34:53 +02:00
a3345057f2
FIX: prevents rendering empty timeline-controls ( #9304 )
...
The streamlength/height code when true would return just after we had inserted the timeline-controls, resulting, on topic-progress event to display an empty timeline-controls when clicked.
I think this code in unecessary and we should only rely on the code in `hideProgress` which will currenly hide the progress is the stream has only one post displayed on desktop (always shown on mobile).
2020-03-30 19:17:08 +02:00
aeaea3c154
FIX: correctly take category/group filters into csv export ( #9300 )
2020-03-30 19:08:47 +02:00
f8cb46c0e1
FIX: prevents exception when clicking component title above ace editor ( #9309 )
2020-03-30 18:55:15 +02:00
acdbcabd0e
DEV: Allows moduleForWidget to use before/afterEach options ( #9296 )
2020-03-30 18:12:32 +02:00
96e841a635
DEV: trigger :username_changed when a user is renamed ( #9301 )
2020-03-30 18:02:34 +02:00
6c2717eda0
UX: ensures esc key is correctly working when in dates form ( #9299 )
...
1 esc close modal focus date button in toolbar
2 esc reduces composer
2020-03-30 17:59:25 +02:00
d0d5f0c912
DEV: Add Ember.PromiseProxyMixin to ember modules ( #9312 )
2020-03-30 11:37:14 -04:00
14b8e221e7
Build(deps): Bump cose from 0.11.0 to 1.0.0 ( #9307 )
...
Bumps [cose](https://github.com/cedarcode/cose-ruby ) from 0.11.0 to 1.0.0.
- [Release notes](https://github.com/cedarcode/cose-ruby/releases )
- [Changelog](https://github.com/cedarcode/cose-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/cedarcode/cose-ruby/compare/v0.11.0...v1.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-30 11:18:55 -04:00
0841ba1c6b
Build(deps): Bump unf_ext from 0.0.7.6 to 0.0.7.7 ( #9306 )
...
Bumps [unf_ext](https://github.com/knu/ruby-unf_ext ) from 0.0.7.6 to 0.0.7.7.
- [Release notes](https://github.com/knu/ruby-unf_ext/releases )
- [Changelog](https://github.com/knu/ruby-unf_ext/blob/master/CHANGELOG.md )
- [Commits](https://github.com/knu/ruby-unf_ext/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-30 11:18:31 -04:00
2b78bd01ab
FIX: allows adapters to define a custom primaryKey ( #9254 )
2020-03-30 15:23:59 +02:00
92e81d2ae5
UX: Fix composer position on iPads with a hardware keyboard
...
Adds padding to the composer when the keyboard accessory bar is shown (i.e. submit button no longer hides behind said bar)
2020-03-30 09:23:00 -04:00
435fe8ac6e
FIX: allow invite email field to be blank for invite tokens
2020-03-30 10:35:49 +05:30
8ab39f6916
Build(deps): Bump logster from 2.7.1 to 2.8.0 ( #9310 )
...
This includes Font Awesome upgrade to version 5.
Bumps [logster](https://github.com/discourse/logster ) from 2.7.1 to 2.8.0.
- [Release notes](https://github.com/discourse/logster/releases )
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.7.1...v2.8.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-30 07:52:04 +03:00
3914e9cb5c
FIX: get_size_from_image_sizes should return [width, height] or nil ( #9298 )
2020-03-28 20:20:51 +02:00
7a32a99595
FIX: Quoting a nested quote should preserve original post info.
2020-03-28 22:24:43 +05:30
a3d47f1aad
UX: Better spacing for icons in select-kit labels
...
Followup to c14e3adac5349b0500fe7d51bd96704d7a813929
2020-03-27 16:06:40 -04:00
104b647ca4
DEV: Fix another time-sensitive flaky spec
2020-03-27 20:39:25 +01:00
9026c55fe4
FIX: custom SQL with a trailing comment might break BadgeGranter SQL ( #9285 )
...
For example given a custom badge with SQL:
```
SELECT 1
-- I am a comment
```
You end up with
```
FROM (SELECT 1
-- I am a comment) q
```
This fix adds newlines so you end up with the now-valid:
```
FROM (
SELECT 1
-- I am a comment
) q
```
2020-03-27 14:16:14 -04:00
702879cbda
FIX: check for presence of name before normalizing
2020-03-27 23:01:48 +05:30
7ff889574d
DEV: Add rubocop-rspec ( #9288 )
...
This adds rubocop-rspec, and enables some cops that were either already passing or are passing now, after fixing them in this commit.
Some new cops are disabled for now, with annotation: "TODO" or "To be decided". Those either need to be discussed first, or require manual changes, or the number of found and fixed offenses is too large to bundle them up in a single PR.
Includes:
* DEV: Update rubocop's `TargetRubyVersion` to 2.6
* DEV: Enable RSpec/VoidExpect
* DEV: Enable RSpec/SharedContext
* DEV: Enable RSpec/EmptyExampleGroup (Removed an obsolete empty spec file)
* DEV: Enable RSpec/ItBehavesLike
* DEV: Remove RSpec/ScatteredLet (It's too strict, as it doesn't recognize fab! as a let-like)
* DEV: Remove RSpec/MultipleExpectations
2020-03-27 17:35:40 +01:00
b2b7afd310
Rename the server side widget hbs compiler
2020-03-27 12:06:14 -04:00
38e347aee6
DEV: allows to decorate topic list item ( #9294 )
...
Co-authored-by: David Taylor <david@taylorhq.com >
2020-03-27 16:50:31 +01:00
c721bdb300
DEV: Add build_plugin_html to wizard head ( #9293 )
2020-03-27 10:02:48 -05:00
eda8f319a2
FIX: keep date object ( #9292 )
2020-03-27 14:15:14 +01:00
1b09a0cd17
UX: improves date-time-input on mobile ( #9291 )
2020-03-27 13:29:58 +01:00
e6e6d20912
Revert "DEV: Enable and fix link-href-attributes lint"
...
Introducing an href attribute on the upload button caused the page to reload when clicked
This reverts commit a17fa222afff6e035d5b610487d6888896913d35.
2020-03-27 11:43:00 +00:00
57321b90f0
Completely remove read only mode during backups ( #9279 )
2020-03-27 07:38:55 -03:00
0cb40fe9ed
FIX: Narrative bot not working for bookmarks with reminders ( #9289 )
...
Reported https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542/42?u=mjrbrennan
* There was no callback on the bookmark model to trigger the next step of the narrative bot on bookmark.
* Also the translation URL path was hardcoded, needs to be conditional based on whether the site setting is enabled.
2020-03-27 12:17:18 +10:00
40b6e278a0
FIX: ensure wiki editor is assigned consistently
...
`DISTINCT ON` was not providing stability, this ensures the backfill will
be stable on a specific post avoiding risk around double grants.
2020-03-27 12:41:06 +11:00
