Commit Graph

37615 Commits

Author SHA1 Message Date
e8fb9d4066 FIX: when creating new PM username/groupname should be case-insensitive
(take 2)

https://meta.discourse.org/t/case-sensitivity-in-links-to-groupname/147596
https://meta.discourse.org/t/remove-case-sensitive-in-adding-users-to-a-message/151275
2020-05-25 21:34:05 +05:30
302b37c805 Revert "FIX: when creating new PM username/groupname should be case-insensitive"
This reverts commit 2be79d94f5226099d287aa9c69e5a2814baff420.

This is affecting multiple code path. Investigating.
2020-05-25 20:10:14 +05:30
30849c8b37 FIX: no need for downcasing second time 2020-05-25 19:20:15 +05:30
2be79d94f5 FIX: when creating new PM username/groupname should be case-insensitive
https://meta.discourse.org/t/case-sensitivity-in-links-to-groupname/147596
https://meta.discourse.org/t/remove-case-sensitive-in-adding-users-to-a-message/151275
2020-05-25 19:04:59 +05:30
631024ae5d FEATURE: Permalinks for tags 2020-05-25 14:51:01 +02:00
48fb354bce PERF: avoid traversing DOM in loadScript
Once a script is loaded operation should be very fast.

This optimisation avoids a DOM traverse and call to getURL on
every invocation.
2020-05-25 18:19:59 +10:00
505122bb45 FIX: skip onceoff job for groups with invalid flair URL. 2020-05-25 13:11:00 +05:30
c011b817b2 FIX: do not fallback to flair_url column
flair_url is not loaded by our query anymore so avoid falling back
to the old value
2020-05-25 16:25:42 +10:00
47c6fe9bfa Merge branch 'master' of github.com:discourse/discourse 2020-05-25 11:36:18 +05:30
098c9e5950 Build(deps-dev): Bump rspec-rails from 4.0.0 to 4.0.1 (#9804)
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases)
- [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-rails/compare/v4.0.0...v4.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-25 15:50:56 +10:00
e31adef32d FIX: Keep composer title and reply when switching to PM (#9851) 2020-05-25 15:46:02 +10:00
32d13ab97f DEV: Bump rack-mini-profiler from 2.0.1 to 2.0.2 (#9865)
Bumps [rack-mini-profiler](https://github.com/MiniProfiler/rack-mini-profiler) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/MiniProfiler/rack-mini-profiler/releases)
- [Changelog](https://github.com/MiniProfiler/rack-mini-profiler/blob/master/CHANGELOG.md)
- [Commits](https://github.com/MiniProfiler/rack-mini-profiler/compare/v2.0.1...v2.0.2)

This is a simple fix to restore client timings in the UI
2020-05-25 15:43:55 +10:00
8e56197728 UX: use "icon-picker" & "image-uploader" fields to set group flair. (#9779) 2020-05-25 11:08:47 +05:30
13d5ccedf5 FIX: Destroying a user failed when it had title
...because updating the user caused a validation of the primary email and the UserEmail records are already deleted at that time.
2020-05-24 22:14:50 +02:00
6f03d14c23 FEATURE: category setting for default list filter. 2020-05-25 00:04:06 +05:30
058bf56b4c FIX: group card not showing if user can't see its members. 2020-05-24 23:08:51 +05:30
60a3110113 FIX: call getURL method explicitly to prevent this context override. 2020-05-24 21:58:03 +05:30
faeb5793ba UI: various tweaks to polls UI on mobile (#9864) 2020-05-23 19:08:49 +02:00
d9a02d1336 Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse""
This reverts commit 20780a1eeed56b321daf18ee6bbfe681a51d1bf4.

* SECURITY: re-adds accidentally reverted commit:
  03d26cd6: ensure embed_url contains valid http(s) uri
* when the merge commit e62a85cf was reverted, git chose the 2660c2e2 parent to land on
  instead of the 03d26cd6 parent (which contains security fixes)
2020-05-23 00:56:13 -04:00
20780a1eee Revert "Merge branch 'master' of https://github.com/discourse/discourse"
This reverts commit e62a85cf6fd81a2a34aff6144bd36b9ac459964a, reversing
changes made to 2660c2e21d84bea667e1ea339f91cda352328062.
2020-05-22 20:25:56 -07:00
e62a85cf6f Merge branch 'master' of https://github.com/discourse/discourse 2020-05-22 20:25:42 -07:00
2660c2e21d minor copyedit on theme import error 2020-05-22 20:25:35 -07:00
03d26cd6f0 SECURITY: ensure embed_url contains valid http(s) uri 2020-05-22 14:54:56 -06:00
bf8085e436 FIX: Double Button Alignment Mobile (#9862) 2020-05-22 13:33:29 -05:00
37128d71c7 Add rails_helper to spec (#9861) 2020-05-22 12:27:52 -04:00
06e1d430c1 FIX: better cross browser topic footer buttons alignment (#9860) 2020-05-22 17:03:22 +02:00
671f882fa3 FIX: We don't create a Post object if the queued post gets rejected. We need to count review items directly. (#9856) 2020-05-22 11:50:28 -03:00
f9649c92b5 FIX: Live reloading of css in development (#9859) 2020-05-22 16:37:35 +02:00
793085c703 REFACTOR: slightly cleaner topic admin button css (#9858) 2020-05-22 15:23:17 +02:00
e71f5e8951 UI: apply margin only if the menu has content (#9857) 2020-05-22 15:19:55 +02:00
61d8955fcb DEV: add spec for tag with unicode name 2020-05-22 14:42:22 +05:30
f9d55b4941 FEATURE: Update the topic excerpt when the OP is rebaked (#9852)
* We now have a site setting "topic_excerpt_maxlength" that is used when the OP is created or revised to generate a topic excerpt.
* However, posts created before this setting was introduced cannot benefit from this change unless they are revised, and if the topic excerpt length setting is changed that situation is also not covererd.
* This PR makes a change to rebake! to update the topic excerpt IF the post is the OP.
2020-05-22 13:04:15 +10:00
c0779df99d FIX: Remove access control post FK from uploads (#9853) 2020-05-22 11:20:25 +10:00
d11c462104 SECURITY: ERB execution in custom Email Style 2020-05-21 14:48:30 -04:00
5a71c51ddd FIX: tag input says tags are optional when they're required 2020-05-21 12:40:33 -04:00
1a5bcf2a64 UX: Remove live theme previewing in favor of refresh (#9798) 2020-05-21 08:32:50 -05:00
11304ba27c Build(deps): Bump rubocop from 0.83.0 to 0.84.0 (#9849)
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.83.0 to 0.84.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.83.0...v0.84.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-21 09:23:34 -04:00
bde8862f0f FIX: Allow GitHub app client_id to be used for OAuth configuration 2020-05-21 10:44:25 +01:00
66960563ea FIX: ensures category chooser is case insensitive (#9850) 2020-05-21 11:16:44 +02:00
7b6fbe9af2 FIX: adds missing tags to published page header (#9835) 2020-05-21 11:04:23 +02:00
18959ff9da UX: user name instead username for profile link title 2020-05-21 14:02:12 +05:30
3c9212fd88 UX: add title for user profile link 2020-05-21 13:00:05 +05:30
a2d939608d Bump rails_failover to 0.2.0. 2020-05-21 11:41:58 +08:00
f4b82f1dc0 DEV: Fix randomly failing spec.
If a user is created with an id of 999, a `upload.user_id ==
user_avatar.user_id` will return true. This fix increases the id of the
upload to something that we will not hit in the foreseeable future.
2020-05-21 11:41:07 +08:00
df68d11c38 FEATURE: Add topic excerpt max length site setting (#9847)
Adds a new topic_excerpt_maxlength site setting.

* When topic excerpt is requested for a post, use the new topic_excerpt_maxlength site setting to limit the size of the excerpt
* Remove code for getting/setting Post.excerpt_size as it is not used anywhere
2020-05-21 13:19:48 +10:00
68db5deaec FIX: Badge granter was disabled by default. 2020-05-21 06:55:22 +08:00
bf7103343a FIX: sidekiq is using _forim_session (#9825)
Configure Sidekiq to use _forum_session instead of a rack.session
2020-05-21 08:19:21 +10:00
62ecb2885f glob @import desktop and mobile scss 2020-05-20 18:05:27 -04:00
234933c781 FIX: Show staff counters if the rejected posts count is the only value to show (#9845) 2020-05-20 19:00:35 -03:00
eef47a26d9 UX: More consistent mobile banner/alert styles, css cleanup 2020-05-20 17:17:47 -04:00