Commit Graph

31532 Commits

Author SHA1 Message Date
Sam
ebd4140492 FIX: logspam due to 404s on CSS files
We had a missing formats: string on our render partial that caused logs to
spam when CSS files got 404s.

Due to magic discourse_public_exceptions.rb was actually returning the
correct 404 cause it switched format when rendering the error.
2019-02-14 17:58:16 +11:00
39522659a6 FIX: validate parent category/subcategories permissions
See: https://meta.discourse.org/t/subcategories-do-not-inherit-permissions-from-parent-category/17174/23 for more details

This ensures users with access to child category can always at least see parent
2019-02-14 16:38:52 +11:00
090e9c8432 FIX: make composer full screen shortcut work when inputs have focus (#6907)
- Uses a Mousetrap plugin for global shortcuts
- Implemented for search `ctrl+alt+f` and composer fullscreen `shift+f11` shortcuts
2019-02-14 00:19:27 -05:00
ed6f4dfc40 FEATURE: trigger user profile create and update event (#6958)
Adds `user_profile_created` DiscourseEvent on profile creation and `user_profile_updated` on profile update
2019-02-14 15:45:12 +11:00
b651605d6e FIX: tags added while editing a pending approval topic do not show up (#6959) 2019-02-14 15:42:40 +11:00
Sam
74d2d4f658 FEATURE: add APIS for unpausing all sites
This adjusts 53d592ad by @tgxworld

- Adds Sidekiq.upause_all! to unpause all sites
- Adds Sidekiq.paused_dbs to list dbs that are currently paused
- Handles some edge cases where unpause thread could extend expiry on
sites that were unpaused from a different process
- Ensures tests always terminates background thread used for pause
keepalive
2019-02-14 13:34:20 +11:00
37666c3d18 UX: Signup form labels were too constrained, minor cleanup 2019-02-13 21:07:34 -05:00
53d592ad3b FIX: Add multisite support to Sidekiq::Pausable. (#6960)
Having a global Sidekiq pause switch is problematic because a site in
the cluster can pause Sidekiq for the entire cluster.
2019-02-14 12:22:40 +11:00
Sam
ba2fb2024f FEATURE: by default exclude thumbnails from backups
This makes backups slimmer out of the box but introduces extra process post
restore to run a full rebake of all posts containing uploads and all avatars

The benefit (slimmer backup) outweighs the cost of running the full rebake
2019-02-14 12:20:55 +11:00
a9a8855739 DEV: Get only matching records to backfill etags 2019-02-14 06:27:18 +05:30
e2f7db5549 Fix typo 2019-02-14 05:56:30 +05:30
484bd82278 FIX: Add onceoff job to remove double quotes from s3 etags 2019-02-14 05:19:41 +05:30
7b5931013a Update rake task to backfill etags from s3 inventory 2019-02-14 05:18:06 +05:30
b8d2549922 FIX: OptimizedImage model doesn't have 'created_at' date column 2019-02-14 03:46:00 +05:30
426bd810f1 FIX: S3 inventory can have duplicate etags 2019-02-14 03:44:14 +05:30
1045bbc35b FIX: S3 inventory data can be splitted into multiple csv files 2019-02-14 03:41:52 +05:30
0476169692 make prettier happy 2019-02-13 22:16:38 +01:00
94fe0af900 FIX: upload emojis sequentially to prevent rate limit 2019-02-13 22:07:37 +01:00
4d674acc25 FEATURE: AWS SNS bounce notifications webhooks 2019-02-13 21:26:40 +01:00
560cc4e73e FIX: sets categoryId but do not scope when replying as new topic (#7002) 2019-02-13 15:19:58 +01:00
fe4254b8f3 FIX: reverse consolidated pageviews stacked chart order (#7001) 2019-02-13 12:24:18 +01:00
b087719340 FEATURE: Setting for excluding optimized images from backups 2019-02-13 11:10:51 +01:00
1c00e8a755 Bump logster to 2.1.0 (#7000) 2019-02-13 10:57:22 +01:00
Sam
641b079c78 FIX: add support for missing verbs in user api key
Previously "write" scope was missing put and delete verbs which should be
allowed.

Also closes: #6982
2019-02-13 15:49:43 +11:00
1328a127ee FIX: translate bootbox confirmation dialog (#6981) 2019-02-13 14:04:56 +11:00
90292d23df add elastic back in, at the bottom per sort order 2019-02-12 18:40:46 -08:00
467cfc9e08 FIX: remove extra periods (#6998)
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
2019-02-13 12:54:34 +11:00
47fe34d794 FEATURE: makes create-account userfields using dropdowns accessible (#6991) 2019-02-13 12:52:55 +11:00
603f2c6090 Remove Elastic email as recommended provided (#6994)
They updated their [pricing](https://elasticemail.com/pricing/) and only allow 100mails/day now.
2019-02-13 12:50:21 +11:00
3da35081e5 UX: Embedded post collapse button hover color fix 2019-02-12 17:21:33 -05:00
fb911766ee FIX: Bump onebox version to include imgur security fix 2019-02-13 01:14:06 +05:30
36ff971c9c FIX: Bump onebox version to include imgur security fix 2019-02-13 01:11:24 +05:30
5cef5b34ef DEV: Yarn-manage moment and moment-timezone libraries 2019-02-12 13:57:52 -05:00
c23411cc69 FIX: Heisentest - suspicious logins report was not ordered by date
The specs needed an order even though none was supplied.
2019-02-12 13:17:29 -05:00
86fe423f5e FIX: Clear the cache after destroying theme_fields 2019-02-12 16:39:40 +00:00
91f0468f4e FIX: Allow unbaked theme fields to be destroyed
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
2019-02-12 16:14:43 +00:00
9eb7dea0f1 FEATURE: Setting for compression level of upload in backups 2019-02-12 15:50:31 +01:00
59640ef373 DEV: Add additional hooks for theme-creator plugin 2019-02-12 14:17:34 +00:00
220944a38a FIX: Unpause sidekiq before adding uploads to backup
tar exits with status 1 when uploads are modified or deleted by a sidekiq job, so we need to treat it like status 0.

According to the documentation it should be safe to ignore status 1 ("Some files differ"):

> If tar was given `--create', `--append' or `--update' option, this exit code means that some files were changed while being archived and so the resulting archive does not contain the exact copy of the file set.

Status 2 ("Fatal error") still results in an exception.
2019-02-12 13:50:50 +01:00
b8b1759de9 UX: show envelope when tag is only used in PM
UX: use regular envelope instead of solid envelope

REFACTOR: %s/enveloppe/envelope/g
2019-02-12 11:34:25 +01:00
90ce448675 PERF: Cache build_not_found_page 2019-02-12 21:20:33 +11:00
d997b01a24 FIX: Scale down swipe in detection to 20px from edge of the screen
...and slightly increase velocity required for menu actions
2019-02-11 21:22:50 -08:00
c3cbff55be FIX: only respond to menu open swipes on Andorid 2019-02-11 20:56:25 -08:00
12d061a45b Remove stubbing of auto_close_threshold_reached? 2019-02-11 15:41:03 -05:00
b8d5f8d29d REFACTOR: remove where conditions array with only 1 item 2019-02-11 15:42:32 +01:00
705c898c21 FEATURE: Calculate CSP based on active themes (#6976) 2019-02-11 12:32:04 +00:00
e0c16d3a8a minor refactoring to improve code readability 2019-02-11 17:24:02 +05:30
dcd7b92532 FIX: some posters were not getting added to topic_allowed_users when moving posts to a new PM
If a user posted twice in a topic then subsequent posters were not getting added as topic_allowed_users.
2019-02-11 17:05:21 +05:30
2c12336c6b FIX: Display post updated date in non-JS view for crawler 2019-02-11 16:48:22 +05:30
c50db76f5d FIX: do not treat TIFF, BMP, WEBP as images
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.

You can still upload these files they will simply not be displayed in IMG tags.
2019-02-11 16:28:43 +11:00