Commit Graph

52021 Commits

Author SHA1 Message Date
eef93ac926 DEV: Allow setting max_length for field types using the plugin API (#24635) 2023-11-29 14:17:12 -06:00
384a8b17a1 FIX: leaving a group channel should destroy membership (#24631)
In other kind of channels we will only unfollow but for group channels we don't want people to keep appearing in members list.

This commit also creates appropriate services:
- `Chat::LeaveChannel`
- `Chat::UnfollowChannel`

And dedicated endpoint for unfollow: `DELETE /chat/api/channels/:id/memberships/me/follows`
2023-11-29 17:48:14 +01:00
11636f8736 DEV: Add missing html-safe on search result blurb (#24633) 2023-11-29 09:05:10 -07:00
c4767158df DEV: Move desktop notifications logic to service (#24466) 2023-11-29 08:20:48 -06:00
8cf13977a1 DEV: Fix or disable various lint rules (#24630)
A grab bag of smaller issues (constructor-super, no-fallthrough, ember/no-private-routing-service, no-unreachable, no-async-promise-executor)
2023-11-29 15:14:53 +01:00
7cac167928 DEV: Fix "ember/no-empty-glimmer-component-classes" lint (#24629) 2023-11-29 15:14:30 +01:00
0f7e4d2eaa DEV: Convert input-tip to gjs (#24624) 2023-11-29 13:00:36 +01:00
265a8cd2b2 DEV: Fixup plugin initialization guard (#24628)
In development, I sometimes get `nil` `location.absolute_path` values. It looks like this is sometimes expected (https://bugs.ruby-lang.org/issues/10561) so we should fallback to `.path` and add a nil check.
2023-11-29 11:44:09 +00:00
1881ae50be FIX: category-selector for top level categories (#24627)
The filter for top-level categories by using parent_category_id = -1 is
only implemented by the new search API.

Follow up to commit dbb8b66a378ec84a794510fcdcdc2ff9131c6aa3.
2023-11-29 13:29:18 +02:00
d38360b23f DEV: Fix ember/no-private-routing-service (#24009) 2023-11-29 12:26:52 +01:00
cbe772f6fa DEV: Fix router linting errors (#24012)
`ember/no-unnecessary-route-path-option`
`ember/routes-segments-snake-case`
2023-11-29 12:26:31 +01:00
6e4648a2c4 UX: Various improvements to JSON Schema editor (#24543)
This commit makes a few improvements to the JSON Schema editor when using dark mode for the UI and fixes a small alignment issue with checkboxes.
2023-11-29 13:39:49 +03:00
75efeb395e DEV: Add stale PR workflow (#24625)
- Mark stale after 60 days
- Close 14 days later
2023-11-29 10:37:11 +00:00
c90772fd3a Update translations (#24599) 2023-11-29 10:41:27 +01:00
dbb8b66a37 FIX: Show only top categories in first category-drop (#24575) 2023-11-29 09:41:25 +02:00
Sam
b09422428d DEV: update syntax tree to latest (#24623)
update format to latest syntax tree
2023-11-29 16:38:07 +11:00
d40c0b698c FIX: Word wrap for quote buttons (#24620)
The button text was becoming multiline unnecessarily
2023-11-29 10:43:52 +10:00
dfd9c9b8d0 DEV: Fix flagging post flaky (#24619)
Followup to 91ec3323ddcb46279d211ae34a3982ab7337ba14,
remove DB check and check actual UI.
2023-11-29 08:16:52 +10:00
71ae565229 Build(deps): Bump excon from 0.104.0 to 0.105.0 (#24618)
Bumps [excon](https://github.com/excon/excon) from 0.104.0 to 0.105.0.
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt)
- [Commits](https://github.com/excon/excon/compare/v0.104.0...v0.105.0)

---
updated-dependencies:
- dependency-name: excon
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-28 23:15:34 +01:00
33d0b9375a Build(deps): Bump json_schemer from 2.1.0 to 2.1.1 (#24617)
Bumps [json_schemer](https://github.com/davishmcclurg/json_schemer) from 2.1.0 to 2.1.1.
- [Changelog](https://github.com/davishmcclurg/json_schemer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/davishmcclurg/json_schemer/compare/v2.1.0...v2.1.1)

---
updated-dependencies:
- dependency-name: json_schemer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-28 23:14:55 +01:00
8f6e8344aa DEV: Remove unused search plugin outlets (#24614) 2023-11-28 14:55:22 -07:00
9a909758ac FIX: Escape topic titles when use_pg_headlines_for_excerpt true (#24608) 2023-11-28 14:32:22 -07:00
9576f3ec97 UX: create category doesn't always need a dropdown (#24610) 2023-11-28 16:28:07 -05:00
2d2fd15636 Build(deps-dev): Bump the embroider group in /app/assets/javascripts with 1 update (#24615)
* Build(deps-dev): Bump the embroider group

Bumps the embroider group in /app/assets/javascripts with 1 update: [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat).

- [Release notes](https://github.com/embroider-build/embroider/releases)
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md)
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat)

---
updated-dependencies:
- dependency-name: "@embroider/compat"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: embroider
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update lockfiles for ember version flag

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2023-11-28 22:23:13 +01:00
18a0783643 FIX: use correct color for inputs (#24616) 2023-11-28 16:21:36 -05:00
178c1f74ae UX: Place login button text in span tag (#24613) 2023-11-28 15:02:30 -06:00
e4499d98e6 DEV: Update search-menu-before-term-input outlet args (#24573) 2023-11-28 13:47:23 -07:00
fae3b89818 FIX: Add setters for some group properties (#24572)
These properties are set on the "Manage > Categories" group page. It
used to work, but only because it overridden the properties and it did
not update the IDs too.
2023-11-28 21:38:49 +02:00
19378cc068 FIX: lint unlinted file (#24612) 2023-11-28 14:11:55 -05:00
6d624c6f1a UX: fix disabled input styles (#24603) 2023-11-28 14:10:41 -05:00
35dde2da21 FIX: Add more specificity to outline (#24611) 2023-11-28 12:44:45 -06:00
12902c1fc1 FEATURE: Add search menu outlet (#24609) 2023-11-28 12:12:09 -06:00
ee5bdb3436 DEV: refactor flag message (#24604)
- Uses a chat service: `Chat::FlatMessage`
- Moves logic inside chat api controllers
- Create a javascript chat api helper: `chatApi.flagMessage(...)`
2023-11-28 18:24:09 +01:00
de0c761516 DEV: Skip flaky chat transcript specs (#24607) 2023-11-28 14:13:25 -03:00
feb5eda0d1 DEV: Make theme-qunit discoverable from /tests (#24606)
https://github.com/discourse/discourse/assets/50783505/c6db8c35-1473-4ccd-aca2-bfb71af9e73e
2023-11-28 10:04:23 -07:00
d7f618807e DEV: Don't warn about clearing tmp/cache (#24602)
No reason to print it out every time 😅 (plus, use the ruby method)
2023-11-28 18:02:27 +01:00
8f901cdd38 UX: Change direction of focus outline (#24605) 2023-11-28 10:58:16 -06:00
e85a81f33c FIX: Make category-drop work with lazy_load_categories (#24187)
The category drop was rerendered after every category async change
because it updated the categories list. This is not necessary and
categories can be referenced indirectly by ID instead.
2023-11-28 17:58:47 +02:00
21d614215b DEV: Use staged user check instead (#24578)
This change refactors the check `user.groups.any?` and instead uses
`user.staged?` to check if the user is staged or not.

Also fixes several tests to ensure the users have their auto trust level
groups created.

Follow up to:

- 8a45f84277e6e13bc48b8f4e40350a9cbd5cd2ee
- 447d9b210556e64c14f9ca9f8f9b52f54090cd41
- c89edd9e86870f97a770816210d71400f09181f2
2023-11-28 07:34:02 -07:00
2a3418fe24 DEV: Don't use the deprecated createEvent() (#24601) 2023-11-28 15:05:51 +01:00
9d44d833d5 DEV: Remove unnecessary getURL() calls (#24591)
`ajax()` already uses it
2023-11-28 14:32:15 +01:00
91ec3323dd DEV: Temporary fix for flaky system test (#24598)
Why this change?

Asserting against records of the database in system tests can be flaky
because those assertions can run against the database before the server
has actually saved the necessary changes to the database.

What does this change do?

While the assertion is not ideal, we are working around this as a
temporary fix by using `try_until_success` which will retry the
assertion up till the default capybara timeout.
2023-11-28 21:00:56 +08:00
0cad82ef55 DEV: Update click-track tests (#24597) 2023-11-28 13:54:30 +01:00
5783f231f8 DEV: Introduce DISCOURSE_ASSET_URL_SALT (#24596)
This value is included when generating static asset URLs. Updating the value will allow site operators to invalidate all asset urls to recover from configuration issues which may have been cached by CDNs/browsers.
2023-11-28 11:28:40 +00:00
22ce638ec3 FIX: Use subfolder-safe url for category in html view (#24595)
Use subfolder-safe url for category in html view
2023-11-28 19:08:14 +08:00
1eaf774f47 Build(deps): Bump actions/setup-node from 3 to 4 (#24594) 2023-11-28 10:57:28 +01:00
4953bced64 DEV: Remove unused searchTags param (#24590) 2023-11-28 10:56:36 +01:00
4c7793940a DEV: Fix "no-dupe-keys" lint (#24589) 2023-11-28 10:55:52 +01:00
e9356c2ec9 DEV: Fix "no-empty" lint (#24588) 2023-11-28 10:55:02 +01:00
70dc6bcfd3 DEV: Fix "no-unsafe-finally" lint (#24587) 2023-11-28 10:54:13 +01:00