Commit Graph

38393 Commits

Author SHA1 Message Date
f68ea29236 FIX: Don't load images that don't exist in test
This makes 404 requests and fills up the logs with junk
2020-07-17 14:33:38 -04:00
0ecca3a2d2 FIX: tooltip is no longer used
It has been deprecated and now it's time to remove it.
2020-07-17 14:08:45 -04:00
edff796e87 FIX: Discourse.Site is deprecated 2020-07-17 14:03:59 -04:00
8e3f667d7c FIX: Show background images for both slug formats
It seems there was a discrepancy in that background images were attached
to the full slug category class: `category-:slug-:id` and our body class
only had `category-:slug`.

This fix adds support for both formats.
2020-07-17 13:42:30 -04:00
db9162610a FIX: missing title when inserting hyperlinks 2020-07-17 10:41:58 -04:00
85d1677b26 DEV: Drop unsupported-browser plugin (#10261)
Discourse 2.6 will not have support for older browsers (e.g. IE11)
2020-07-17 15:04:06 +01:00
fab8b8649e PERF: Combine avatar_lookup and primary_group_lookup into user_lookup (#10253)
These two classes were running very similar queries, which could be expensive on large topics
2020-07-17 10:48:08 +01:00
716ccf7fe4 FIX: Bookmark search fixes (#10239)
* Remove unneeded bookmark name index.
* Change bookmark search query to use post_search_data. This allows searching on topic title and post content
* Tweak the style/layout of the bookmark list so the search looks better and the whole page fits better on mobile.
2020-07-17 15:55:07 +10:00
ff7678e210 FIX: Reindex posts when Topic#title or Category#name changes. 2020-07-17 11:12:31 +08:00
39fef99c37 FIX: add topic title back to choose-topic 2020-07-16 20:19:33 -04:00
15c4f6e4cf FIX: update meh-o icon to far-meh (#10256) 2020-07-16 16:26:17 -07:00
cf16173eca Remove extra blank line 2020-07-16 14:57:29 -06:00
cc8540701e FIX: Be sure to use same units when comparing thumbnail size 2020-07-16 14:30:29 -06:00
e1bc709dc3 FIX: Fewer 404s in JS tests 2020-07-16 16:23:54 -04:00
4656812e00 FIX: More errors being logged in tests 2020-07-16 16:19:20 -04:00
b7fe5f04ba FIX: Deprecation usernames is now recipients 2020-07-16 16:11:52 -04:00
b5735f98e9 FIX: Remove more computed properties being set
Note: This also removes a test. The test had not properly stubbed its
request and was erroring in dev mode, and the test was relying on the
erronous result.
2020-07-16 16:06:27 -04:00
6ba1c64130 FIX: deprecation - usernames is now recipients 2020-07-16 15:42:51 -04:00
f13ec11c64 FEATURE: Add scopes to API keys (#9844)
* Added scopes UI

* Create scopes when creating a new API key

* Show scopes on the API key show route

* Apply scopes on API requests

* Extend scopes from plugins

* Add missing scopes. A mapping can be associated with multiple controller actions

* Only send scopes if the use global key option is disabled. Use the discourse plugin registry to add new scopes

* Add not null validations and index for api_key_id

* Annotate model

* DEV: Move default mappings to ApiKeyScope

* Remove unused attribute and improve UI for existing keys

* Support multiple parameters separated by a comma
2020-07-16 15:51:24 -03:00
766cb24989 FIX: Overwriting more computed properties 2020-07-16 13:22:13 -04:00
01cd371be5 FIX: Remove computed property setting from hamburger test 2020-07-16 12:17:15 -04:00
d99355deca FIX: Don't use jQuery directly in a test 2020-07-16 12:00:29 -04:00
46e5372c06 FIX: Setting computed properties in tests 2020-07-16 11:57:50 -04:00
b630fccbd7 Update ember source 2020-07-16 11:28:52 -04:00
70771e02bb FIX: Removal of i18nPrefix deprecations 2020-07-16 10:41:11 -04:00
62d5a9690f FIX: Remove user_deleted when staff recovers post (#10245) 2020-07-16 09:15:01 -05:00
3252cb847c FIX: : trigger user_updated event only if email changed after user creation.
Follow-up to 1460d7957c5d9b9300034e5e36675cf44cc3bc0f
2020-07-16 18:21:30 +05:30
29788f2c26 DEV: Switch from Transifex to Crowdin 2020-07-16 14:00:02 +02:00
1460d7957c FEATURE: trigger user_updated event if email changed.
It will trigger `user_updated` Discourse event if a user_email record is created or updated or destroyed.
2020-07-16 14:20:41 +05:30
906a84d66f DEV: correct some Ruby 2.7 deprecations
There are a few left, especially in gems but this makes some progress
2020-07-16 17:43:20 +10:00
af87911178 FIX: in:title search should only search through topic first posts. 2020-07-16 12:21:19 +08:00
84de643c04 PERF: Reduce size of search payload by removing unused topic attributes. 2020-07-16 11:49:06 +08:00
88a43ef800 FIX: Search page bulk-select button position 2020-07-15 22:57:40 -04:00
d9475b70c7 FIX: count new and unread respects muted categories (#10131)
* FIX: count new and unread respects muted categories

countCategoryByState function should take categories muted by the user into consideration
2020-07-16 12:24:51 +10:00
8ceb7f490f DEV: Ignore order of categories in search spec. 2020-07-16 09:29:23 +08:00
1e9ce51151 FIX: Prevent thumbnail gen if image too large (#10247)
It's possible through an import or other means to have images larger
than the current max allowed image size in the db.

If this happens the thumbnail generation job will keep running
indefinitely trying to download a new copy of the original but
discarding it because it is larger than the max_file_size eventually
causing this error

`Job exception: undefined method `path' for nil:NilClass`

because the newly downloaded image is now nil.

This fix stops the enqueuing of the `GenerateTopicThumbnails` job for
all images that happen to be larger than the max image size.
2020-07-16 11:15:53 +10:00
ee88666bad FEATURE: Improve header meta alignment and truncation with css grid (#10238) 2020-07-15 19:30:35 -04:00
a04573c28e FIX: apply video preview workaround to iOS
Followup to 9e160f5
2020-07-15 19:29:43 -04:00
9c3f89c17e Let category rows occupy full width when editing topic title w/ no tags 2020-07-15 19:16:02 -04:00
9052dfe356 FEATURE: load hidden posts in segments (#10240)
* FEATURE: load hidden posts in segments

Currently, when "View hidden replies" button is clicked, all replies are loaded like there is no tomorrow. When there is plenty of hidden replies, it may cause a timeout.

Therefore, we should load them in pages and display the view link as long as we have more hidden replies.
2020-07-16 09:05:11 +10:00
34bbd51350 FIX: regression in secure URL generation, followup to 36bad0c 2020-07-15 18:52:59 -04:00
36bad0c31f FIX: Preload metadata for audio/video when secure media enabled
Fixes an issue with missing video previews. Should have no side effects now that presigned URLs expire after 5 minutes.
2020-07-15 18:36:51 -04:00
9e160f58ab FIX: Trick Safari into loading video previews (#10244) 2020-07-15 18:14:14 -04:00
fa612fca82 FIX: Off-by-one-slash error in topic.notifications.reasons (#10246) 2020-07-15 14:37:27 -07:00
4f4d8d683f FIX: add noindex header to user summary page. 2020-07-16 02:32:55 +05:30
24b3996f45 FIX: Don't overwrite maxlength computed property
We can use a `text-field` instead.
2020-07-15 16:05:37 -04:00
6fac4a36b4 FIX: loaded is a CP and can't be overwritten 2020-07-15 15:53:59 -04:00
9889b7277f FIX: Silence route-recognizer source map errors in development mode 2020-07-15 15:42:04 -04:00
e0c7fdc0c6 FIX: Silence ember-qunit source map warning 2020-07-15 15:35:32 -04:00
e8bf304f05 FIX: Add popper sourcemap 2020-07-15 15:29:12 -04:00