2987901043
FIX: skip category notification_level unless scoped
...
#b19dcac2 improved the serializer so it sends default notification
levels to users to work around cases where a category edit would
would result in clients being left with invalid notification state
Unfortunately this did not address the root issue.
When we edit categories we publish state to multiple users this
means that the serializer is executed unscoped with no user.
The client already handles this case per:
dcad720a4c/app/assets/javascripts/discourse/app/models/site.js (L119-L119)
2020-06-24 17:08:12 +10:00
0e2f7ecfd0
DEV: Make component-test afterEach async aware ( #10099 )
...
Before this fix, if a test case was async, `afterEach` callback would be executed immediately, without waiting for the test to finish. 😬
2020-06-24 16:03:38 +10:00
843bf0df75
FIX:Add migration to delete tracking state for staged users ( #10083 )
2020-06-24 15:58:14 +10:00
52278ce6fd
FIX: Use Discourse.system_user when we need a placeholder admin ( #9781 )
2020-06-24 15:51:30 +10:00
713298c622
FIX: advanced tutorial errors when all categories are secured ( #10111 )
...
The category hashtag step will fail with an error when all
categories aren't public. Choose a category that the user can see.
2020-06-24 15:45:50 +10:00
42226e12ee
FEATURE: Add after-user-name plugin outlet ( #10113 )
2020-06-24 15:45:11 +10:00
dcad720a4c
DEV: add optional verbose logging to re-index job
...
This verbose logging can be useful when executing the job by hand
for debugging purposes
In general people will not use this
2020-06-24 15:37:08 +10:00
b28d97b64a
FIX: Bump onebox for twitch video and clips embedding fix.
2020-06-24 11:00:30 +08:00
e0cd7ddada
Build(deps): Bump excon from 0.74.0 to 0.75.0
...
Bumps [excon](https://github.com/excon/excon ) from 0.74.0 to 0.75.0.
- [Release notes](https://github.com/excon/excon/releases )
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v0.74.0...v0.75.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-06-24 09:35:51 +08:00
f6ad0d3fac
Build(deps): Bump diff-lcs from 1.4 to 1.4.1
...
Bumps [diff-lcs](https://github.com/halostatue/diff-lcs ) from 1.4 to 1.4.1.
- [Release notes](https://github.com/halostatue/diff-lcs/releases )
- [Changelog](https://github.com/halostatue/diff-lcs/blob/master/History.md )
- [Commits](https://github.com/halostatue/diff-lcs/compare/v1.4...v1.4.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-06-24 09:35:12 +08:00
13087cab54
FIX: Prevent typing "#" when showing "Jump to…"
...
Closes https://meta.discourse.org/t/the-shortcut-behaves-wrong-in-some-browsers/155531
2020-06-24 00:25:54 +02:00
4c543b4a49
UX: Make youtube embeds full width by default ( #10106 )
...
* UX: Make youtube embeds full width by default
* UX: Make youtube embeds fluid by default actually
* Remove double sizes in yt-lazy
2020-06-23 17:21:36 -03:00
4a189f396e
Build(deps): Bump diff-lcs from 1.3 to 1.4 ( #10112 )
...
Bumps [diff-lcs](https://github.com/halostatue/diff-lcs ) from 1.3 to 1.4.
- [Release notes](https://github.com/halostatue/diff-lcs/releases )
- [Changelog](https://github.com/halostatue/diff-lcs/blob/master/History.md )
- [Commits](https://github.com/halostatue/diff-lcs/compare/v1.3...v1.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-23 12:46:46 -04:00
91c89df68a
FIX: onebox local topic when using slug-less URL
...
When linking to a topic in the same Discourse, we try to onebox the link to show the title
and other various information depending on whether it's a "standard" or "inline" onebox.
However, we were not properly detecting links to topics that had no slugs (eg. https://meta.discourse.org/t/1234 ).
2020-06-23 17:18:38 +02:00
50ea3c8743
Build(deps): Bump rails_failover from 0.5.1 to 0.5.2 ( #10107 )
...
Bumps rails_failover from 0.5.1 to 0.5.2.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-23 10:45:15 -04:00
c5078e5dc1
DEV: Remove accidentally committed puts statements
2020-06-23 12:41:47 +01:00
368af327fa
DEV: Reduce size of begin-rescue region
...
Follow-up-to: e3e7905d9ebd86943102917b2ff0bfee32035c01
2020-06-23 10:14:09 +01:00
84c12d8f3d
DEV: Allow multisite apps to boot with readonly db.
2020-06-23 16:34:25 +08:00
27b2e335ef
DEV: Retry on distributed mutex timeout error when starting sidekiq.
...
We need Sidekiq to start `mini_scheduler` no matter what. Timeouts
happen when trying to boot an app with Redis in readonly mode.
2020-06-23 15:43:28 +08:00
e92909aa77
FIX: Use ActionDispatch::Http::ContentDisposition for uploads content-disposition ( #10108 )
...
See https://meta.discourse.org/t/broken-pipe-error-when-uploading-to-a-s3-clone-a-pdf-with-a-name-containing-e-i-etc/155414
When setting content-disposition for attachment, use the ContentDisposition class to format it. This handles filenames with weird characters and localization (accented characters) correctly.
2020-06-23 17:10:56 +10:00
97f045d06a
DOCS: remove thin from copyright
...
it is no longer used
2020-06-23 15:43:58 +10:00
1157d2a0ff
DEV: Print proper summary when errors have been reporter in turbo_rspec
2020-06-23 13:34:58 +08:00
add2a9411e
DEV: Remove specs that are no longer relevant.
2020-06-23 12:09:04 +08:00
e3e7905d9e
FIX: TurboTests::Runner not failing on errors.
2020-06-23 11:45:18 +08:00
97d12a3a8e
Bump rails_failover to 0.5.2.
2020-06-23 10:07:30 +08:00
d775338d63
FIX: Use a mutex when reseting column information while seeding.
...
`rake multisite:migrate` runs SeedFu concurently in threads so we need
this to be thread safe.
2020-06-23 09:15:47 +08:00
0384b6d910
FIX: multisite:migrate failing to properly seed data.
2020-06-23 09:10:02 +08:00
25db91e351
Revert "FIX: These tests are broken"
...
This reverts commit b1114b9a20343525c805d7339bd64954965a12f9.
2020-06-23 08:41:10 +08:00
b1114b9a20
FIX: These tests are broken
2020-06-22 16:30:46 -04:00
ac9577bcc7
FIX: Don't raise an exception if we can't update the user on demotion
...
This is causing issues when purging old users, if they are set up in the
exact condition where they will be demoted into another group, but also
do not have a primary email.
2020-06-22 15:43:59 -04:00
d473ddd02c
FIX: Use raw content when checking for watched words to flag ( #10104 )
...
This makes flagged watched words match the behavior of censor, requires_approval and blocked watched words.
2020-06-22 19:48:06 +01:00
1617905e03
Build(deps): Bump rubocop from 0.85.1 to 0.86.0 ( #10103 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.85.1 to 0.86.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.85.1...v0.86.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-22 12:43:39 -04:00
2ffb6ebd47
Build(deps): Bump parser from 2.7.1.3 to 2.7.1.4 ( #10096 )
...
Bumps [parser](https://github.com/whitequark/parser ) from 2.7.1.3 to 2.7.1.4.
- [Release notes](https://github.com/whitequark/parser/releases )
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v2.7.1.3...v2.7.1.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-22 12:39:59 -04:00
2e1efbde52
FIX: Pass local scope variable to inner function
2020-06-22 19:23:59 +03:00
68f767a557
FEATURE: Check if selectable avatars exist before enabling them ( #10032 )
2020-06-22 16:58:26 +03:00
685646540a
FIX: Hide PM tags if the site setting is disabled ( #10089 )
...
* FIX: Hide PM tags if the site setting is disabled
* Apply code suggestions
2020-06-22 16:48:24 +03:00
aff9bfd5bc
FIX: Fix select kit size ( #10094 )
2020-06-22 16:48:00 +03:00
8cc8e80d7a
Fix the build.
2020-06-22 14:50:17 +08:00
3370ef188e
FEATURE: Remove deprecated uploads url site settings.
...
The site settings have been replaced with direct image upload since
Discourse 2.3.
2020-06-22 14:32:29 +08:00
516a03be09
FIX: Improve admin permalink UX ( #10101 )
...
The admin permalink list was a little tricky to use because the URLs are easily reduced with a ... if they are too long. This adds a copy to clipboard button for the URL and a title on hover so the full text of the URL can be seen.
2020-06-22 13:14:16 +10:00
26260d50b1
DEV: Import I18n in standard plugins ( #10098 )
2020-06-22 02:36:45 +02:00
d04234c667
DEV: Fix typos in tests
2020-06-21 21:56:20 +02:00
1f053173a4
FEATURE: Import script for jForum
2020-06-21 12:12:42 +02:00
390dc5c7a9
Update translations
2020-06-21 11:58:21 +02:00
02d3bf304a
remove inaccurate comment, follow up to c028936
2020-06-19 16:49:56 -04:00
c0289362f7
Safari icon fix, follow up to 5cc0369
2020-06-19 16:44:34 -04:00
17c4f76eac
FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled ( #10091 )
2020-06-19 20:21:05 +01:00
f28ea4751b
FIX: A variable name typo
...
Not that this whole method is used much anymore.
2020-06-19 19:29:19 +02:00
47a1157458
DEV: various bugfixes in bulk importer
2020-06-19 17:53:06 +02:00
0b58414de2
DEV: Add classes to admin customize nav items ( #10092 )
2020-06-19 10:51:53 -05:00
