f9d55b4941
FEATURE: Update the topic excerpt when the OP is rebaked ( #9852 )
...
* We now have a site setting "topic_excerpt_maxlength" that is used when the OP is created or revised to generate a topic excerpt.
* However, posts created before this setting was introduced cannot benefit from this change unless they are revised, and if the topic excerpt length setting is changed that situation is also not covererd.
* This PR makes a change to rebake! to update the topic excerpt IF the post is the OP.
2020-05-22 13:04:15 +10:00
c0779df99d
FIX: Remove access control post FK from uploads ( #9853 )
2020-05-22 11:20:25 +10:00
d11c462104
SECURITY: ERB execution in custom Email Style
2020-05-21 14:48:30 -04:00
5a71c51ddd
FIX: tag input says tags are optional when they're required
2020-05-21 12:40:33 -04:00
1a5bcf2a64
UX: Remove live theme previewing in favor of refresh ( #9798 )
2020-05-21 08:32:50 -05:00
11304ba27c
Build(deps): Bump rubocop from 0.83.0 to 0.84.0 ( #9849 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.83.0 to 0.84.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.83.0...v0.84.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-21 09:23:34 -04:00
bde8862f0f
FIX: Allow GitHub app client_id to be used for OAuth configuration
2020-05-21 10:44:25 +01:00
66960563ea
FIX: ensures category chooser is case insensitive ( #9850 )
2020-05-21 11:16:44 +02:00
7b6fbe9af2
FIX: adds missing tags to published page header ( #9835 )
2020-05-21 11:04:23 +02:00
18959ff9da
UX: user name instead username for profile link title
2020-05-21 14:02:12 +05:30
3c9212fd88
UX: add title for user profile link
2020-05-21 13:00:05 +05:30
a2d939608d
Bump rails_failover to 0.2.0.
2020-05-21 11:41:58 +08:00
f4b82f1dc0
DEV: Fix randomly failing spec.
...
If a user is created with an id of 999, a `upload.user_id ==
user_avatar.user_id` will return true. This fix increases the id of the
upload to something that we will not hit in the foreseeable future.
2020-05-21 11:41:07 +08:00
df68d11c38
FEATURE: Add topic excerpt max length site setting ( #9847 )
...
Adds a new topic_excerpt_maxlength site setting.
* When topic excerpt is requested for a post, use the new topic_excerpt_maxlength site setting to limit the size of the excerpt
* Remove code for getting/setting Post.excerpt_size as it is not used anywhere
2020-05-21 13:19:48 +10:00
68db5deaec
FIX: Badge granter was disabled by default.
2020-05-21 06:55:22 +08:00
bf7103343a
FIX: sidekiq is using _forim_session ( #9825 )
...
Configure Sidekiq to use _forum_session instead of a rack.session
2020-05-21 08:19:21 +10:00
62ecb2885f
glob @import desktop and mobile scss
2020-05-20 18:05:27 -04:00
234933c781
FIX: Show staff counters if the rejected posts count is the only value to show ( #9845 )
2020-05-20 19:00:35 -03:00
eef47a26d9
UX: More consistent mobile banner/alert styles, css cleanup
2020-05-20 17:17:47 -04:00
096eca0ee8
FIX: Requests were not being logged correctly
...
`enable` was defaulting to `nil` which is not what we wanted.
2020-05-20 15:09:17 -04:00
e1bd57007b
DEV: Specs for AboutController can_see_about_stats? impact ( #9843 )
2020-05-20 11:30:27 -05:00
ba04bb7552
FIX: Path should be addon not app
2020-05-20 12:13:15 -04:00
3062036f2f
FIX: Allow deprecation to work with Ember CLI
2020-05-20 12:05:56 -04:00
8851b79472
DEV: less code for Category#url
2020-05-20 18:01:06 +02:00
09ca75d17e
FIX: select-kit was in the wrong place
...
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
2020-05-20 11:51:49 -04:00
8e7efb48ae
FIX: Update default_template.html
2020-05-20 10:39:04 -05:00
6c9c8dfefd
FIX: guidFor is not part of Ember.Object
2020-05-20 11:31:11 -04:00
bd57ae83f1
DEV: Guardian for hiding about stats ( #9841 )
2020-05-20 10:26:20 -05:00
cfff8b1f27
Build(deps): Bump puma from 4.3.4 to 4.3.5 ( #9836 )
...
Bumps [puma](https://github.com/puma/puma ) from 4.3.4 to 4.3.5.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-05-20 10:37:43 -04:00
4a533ec594
FIX: do not parameterize tag_id ( #9839 )
...
Parameterizing tag_id was breaking tags with non-ascii characters or emoji.
Bug report: https://meta.discourse.org/t/unable-to-see-pm-lists-for-non-ascii-tag/151723/4
2020-05-20 19:22:20 +05:30
30631a963f
UX: moves editFirstPost in taggable Pms in dropdown on mobile ( #9840 )
2020-05-20 14:07:00 +02:00
02f44def56
FIX: Don't blow up when trying to parse invalid or non-ASCII URLs ( #9838 )
...
* FIX: Don't blow up when trying to parseinvalid or non-ASCII URLs
Follow-up to 72f139191e
2020-05-20 12:46:27 +03:00
fb15da43da
Remove old web hooks in favor of 'reviewable' web hook ( #9776 )
...
* FIX: Emit web hooks for flags
* FEATURE: Remove 'flag' web hook in favor of 'reviewable' web hook
* FEATURE: Remove 'queued post' web hook in favor of 'reviewable' web hook
* FIX: Do not set a default value for web hooks with no events
2020-05-20 12:07:48 +03:00
3aecc1990b
DEV: Review follow up to 234cd5c3e7f8d1be7c98af7eeb572e5b79f0a16a.
2020-05-20 16:17:59 +08:00
2f03a879f9
DEV: Require rails_failover before global settings.
2020-05-20 16:06:40 +08:00
f7f436e536
DEV: Install rails_failover gem to test our Redis changes.
2020-05-20 15:40:27 +08:00
30bbc485d0
DEV: remove superfluous comment
2020-05-20 16:53:48 +10:00
e97cb20c2a
UX: strip text from PM bookmark and share buttons
...
Also organize priorities in an easier to reason about way and
shift bookmark topic so it is after link. (consistent with posts)
2020-05-20 16:46:49 +10:00
b031e3220a
FIX: migrations should not fail when db is part migrated
...
When part migrated the translate overrides may have missing columns
in that case just silently ignore overrides
2020-05-20 15:28:01 +10:00
05f7d5a2de
UX: Rename "Edit Message" to "Edit"
...
This reduces the space taken by the button.
2020-05-20 14:12:58 +10:00
37983a7815
Fix lint.
2020-05-20 10:33:34 +08:00
b7387d4611
DEV: Remove code unused code when seeding narrative bot.
2020-05-20 10:22:51 +08:00
234cd5c3e7
FIX: Switch discobot to pull avatar from gravatar.
2020-05-20 10:20:08 +08:00
6b92c78033
FIX: purge all associated data on user delete
...
This commit reorganises the delete dependencies on users and make sure
all are covered. We forgot some on bookmarks, security keys, anon users
and so on.
2020-05-20 11:27:57 +10:00
a93d0a8fcc
UX: Remove bold from category badge text
2020-05-19 21:11:49 -04:00
e334133294
PERF: Remove foreign keys from bookmarks ( #9837 )
...
As a general rule we do not add FKs in Discourse and instead rely on consistency checks at weekly/daily intervals
2020-05-20 10:45:49 +10:00
72f139191e
FIX: S3 store has_been_uploaded? was not taking into account s3 bucket path ( #9810 )
...
In some cases, between Discourse forums the hostname of a URL could match if they are hosting S3 files on the same bucket but the S3 bucket path might not. So e.g. https://testbucket.somesite.com/testpath/some/file/url.png vs https://testbucket.somesite.com/prodpath/some/file/url.png . So has_been_uploaded? was returning true for the second URL, even though it may have been uploaded on a different Discourse forum.
This is a very rare case but must be accounted for, because this impacts UrlHelper.is_local which mistakenly thinks the file has already been downloaded and thus allows the URL to be cooked, where we want to return the full URL to be downloaded using PullHotlinkedImages.
2020-05-20 10:40:38 +10:00
0a700d81fc
FIX: Restoring backups could fail for database dumps > 8GiB
...
This is a temporary fix until we ship a new image with bsdtar.
2020-05-19 22:36:59 +02:00
52228b1fa6
DEV: These routes don't exist anymore ( #9823 )
2020-05-19 16:09:03 -03:00
a239900522
UI: reduces category row description margin ( #9834 )
2020-05-19 20:44:54 +02:00
