Commit Graph

45592 Commits

Author SHA1 Message Date
fa5f3e228c DEV: Refactor user mute/ignore/disallow PM checks into central class (#17366)
The idea behind this refactor is to centralise all of the user ignoring / muting / disallow PM checks in a single place, so they can be used consistently in core as well as for plugins like chat, while improving the main bulk of the checks to run in a single fast non-AR query.

Also fixed up the invite error when someone is muting/ignoring the user that is trying to invite them to the topic.
2022-07-13 13:58:01 +10:00
58bf88d7ba DEV: Add normal as an alias for regular in NotificationLevels.topic_levels (#17466)
Follow-up to 5176c689e9
2022-07-13 06:37:38 +03:00
f1c32a3cdf Build(deps): Bump nokogiri from 1.13.6 to 1.13.7 (#17455)
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.6 to 1.13.7.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.13.6...v1.13.7)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-13 00:33:57 +02:00
638bbf8f7e DEV: prevents prop override and simplifies test (#17457) 2022-07-13 00:20:48 +02:00
a939609d32 FIX: fixes few regressions in select-kit (#17453)
- following c3fd91670e `paste` has been typoed into `pase`
- adds two tests for pasting in `multi-select` and `email-group-user-chooser`
- selectKitOptions would not be following the right overriding order
- `category-selector` was using `selectKitOptions` directly which shouldn't be the case as it's not using computed values
- apparently since a recent ember upgrade, paste event is not providing `originalEvent` anymore and `clipboardData` should be retrieved directly on the event
2022-07-12 21:38:17 +02:00
09f1ef6b05 DEV: Add plugin API to add to robots.txt (#17378)
This plugin API can be used to add to robots.txt. The event handler
receives the complete robots information before it is converted into
robots.txt.
2022-07-12 20:52:55 +03:00
2e7e48d982 UX: Add classes to create-account modal for easier customization (#17435)
Adds BEM-style classes to the input-group elements, and a dynamic class to the create-account-form element that reflects which auth provider is being used (if any).
2022-07-12 10:29:02 -07:00
be29197f62 DEV: Stop overriding an injected property in topic controller test (#17450)
Similar to e15c6302, overriding an auto-injected value like this triggers errors in more recent versions of Ember. Instead, we can use the registry to inject the value we need.

Co-authored-by: Peter Wagenet <peter.wagenet@gmail.com>
2022-07-12 17:29:11 +01:00
0c269dfd18 Update translations (#17447) 2022-07-12 17:26:04 +02:00
0e61f332ee DEV: Make sure testing-container fits in the viewport (#17446)
This prevents tests failures when the browser viewport is too small.
2022-07-12 15:32:43 +02:00
0f3109cc53 Revert "DEV: Update @popperjs/core (#17437)" (#17448)
This reverts commit 76bb8f8926b4b421cef86aa13bce0c0db6b638b4.

There is a dropdown positioning regression that needs to be investigated.
2022-07-12 15:27:52 +02:00
76bb8f8926 DEV: Update @popperjs/core (#17437) 2022-07-12 13:16:00 +02:00
f38114e161 DEV: Remove development cache-buster query parameter (#17444)
All our development-mode assets serve a `Cache-Control: no-cache` header, so a query parameter shouldn't be needed. Ember CLI does not include cache-busting parameters, so this change will move the development rails app to the same behaviour.

This will fix adding persistent breakpoints in the dev tools. Previously, the browser would think that the assets have been replaced and throw away the breakpoints.
2022-07-12 11:53:59 +01:00
8a0bddd98d DEV: Remove an unused js helpers file (#17439) 2022-07-12 12:23:21 +02:00
8bc0ec3fac DEV: Simplify test setup (#17441) 2022-07-12 12:16:17 +02:00
8a68f49adb FIX: Detect firefox < 89 as an unsupported browser (#17443)
Prior to v89, Firefox has bugs with document.execCommand("insertText"): https://bugzil.la/1220696

This commit introduces some variables to browser-detect, and therefore wraps the entire logic in an IIFE to avoid state leaking. (`let`/`const` are not supported on older browsers)
2022-07-12 10:50:06 +01:00
6c3e262a7c FIX: Set resolver options on the legacy resolver (#17440) 2022-07-12 11:42:19 +02:00
e15c63027f DEV: Use auto-injected keyValueStore for screenTrack (#17434)
This manual assignment was added before the keyValueStore was refactored into a service. Now that it's a service, it gets all our standard auto-injections, including the keyValueStore.

Overwriting an automatic injection like this raises an error in future Ember versions.
2022-07-11 22:12:25 +01:00
162a1f8ba7 DEV: Remove asset precompilation hack (#17428)
I don't think it's needed anymore?
2022-07-11 22:52:20 +02:00
365f558bda DEV: Update ember-resolver (#17432) 2022-07-11 22:52:01 +02:00
9e9e843136 DEV: Allow use of qunit notrycatch mode (#17433)
This is useful when debugging exceptions - when the box is checked, exceptions will be thrown and handled by the browser rather than being absorbed by qunit. This allows developers to intercept the exception and inspect the stack.
2022-07-11 21:40:38 +01:00
d39334b640 DEV: Remove qunit autorunner (#17430)
It was watching outdated filepaths and using the old `/qunit` page, so it seems safe to assume nobody relied on this runner?
2022-07-11 22:29:33 +02:00
006de01943 DEV: Update ember-cli-handlebars (#17429) 2022-07-11 22:25:40 +02:00
040e1650f6 DEV: Remove old redis option (#17427)
`Redis.exists_returns_integer` is now true by default
2022-07-11 22:15:30 +02:00
d90cdba70f Revert "UX: missing specificity (#17324)" (#17426)
This reverts commit 473085859851226bedbd798230a8af35f6e383c1.
2022-07-11 20:20:40 +02:00
6b57d792bb UX: Fix exp sidebar toggle alignment, add hovers (#17414) 2022-07-11 12:58:48 -04:00
1f1ba07565 FIX: update flaky bulk invite spec (#17425) 2022-07-11 11:58:23 -05:00
dd62b88f78 DEV: Switch from htmlbars-inline-precompile to ember-cli-htmlbars (#17424)
See https://github.com/ember-cli/ember-cli-htmlbars#tagged-template-usage--migrating-from-htmlbars-inline-precompile
2022-07-11 15:25:40 +01:00
2d2dc45607 Build(deps): Bump redis from 4.5.1 to 4.7.1 (#17310)
Bumps [redis](https://github.com/redis/redis-rb) from 4.5.1 to 4.7.1.
- [Release notes](https://github.com/redis/redis-rb/releases)
- [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md)
- [Commits](https://github.com/redis/redis-rb/compare/v4.5.1...v4.7.1)

---
updated-dependencies:
- dependency-name: redis
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-11 14:58:41 +02:00
f00cf7a119 DEV: uses resize observer to compute header-offset (#17399) 2022-07-11 14:50:52 +02:00
87353faac6 DEV: Implement distributed mutex in lua (#16228)
The rationale behind this was mostly to stop using `redis.synchronize` (now removed in redis gem 4.6)
2022-07-11 14:16:37 +02:00
6487179dec DEV: Don't forward test-i18n.js requests (#17422)
This fixes i18n related tests in dev env
2022-07-11 13:14:44 +02:00
2414a175cf DEV: Update message-bus-client (#17421)
This update covers commits:

* e309b6d [BREAKING Make JS client throw if lastId not number](e309b6d533)
* f0bae69 [DEV: removes dead code](f0bae695b0)
* a72b930 [FIX: force a poll more consistently when visibility changes](a72b9308b4)
* 5c01715 [Permit CORS preflight caching](5c01715432)
* 1789784 [DEV: lint files](17897843b4)
* b9cfb90 [FIX: do not leak visibility event subscriptions on stop/start](b9cfb90dd6)
2022-07-11 13:09:30 +02:00
4437579a8c DEV: Update ember-qunit (#17251) 2022-07-11 12:40:48 +02:00
189bebb2e4 DEV: Modernize component tests (#17368)
* Use QUnit `module` instead of `discourseModule`
* Use QUnit `test` instead of `componentTest`
* Use angle-bracket syntax
* Remove jQuery usage
* Improve assertions (and actually fix some of them)
2022-07-11 12:29:44 +02:00
5b70b67e78 FIX: Just inline the QUnit CSS in theme-test html (#17415)
Side-steps sassc compilation issues.
2022-07-11 12:01:47 +02:00
0ffa93ccaf FIX: Ensure category-tag filter routes are functioning (#17420)
This regressed as part of the changes in fc36ac6c.

This commit also introduces a test which would have caught the issue.
2022-07-11 10:54:51 +01:00
5a4c35f627 FIX: Apply all watched words rules to user fields
Currently we only apply watched words of the `Block` type to custom user
fields and user profile fields.

This patch enables all rules to be applied such as `Censor` or
`Replace`.
2022-07-11 11:51:57 +02:00
3b4ed134ba DEV: Remove old hbs-in-script warning (#17418)
7 years, I think that's long enough for people to notice? 😉
2022-07-11 11:42:40 +02:00
e62730a4c8 FIX: Ensure splash screen <noscript> is loaded for legacy browsers (#17413)
Previously we would only expand the main `<noscript>` element for older browsers. This commit ensures that we expand all noscript elements on the page, including the one used by the splashscreen to hide itself on the no-js view.
2022-07-11 09:07:10 +01:00
a94dee31c4 DEV: Fix emoji-uploader tests (#17395) 2022-07-11 02:06:58 +02:00
25dacc08ce DEV: Update @ember/test-helpers (#17247) 2022-07-11 01:54:25 +02:00
06bcb27ea6 Build(deps): Bump rubocop-ast from 1.18.0 to 1.19.1 (#17416)
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast) from 1.18.0 to 1.19.1.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.18.0...v1.19.1)

---
updated-dependencies:
- dependency-name: rubocop-ast
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-11 01:52:59 +02:00
e5346ed84a Revert "DEV: Don't vendor old qunit css (#17410)" (#17417)
This reverts commit cf85ccca7d6a3db09a3ae11874489816717d3dfb.
2022-07-11 09:16:00 +10:00
cf85ccca7d DEV: Don't vendor old qunit css (#17410) 2022-07-10 14:57:22 +02:00
0d6929d935 DEV: Avoid triggering 404 errors in tests (#17404) 2022-07-10 11:09:13 +02:00
f19f804525 DEV: Don't try to vibrate in test mode (#17405)
It ends up just triggering an error:

```
[Intervention] Blocked call to navigator.vibrate because user hasn't tapped on the frame or any embedded frame yet: https://www.chromestatus.com/feature/5644273861001216.
```
2022-07-10 10:53:00 +02:00
9365d4e86a DEV: Fix test leakage/flakes (#17407)
Fixes failures like:

```
Unhandled request in test environment: /forum/topics/timings (POST)
```
2022-07-10 10:52:42 +02:00
8bf11ae0ce DEV: Move scripts into theme.html body (#17409)
They were incorrectly placed after the body
2022-07-10 10:52:29 +02:00
d5dc2496d4 DEV: Update qunit (#17411) 2022-07-10 10:52:14 +02:00