Alexander Skvortsov e3f051bf4b fix: return user when creating flags (#42) ...

Fixes https://github.com/flarum/QualityAssurance/issues/41

When the API response is ingested by `pushObject`, since the flag instance is new, there is nothing to merge with, and therefore, there's no user on the flag instance in the store. As a result, the flag is displayed with "deleted" as the creating user until a page refresh occurs.

More broadly, this could be fixed by either:
- Refactoring the JSON API layer so that all singular operations return the same set of includes.
- Merging the API Paylod with sent data on model save (for new instances only).
But the former would require a major breaking rewrite, and the latter could introduce potentially unwanted side effects, and is effectively a bandaid over inconsistent backend behavior.

2022-01-13 16:39:00 -05:00

extensions/flags

fix: return user when creating flags (#42)

2022-01-13 16:39:00 -05:00

Description

Simple forum software for building great communities.

communityflarumforumhacktoberfestjavascriptlaravelphp

166 MiB

Languages

PHP 60.5%

TypeScript 26.2%

JavaScript 7.9%

Less 4.4%

Blade 0.8%

Other 0.2%