hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always use format strings in dcb_printf

Browse Source 
The luafilter didn't use a format string with dcb_printf which can lead to
unexpected results if the returned string contains printf special
characters.
This commit is contained in:
Markus Makela
2016-11-03 08:37:24 +02:00
parent af65ee0ef9
commit 02d28a8d8d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
server/modules/filter/luafilter/luafilter.c
View File

@ -570,7 +570,7 @@ static void diagnostic(FILTER *instance, void *fsession, DCB *dcb)
lua_gettop(my_instance->global_lua_state); lua_gettop(my_instance->global_lua_state);
if (lua_isstring(my_instance->global_lua_state, -1)) if (lua_isstring(my_instance->global_lua_state, -1))
{ {
dcb_printf(dcb, lua_tostring(my_instance->global_lua_state, -1)); dcb_printf(dcb, "%s", lua_tostring(my_instance->global_lua_state, -1));
dcb_printf(dcb, "\n"); dcb_printf(dcb, "\n");
} }
} }