hcq/MaxScale
hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make private query_classifier functions static.

Browse Source 
parsing_info_init and parsing_info_done are only used by
query_classifier. Hence they should not be public and extern.
This commit is contained in:
Johan Wikman 2016-01-07 15:42:57 +02:00
parent d99cece151
commit 4b21154066
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
query_classifier/query_classifier.cc
View File

@ -70,7 +70,10 @@ static skygw_query_type_t resolve_query_type(THD* thd);
static bool skygw_stmt_causes_implicit_commit(LEX* lex, int* autocommit_stmt);
static int is_autocommit_stmt(LEX* lex);
static parsing_info_t* parsing_info_init(void (*donefun)(void *));
static void parsing_info_set_plain_str(void* ptr, char* str);
/** Free THD context and close MYSQL */
static void parsing_info_done(void* ptr);
static void* skygw_get_affected_tables(void* lexptr);
/**
@ -1462,7 +1465,7 @@ retblock:
*
* @return pointer to parsing information
*/
parsing_info_t* parsing_info_init(void (*donefun)(void *))
static parsing_info_t* parsing_info_init(void (*donefun)(void *))
{
parsing_info_t* pi = NULL;
MYSQL* mysql;
@ -1521,7 +1524,7 @@ retblock:
* @return void
*
*/
void parsing_info_done(void* ptr)
static void parsing_info_done(void* ptr)
{
parsing_info_t* pi;
THD* thd;

3
query_classifier/query_classifier.h
View File

@ -114,10 +114,7 @@ bool skygw_is_real_query(GWBUF* querybuf);
char** skygw_get_table_names(GWBUF* querybuf, int* tblsize, bool fullnames);
char* skygw_get_canonical(GWBUF* querybuf);
bool parse_query(GWBUF* querybuf);
parsing_info_t* parsing_info_init(void (*donefun)(void *));
/** Free THD context and close MYSQL */
void parsing_info_done(void* ptr);
bool query_is_parsed(GWBUF* buf);
bool skygw_query_has_clause(GWBUF* buf);
char* skygw_get_qtype_str(skygw_query_type_t qtype);