hcq/MaxScale
hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MXS-2090 Drop requirement that GTID based replication is used

Browse Source 
Drop the requirement that GTID based replication is used for
the BinLog Galera "failover" mechanism. There is no reason for
that restriction; it works just as well with file+position based
replication.
This commit is contained in:
Johan Wikman 2018-10-16 20:20:29 +03:00
parent 9e942f1a48
commit 8a0805d264
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
server/modules/routing/binlogrouter/blr_slave.cc
View File

@ -4579,22 +4579,6 @@ int blr_handle_change_master(ROUTER_INSTANCE* router,
return -1;
}
if (index != 0)
{
// Index 0 refers to the default configuration.
string use_gtid = router->configs[0].use_mariadb10_gtid;
if (use_gtid.empty() || (strcasecmp(use_gtid.c_str(), "slave_pos") != 0))
{
static const char MESSAGE[] =
"Secondary masters can only be used in conjunction with GTID based replication. "
"Specify MASTER_USE_GTID=Slave_pos for the default master connection.";
mxb_assert(sizeof(MESSAGE) <= BINLOG_ERROR_MSG_LEN);
strcpy(error, MESSAGE);
return -1;
}
}
std::vector<char> cmd_string(command, command + strlen(command) + 1); // Include the NULL
/* Parse SQL command and populate the change_master struct */