hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix coverity report of gwbitmask.c

Browse Source 
Buffer overrun. A byte is needed for the terminating null.
This commit is contained in:
Johan Wikman
2015-12-08 09:10:06 +02:00
parent dbc321df9b
commit a71cab166b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/core/gwbitmask.c
View File

@ -281,8 +281,8 @@ bitmask_copy(GWBITMASK *dest, GWBITMASK *src)
char *
bitmask_render_readable(GWBITMASK *bitmask)
{
char *toobig = "Bitmask is too large to render readable";
char *empty = "No bits are set";
static const char toobig[] = "Bitmask is too large to render readable";
static const char empty[] = "No bits are set";
char onebit[5];
char *result;
int count_set = 0;
@ -290,7 +290,7 @@ bitmask_render_readable(GWBITMASK *bitmask)
spinlock_acquire(&bitmask->lock);
if (999 < bitmask->length)
{
result = malloc(strlen(toobig));
result = malloc(sizeof(toobig));
if (result)
{
strcpy(result, toobig);
@ -318,7 +318,7 @@ bitmask_render_readable(GWBITMASK *bitmask)
}
else
{
result = malloc(strlen(empty));
result = malloc(sizeof(empty));
if (result)
{
strcpy(result, empty);