Move config_runtime.h and externcmd.h to core

+ some cleanup

include/maxscale/config.h

@@ -13,25 +13,16 @@
  */
 
 /**
- * @file config.h The configuration handling elements
+ * @file include/maxscale/config.h The configuration handling elements
  *
- * @verbatim
- * Revision History
- *
- * Date         Who                     Description
- * 21/06/13     Mark Riddoch            Initial implementation
- * 07/05/14     Massimiliano Pinto      Added version_string to global configuration
- * 23/05/14     Massimiliano Pinto      Added id to global configuration
- * 17/10/14     Mark Riddoch            Added poll tuning configuration parameters
- * 05/03/15     Massimiliano Pinto      Added sysname, release, sha1_mac to gateway struct
- *
- * @endverbatim
  */
 
 #include <maxscale/cdefs.h>
+
 #include <limits.h>
 #include <sys/utsname.h>
 #include <openssl/sha.h>
+
 #include <maxscale/ssl.h>
 #include <maxscale/modinfo.h>
 

server/core/config_runtime.c

@@ -10,17 +10,18 @@
  * of this software will be governed by version 2 or later of the General
  * Public License.
  */
+#include "maxscale/config_runtime.h"
 
 #include <strings.h>
+
 #include <maxscale/atomic.h>
-#include <maxscale/config_runtime.h>
 #include <maxscale/paths.h>
 #include <maxscale/spinlock.h>
 
 #include "maxscale/config.h"
-#include "maxscale/service.h"
 #include "maxscale/monitor.h"
 #include "maxscale/modules.h"
+#include "maxscale/service.h"
 
 static SPINLOCK crt_lock = SPINLOCK_INIT;
 

server/core/externcmd.c

@@ -11,9 +11,17 @@
  * Public License.
  */
 
-#include <maxscale/externcmd.h>
+#include "maxscale/externcmd.h"
+
 #include <ctype.h>
+#include <errno.h>
+#include <string.h>
+
 #include <maxscale/alloc.h>
+#include <maxscale/log_manager.h>
+#include <maxscale/pcre2.h>
+
+
 
 /**
  * Tokenize a string into arguments suitable for a execvp call.

server/core/maxscale/config_runtime.h

@@ -18,7 +18,6 @@
 
 #include <maxscale/cdefs.h>
 
-#include <maxscale/filter.h>
 #include <maxscale/monitor.h>
 #include <maxscale/server.h>
 #include <maxscale/service.h>

server/core/maxscale/externcmd.h

@@ -13,11 +13,8 @@
  */
 
 #include <maxscale/cdefs.h>
+
 #include <unistd.h>
-#include <string.h>
-#include <errno.h>
-#include <maxscale/log_manager.h>
-#include <maxscale/pcre2.h>
 
 MXS_BEGIN_DECLS
 

server/core/monitor.c

@@ -35,7 +35,6 @@
 
 #include <maxscale/alloc.h>
 #include <mysqld_error.h>
-#include <maxscale/externcmd.h>
 #include <maxscale/paths.h>
 #include <maxscale/log_manager.h>
 #include <maxscale/mysql_utils.h>
@@ -44,6 +43,7 @@
 #include <maxscale/spinlock.h>
 
 #include "maxscale/config.h"
+#include "maxscale/externcmd.h"
 #include "maxscale/monitor.h"
 #include "maxscale/modules.h"
 

server/modules/monitor/galeramon/galeramon.h

@@ -31,7 +31,6 @@
 #include <string.h>
 #include <maxscale/monitor.h>
 #include <maxscale/spinlock.h>
-#include <maxscale/externcmd.h>
 #include <maxscale/thread.h>
 #include <mysql.h>
 #include <mysqld_error.h>

server/modules/monitor/mmmon/mmmon.h

@@ -28,7 +28,6 @@
 #include <maxscale/dcb.h>
 #include <maxscale/modinfo.h>
 #include <maxscale/config.h>
-#include <maxscale/externcmd.h>
 
 /**
  * @file mmmon.h - The Multi-Master monitor

server/modules/monitor/mysqlmon.h

@@ -48,7 +48,6 @@
 #include <maxscale/dcb.h>
 #include <maxscale/modinfo.h>
 #include <maxscale/config.h>
-#include <maxscale/externcmd.h>
 #include <maxscale/hashtable.h>
 
 MXS_BEGIN_DECLS

server/modules/routing/debugcli/debugcmd.c

@@ -46,6 +46,7 @@
  *
  * @endverbatim
  */
+#include <maxscale/cdefs.h>
 
 #include <stdio.h>
 #include <stdlib.h>
@@ -71,10 +72,10 @@
 #include <maxscale/housekeeper.h>
 #include <maxscale/listmanager.h>
 #include <maxscale/maxscale.h>
-#include <maxscale/config_runtime.h>
 #include <maxscale/version.h>
 #include <maxscale/log_manager.h>
 
+#include "../../../core/maxscale/config_runtime.h"
 #include "../../../core/maxscale/modules.h"
 #include "../../../core/maxscale/monitor.h"
 #include "../../../core/maxscale/session.h"