hcq/MaxScale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TestMaxScalePCRE2: Fix memory leaks

Browse Source 
Not really leaks, but this reduces needless clutter in the valgrind
output.
This commit is contained in:
Esa Korhonen
2017-04-03 13:26:13 +03:00
parent 872f69b681
commit dca086571b
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
server/core/test/testmaxscalepcre2.c
View File

@ -89,11 +89,19 @@ static int test2()
test_assert(result == MXS_PCRE2_MATCH, "Substitution should substitute"); test_assert(result == MXS_PCRE2_MATCH, "Substitution should substitute");
test_assert(strcmp(dest, expected) == 0, "Replaced text should match expected text"); test_assert(strcmp(dest, expected) == 0, "Replaced text should match expected text");
size = 1000;
dest = MXS_REALLOC(dest, size);
result = mxs_pcre2_substitute(re2, subject, good_replace, &dest, &size); result = mxs_pcre2_substitute(re2, subject, good_replace, &dest, &size);
test_assert(result == MXS_PCRE2_NOMATCH, "Non-matching substitution should not substitute"); test_assert(result == MXS_PCRE2_NOMATCH, "Non-matching substitution should not substitute");
size = 1000;
dest = MXS_REALLOC(dest, size);
result = mxs_pcre2_substitute(re, subject, bad_replace, &dest, &size); result = mxs_pcre2_substitute(re, subject, bad_replace, &dest, &size);
test_assert(result == MXS_PCRE2_ERROR, "Bad substitution should return an error"); test_assert(result == MXS_PCRE2_ERROR, "Bad substitution should return an error");
MXS_FREE(dest);
pcre2_code_free(re);
pcre2_code_free(re2);
return 0; return 0;
} }