14450 Commits

Author SHA1 Message Date
Johan Wikman
05f71424e8 Fix masking_user test in 2.4
The very same user was used in both test-runs. How this could
ever have worked is a mystery to me.
2020-03-17 11:52:17 +02:00
Markus Mäkelä
9609f5d180
Revert "MXS-2920: Allow max_slave_replication_lag=0"
This reverts commit ca69da49911074a9d218f05936282fd72a674af5 and removes
the bug from the release notes.
2020-03-17 06:58:26 +02:00
Markus Mäkelä
f5b61e169b
Update npm packages
Updated packages due to npm audit warnings.
2020-03-16 11:32:43 +02:00
Johan Wikman
5217836e83 Update 2.4.8 Change Date
Same as that of 2.3.17. Consequently, only the 2.4 specific files
are updated.
2020-03-16 11:25:59 +02:00
Johan Wikman
d230336cfc Add 2.4.8 release notes and update change log 2020-03-16 11:24:58 +02:00
Markus Mäkelä
ca69da4991
MXS-2920: Allow max_slave_replication_lag=0
A requirement of no lag should be allowed. The reason why it wasn't was
simply due to the selection of the default value.
2020-03-13 13:23:47 +02:00
Markus Mäkelä
76e855dc1d
MXS-2919: Don't use slaves with unknown lag
If a limit on the replication lag is configured, servers with unmeasured
replication lag should not be used. The code in question did use them even
when a limit was set as the value used for undefined lag was -1 which
always measured lower than the limit.
2020-03-13 13:23:47 +02:00
Markus Mäkelä
2eeb583245
MXS-2921: Fix memory leak in alter maxscale
The alteration of core parameters leaked the JSON object.
2020-03-13 11:44:02 +02:00
Markus Mäkelä
291d2e987f
Improve charset selection
The charset sent in the handshake is now done with the following
priorities:

* First Master server
* Last Slave server
* First Running server or Down server whose charset is known

The change is that server in the Down state to which we've successfully
connected to can also be used as the charset source. This, in addition
with an "empty" default charset, helps avoid the use of the default latin1
charset unless absolutely necessary.
2020-03-12 11:03:04 +02:00
Markus Mäkelä
caf3b4cf75
Remove redundant call
The function was already called by mxs_mysql_real_connect.
2020-03-12 11:03:04 +02:00
Johan Wikman
d0ab797938 Merge branch '2.3' into 2.4 2020-03-12 10:33:57 +02:00
Johan Wikman
f0fd480237 Merge branch '2.3.18' into 2.3 2020-03-12 10:27:26 +02:00
Johan Wikman
7efdb5dd28 Update 2.3.18 release date 2020-03-12 10:20:54 +02:00
Johan Wikman
04533e6293 2.3.18 Create release notes and update change log 2020-03-12 10:20:54 +02:00
Timofey Turenko
09c8e7b29b create symlink also from sles to opensuse repos 2020-03-11 20:23:12 +02:00
Timofey Turenko
8b2c46991b Set cpu cores number to build VM and separate build and upgrade
VM should have 8 cores to make build faster in GCloud.
To get rid of ssfs between build hosts the build step
and upgrade test step are separated as well as
repository discriåtion generation
2020-03-11 19:00:27 +02:00
Timofey Turenko
a97973665a Merge branch '2.3' of github.com:mariadb-corporation/MaxScale into 2.3 2020-03-11 18:57:54 +02:00
Timofey Turenko
33ccc4687c Set cpu cores number to build VM and separate build and upgrade
VM should have 8 cores to make build faster in GCloud.
To get rid of ssfs between build hosts the build step
and upgrade test step are separated as well as
repository discriåtion generation
2020-03-11 18:50:53 +02:00
Johan Wikman
df18c1b2e8 Update maintenance version for 2.3 2020-03-10 15:09:29 +02:00
Markus Mäkelä
4d5d83da26
Merge branch '2.3' into 2.4 2020-03-10 14:30:48 +02:00
Markus Mäkelä
8e477b1650
Fix masking_user test
The test didn't exit with the return value of mysqltest.
2020-03-10 14:25:57 +02:00
Markus Mäkelä
6f018e752b
Process error events first
This prevents EPOLLOUT/EPOLLIN events from triggering confusing errors if
an EPOLLERR event happens at the same time.
2020-03-10 14:25:57 +02:00
Markus Mäkelä
38420c38b9
Upgrade to nodejs 6.17.1 2020-03-10 14:25:05 +02:00
Johan Wikman
e0cd6adb26 Update change date for 2.3.18 2020-03-10 10:45:47 +02:00
Johan Wikman
163a7b3b84 MXS-2917 Add missing destructors to sqlite rules (2.4) 2020-03-09 16:01:49 +02:00
Johan Wikman
55425b22ce Merge branch '2.3' into 2.4 2020-03-09 15:45:37 +02:00
Johan Wikman
8dd9a4ca27 MXS-2917 Add missing destructors to sqlite rules
Lemon (the sqlite parser generator) destructors are needed for
all rules that return dynamically allocated structures. Otherwise
there may be leaks if a statement is not completely parsed.
2020-03-09 15:24:20 +02:00
Markus Mäkelä
f7d502d1e1
Use json_object_set_new
The non-set case should only be used when a copy of an existing object is
needed. This fixes a memory leak in Cache::do_get_info.
2020-03-09 07:51:08 +02:00
Markus Mäkelä
6f45545e09
Fix call command memory leak
The module command arguments were never freed.
2020-03-09 07:38:53 +02:00
Markus Mäkelä
3da2580f09
Fix list modules memory leak
The wrong JSON function was used: the one without the _new suffix will
copy the memory.
2020-03-09 07:31:49 +02:00
Markus Mäkelä
2bb914b21e
Fix param_type_to_str
Duration wasn't in the switch. Removing the default case allows this to be
detected at compile time.
2020-03-09 07:23:52 +02:00
Markus Mäkelä
eb0432b7b2
MXS-2860: Extract socket error only when needed
As the process of extracting the socket error also resets it, it should be
done only when necessary.
2020-03-06 13:56:42 +02:00
Markus Mäkelä
318a81121b
Fix multi-host usage of maxctrl
The credentials weren't passed to all the hosts.
2020-03-06 13:23:55 +02:00
Markus Mäkelä
5b45796da4
Add missing maxctrl test cases
Code coverage revealed that some parts of the code could be easily
tested. Added these missing test cases and removed some dead code.
2020-03-05 21:13:39 +02:00
Markus Mäkelä
68c070c2c4
Update maxctrl packages
Updated packages to fix vulnerabilities reported by npm. The yargs package
was not updated as it introduces changes that aren't backwards compatible.
2020-03-05 21:13:39 +02:00
Markus Mäkelä
9eceeffc04
MXS-2811: Set TLS version with MARIADB_OPT_TLS_VERSION
The ssl_version values now also affect the TLS version used by the
connector.
2020-03-05 21:13:38 +02:00
Esa Korhonen
fda12c0cb2 Merge branch '2.3' into 2.4 2020-03-05 15:00:37 +02:00
Markus Mäkelä
6aab4ed416
MXS-2893: Fix parameter validation
The code assumed all parameters were string values. Encasing the code in a
try-catch block solves it.
2020-03-05 09:06:36 +02:00
Markus Mäkelä
1bf46fadf6
MXS-2891: Log password hash on mismatch
By logging the password hash when user authentication fails due to a
password mismatch, we can be certain what the client sent and what is the
currently stored value in MaxScale. This should not be on by default which
is why a new parameter is required.
2020-03-04 17:11:34 +02:00
Esa Korhonen
4a2d3dc55b MXS-2914 Link to pcre2 syntax page instead of API page
More appropriate link.
2020-03-04 16:38:18 +02:00
Johan Wikman
0aae500577 MXS-2898 Classify @@last_insert_id() and last_insert_id() identically
With this change, both 'SET @my_id = (SELECT LAST_INSERT_ID())' and
'SET @my_id = (SELECT @@LAST_INSERT_ID)' are classified as

QUERY_TYPE_MASTER_READ|QUERY_TYPE_SESSION_WRITE|QUERY_TYPE_USERVAR_WRITE

Earlier @@last_insert_id had the QUERY_TYPE_READ bit set as well, which
indirectly caused the problems of MXS-2898.
2020-03-04 13:18:09 +02:00
Johan Wikman
4c2909e86c MXS-2227 Fix problem, parse OPTIMIZE statements
OPTIMIZE [NO_WRITE_TO_BINLOG | LOCAL] TABLE
    tbl_name [, tbl_name] ...
    [WAIT n | NOWAIT]
2020-03-04 13:10:46 +02:00
Johan Wikman
3df8429db3 MXS-2227 Add test that reveals problem 2020-03-04 13:10:46 +02:00
Markus Mäkelä
fda3cf8160
Merge branch '2.3' into 2.4 2020-03-04 09:10:28 +02:00
Markus Mäkelä
61fc3d8a42
MXS-2907: Fix logrotate script
The SIGUSR1 isn't sent if the PID file is not found as that means MaxScale
is not running.
2020-03-04 09:07:50 +02:00
Markus Mäkelä
2f6d003491
MXS-2832: Document failover timing estimates
The worst-case time it takes for failover to start is now documented.
2020-03-04 08:49:03 +02:00
Johan Wikman
ee8e43f26b MXS-2508 Fix problem
DIV and MOD are now also accepted instead of / and % respectively.
MOD is a keyword but (in principle incorrectly) decays into an id
when used in some other context. That is so that it will be
parser by the general function rule ("id ( ... )"). If used
incorrectly, the server will later reject.
2020-03-03 11:30:58 +02:00
Johan Wikman
be3be3bf99 MXS-2508 Add test that reveals problem 2020-03-03 11:30:58 +02:00
Johan Wikman
f66d7ca838 MXS-2508 Fix qc_mysqlembedded
It appears that the function db_my_assert may be used but not
built into the library.

With 10.4.12 there seem to occasionally be superfluous empty
table names.
2020-03-03 11:30:58 +02:00
Markus Mäkelä
4a5293ebba
Merge branch '2.3' into 2.4 2020-03-02 18:05:11 +02:00