MassimilianoPinto
05fb07f996
Removed extra brace
...
Removed extra brace
2015-12-28 18:00:55 +01:00
MassimilianoPinto
4f8340f5b2
Changed behaviour for a slave requesting master_log_pos beyond binlog file size
...
Slave request for a log_pos behind binlog file size may result in a
disconnection or replication error:
if binlog file is latest one slave get disconnected otherwise an error
message is returned and replication stops
2015-12-28 18:00:52 +01:00
Markus Makela
aff3f66fa6
Fixed compilation error for slavelag.c
...
There was an extra parenthesis left when skygw_log_write was changed to
MXS_ERROR which caused the compilation to fail.
2015-12-23 06:45:28 +02:00
Markus Makela
3139be8e5a
Fixed SHOW SLAVE STATUS showing obsolete slaves
...
If SHOW SLAVE STATUS was executed after DISCONNECT ALL it was possible that
some of the disconnected slaves were used when printing slave hosts.
2015-12-10 15:50:20 +02:00
Markus Makela
000a044da6
Slaves are set to unregistered state once disconnected
...
It was possible that the same slave was disconnected multiple times
before the slave DCB was closed.
2015-12-10 15:50:20 +02:00
Markus Makela
9a3aae64ce
Replaced explicit closeSession calls with dcb_close
...
The closeSession entry point shouldn't be called directly and dcb_close
should be used instead.
2015-12-10 15:50:20 +02:00
Johan Wikman
49cf4089fc
Make state-change logging conditional.
2015-12-10 15:50:20 +02:00
Johan Wikman
f49bd06a7e
Reduce logging of binlog server
...
Only the true state changes of a slave - up-to-date -> catch-up
or catch-up to up-to-date - are logged.
2015-12-10 15:50:20 +02:00
MassimilianoPinto
43c5a495a2
Removed useless spaces
...
Removed useless spaces
2015-12-10 15:50:20 +02:00
MassimilianoPinto
3f31f5548d
Addition of slave transition to catchup mode in logging
...
Addition of slave transition to catchup mode in logging
2015-12-10 15:50:20 +02:00
Markus Makela
992d6fb3bc
Fix to MXS-501: Tee filter and USE ... no longer hangs
...
Some of the data was not reset for the branch session when a query
was not duplicated which could lead to a hang. Also the COM_FIELD_LIST
duplicated to the branch session even though it doesn't change the
session state.
2015-12-10 09:56:06 +02:00
Johan Wikman
5ebdd6f47d
Fix signed/unsigned problem in tee.c
2015-12-10 08:41:20 +02:00
Markus Makela
a663a8ec5c
Fix to MXS-500: Statement cloning is now properly handled
...
If a statement wasn't cloned for the Tee filter, the session would be closed
leading to a possible hang. Instead of closing the session when a statement
isn't cloned, it should not expect a response from that server for that statement.
2015-12-09 13:48:20 +02:00
Johan Wikman
231a620dc0
Remove >= 0 check from unsigned type.
2015-12-08 14:37:21 +02:00
Johan Wikman
1deea7f929
Remove unnecessary comparison.
...
It makes no sense to compare an unsigned integer for non-negativeness;
it won't ever be. router_instance.lastEventReceived is uint8_t.
On centos5 this causes a warning that thus ends the compilation.
2015-12-08 13:28:11 +02:00
Johan Wikman
edb3f3efd5
Fix coverity report of config.c
...
If pointer uninitialized there can be free of unallocated memory.
2015-12-08 10:28:31 +02:00
Johan Wikman
e3e8a59555
Allow hangup event also when EPOLLRDHUP is not available.
...
When generating a fake hangup event, EPOLLRDHUP is used if available,
otherwise EPOLLHUP. process_pollq(int) does the same thing both in the
case of EPOLLRDHUP and EPOLLHUP, so it seems this should work.
2015-12-08 10:14:10 +02:00
Johan Wikman
a71cab166b
Fix coverity report of gwbitmask.c
...
Buffer overrun. A byte is needed for the terminating null.
2015-12-08 09:33:04 +02:00
Johan Wikman
dbc321df9b
Fix coverity report of externcmd.c
...
Buffer overwrite.
2015-12-08 09:32:10 +02:00
Markus Makela
89bdf179b7
Added newlines at the end of all files
...
Some files were missing newlines as the last character in the file, causing
errors to appear on some systems.
2015-12-08 09:23:55 +02:00
Johan Wikman
6870d77acb
Fix set_user prototype.
2015-12-07 14:14:42 +02:00
Markus Makela
f62ff4c551
Fixed spelling mistake in usage output.
...
Path was spelled as apth.
2015-12-04 17:47:14 +02:00
Markus Makela
d6afe70c6f
Fix to MXS-323: Routers properly handle client DCB errors
...
All routers now detect if a client DCB is passed to handleError and
take the appropriate action.
2015-12-02 18:01:14 +02:00
Markus Makela
9da0c206bb
Added missing brackets
...
Some curly braces were missing from readconnroute and some function declarations
were misaligned.
2015-12-02 13:36:18 +02:00
Markus Makela
45abfeec2c
Fix to MXS-494: Fixed readconnroute weight calculation
...
The calculation of weights used the actual amount of connections instead of
actual amount of connections + 1. This lead to the weight being effectively
ignored for servers with no connections.
2015-12-02 13:36:18 +02:00
Markus Makela
91eba965fc
Formatted readconnroute
...
Formatted readconnroute files according to the style guide.
2015-12-02 13:36:18 +02:00
MassimilianoPinto
7119ed817d
Transaction safety default is off in binlog router
...
Transaction safety default is off in binlog router
2015-12-02 11:18:12 +01:00
counterpoint
d054cb1595
Correct logic errors in bitmask_set and extend initial/increment size to reduce likelihood of any risk of realloc failure.
2015-12-01 15:16:12 +00:00
Markus Makela
2e127ef38e
Fix to MXS-429: Missing parameter no longer causes a crash
...
If a server is missing a weighting parameter the default weight will be used.
2015-12-01 12:22:47 +02:00
MassimilianoPinto
1c1d4b205a
Merge branch '1.2.1-binlog_router_trx' into develop
2015-12-01 09:37:47 +01:00
Johan Wikman
74bb291961
Reindent server/core/monitor.c
2015-12-01 09:40:07 +02:00
Johan Wikman
b2dd24ada3
Reindent server/core/utils.c
2015-12-01 09:32:31 +02:00
Johan Wikman
fbecf128dd
Reindent server/core/users.c
2015-12-01 09:29:52 +02:00
Johan Wikman
8bbc3e8086
Reindent server/core/thread.c
2015-12-01 09:29:03 +02:00
Johan Wikman
a95be21266
Reindent of server/core/spinlock.c
2015-12-01 09:28:19 +02:00
Johan Wikman
15df33a93f
Reindent server/core/session.c
2015-12-01 09:26:26 +02:00
Johan Wikman
8601068dc2
Reindent server/core/service.c
2015-11-30 21:25:10 +02:00
MassimilianoPinto
6367ac7148
Changed log level for up to date transition
...
Changed log level for up to date transition
2015-11-30 19:23:36 +01:00
Johan Wikman
ed06d4f14c
Reindent server/core/server.c
2015-11-30 19:47:29 +02:00
Markus Makela
02da87f737
Fix to MXS-439: Weightby value of 0 no longer causes a crash
...
A weightby parameter with a value of 0 no longer causes SIGFPE and the
invalid weight value is set to the correct value of 1.
2015-11-30 19:06:04 +02:00
Johan Wikman
0aa38cad4c
Reindented server/core/resultset.c
2015-11-30 18:58:43 +02:00
Johan Wikman
6c401b9085
Reindent server/core/poll.c
2015-11-30 18:57:19 +02:00
Johan Wikman
c0615408aa
Reindented server/core/modutil.c
2015-11-30 18:53:42 +02:00
Johan Wikman
17eb80072f
Reindent server/core/secrets.c
2015-11-30 18:48:14 +02:00
Johan Wikman
233f50f3e6
Reindent server/core/random_jkiss.c
2015-11-30 16:04:18 +02:00
Johan Wikman
72dd159f98
Reindented server/core/memlog.c
2015-11-30 15:18:51 +02:00
Johan Wikman
60fb05ea40
Reindented server/core/load_utils.c
2015-11-30 15:17:36 +02:00
Johan Wikman
3189a47fc5
Reindented server/core/housekeeper.c
2015-11-30 15:16:44 +02:00
Johan Wikman
486f724dc1
Reindented server/core/hint.c
2015-11-30 14:10:15 +02:00
Johan Wikman
255a5b53c1
Reindented server/core/hashtable.c
2015-11-30 13:54:46 +02:00
