2231d0870c
Place checks in callback routines because DCB will not always contain a reference to a router session, and the associated data will be invalid in this case.
2015-09-25 12:17:18 +01:00
2dfb9e3c11
Merge branch 'develop' into MXS-329
2015-09-24 17:59:36 +03:00
2f0ef4ad31
Configuration files from older installations no longer overwrite existing files.
2015-09-24 14:39:21 +03:00
89667294b3
Fix exceptional cases in DCB dcb_call_callback and in MySQL backend gw_error_backend_event - close DCB and return.
2015-09-24 07:39:47 +01:00
6a318836fb
Removed obsolete code.
...
The read and write buffers are now emptied in dcb_final_free, so
no need to do it explicitly here.
2015-09-23 15:16:19 +03:00
3b19acd1de
Write queue emptied in dcb_final_free.
...
NOTE: Invalid indentation for reduced conflicts with MXS-329.
2015-09-23 15:16:19 +03:00
f7946a05fa
Fix in extract_message
...
Fix in extract_message
2015-09-23 14:05:02 +02:00
618a641b96
Reformatted user authentication queries as multi-line strings instead of one long string.
2015-09-23 08:00:58 +03:00
95a4daecc9
Add GWBUF_POINTER_IN_BUFFER macro; add extra free calls to remove memory leaks.
2015-09-22 11:54:47 +01:00
065e252767
Removed redundant text from documentation.
2015-09-22 07:36:26 +03:00
15f042f083
On reflection, freeing keys and values in hashtable processing is not a good idea because we don't know what they are, and can put up with some small memory losses.
2015-09-21 15:49:57 +01:00
338b870cd1
Fix to MXS-373: https://mariadb.atlassian.net/browse/MXS-373
...
The log manager is initialized only once and skygw_log_sync_all now checks if the log manager has been successfully started before interacting with the log manager
2015-09-21 17:27:49 +03:00
7aa36b77ea
Guarantee router session is present for call to clientReply; properly free callbacks; attempt to set all necessary values for dbusers; do more to ensure buffers freed.
2015-09-21 14:25:12 +01:00
11c8ef5b92
Cleaned up code based on the review of the code.
2015-09-21 14:02:01 +03:00
988a8d7008
Fixed error messages not being printed and cleaned up the function.
2015-09-21 14:02:01 +03:00
561891aac5
Fix for double free, possible fix for bug601.
...
In the end of execute_sescmd_in_backend the buffer was consumed
in case the protocol function failed. Or actually if it returned
something else but 1.
In the case of mysql_backend, the buffer is always freed when
authorizing and either consumed or placed on the dcb writequeue
when the data is written.
That is, it is never ok to consume the buffer in this function.
The end-result is likely to be an abort.
2015-09-21 13:45:15 +03:00
88716c35fb
Various changes to block loopholes in different cases and tidy up.
2015-09-21 09:23:22 +01:00
de8e54da8b
Fix for compile error
...
Fix for compile error
2015-09-21 09:00:39 +02:00
2c12ba3d16
Various fixes
...
Various fixes for initialisation and packet size allocation
2015-09-21 09:00:20 +02:00
601eac5a5d
Fixed parent-child code being called in non-daemon mode.
2015-09-18 17:26:27 +03:00
8d5ca11374
Fixed: spinlock_release is before free
...
Fixed: spinlock_release is before free
2015-09-18 16:05:22 +02:00
67c9f30632
Added missing NULL byte for resource
...
Added missing NULL byte for resource
2015-09-18 15:27:36 +02:00
b8af047a25
Remove excessively tight conditions for selecting persistent connections, add more information to debug output when connection is rejected.
2015-09-18 11:03:23 +01:00
2a2582067a
Added fix blr_slave_register reply
...
Added fix blr_slave_register reply
2015-09-18 11:06:03 +02:00
e507933c48
Need to mark the DCB dcb_errhandle_called indicator if the router error handler is not called.
2015-09-18 09:19:32 +01:00
f3560512ff
Suppress call to router error handling where there is no router session.
2015-09-18 09:04:32 +01:00
c69658889c
Handle client input case where no router session exists by sending error message to client.
2015-09-18 08:59:06 +01:00
d192cee0a1
Fixed Log message to 2015
...
Fixed Log message to 2015
2015-09-18 09:49:22 +02:00
31c6666278
Ensure DCB for closing session does not become persistent; remove bref_was_not_in_use.
2015-09-17 14:38:56 +01:00
dc3b0b067b
Revert the dcb_close changes in handleError.
2015-09-17 13:35:18 +01:00
1ad8e27c91
Try a different arrangement of DCB closures in handleError of read-write split.
2015-09-17 13:27:25 +01:00
357c4bcae5
Add to or take from persistent pool only if server is running; add conditions to DCB close in read-write handleError to check backend reference was in use.
2015-09-17 12:53:59 +01:00
583c9b62fe
Close DCB in handleError only if it can be found in a backend reference.
2015-09-17 11:58:19 +01:00
91dd3bb9bd
Fix mistake.
2015-09-17 08:18:47 +01:00
0cba9b797f
Changes to deal with failed session creation by keeping the new session in existence until all related DCBs have closed; minor changes in response to reviews.
2015-09-17 08:15:32 +01:00
11c75a1ee0
Merge branch 'dcb_ssl_refactoring' into develop
2015-09-17 07:22:23 +03:00
6ad89cb986
Removed boolean value assignment to an integer variable.
2015-09-16 13:36:33 +03:00
6c75e09f29
Fixed multi-source replication not working.
2015-09-16 11:54:56 +03:00
ea2c454010
Minor modification to documentation.
2015-09-16 11:19:20 +03:00
fe400e7041
Fixed service permission checks failing without SELECT privilege on mysql.db for the servuce user.
2015-09-16 11:10:24 +03:00
5aa882fc7e
Made documentation cleaner.
2015-09-16 10:24:17 +03:00
fe9babe9ec
Cleaned up code.
2015-09-16 10:22:29 +03:00
87b50ac337
Merge branch 'MXS-279' into develop
2015-09-16 10:01:21 +03:00
30239f395a
Fix bref when backend server fails, error message if fails.
2015-09-15 20:07:56 +01:00
fdbe070e80
Change abort to error message when read connection router finds mismatch between router client session DCB and given backend DCB; improve order of actions when closing DCB in read-write router.
2015-09-15 15:22:44 +01:00
8a996029bc
Merge branch 'MXS-35' into develop
2015-09-15 11:50:36 +03:00
bbc0116cd2
Moved the writing to and closing of the parent-child pipe to a separate function.
2015-09-15 10:52:37 +03:00
0cf4b2cf68
Fix to overcome failure on certain packets.
2015-09-15 08:37:41 +01:00
2829a8ce05
Added missing check for empty result set in binlogrouter.
2015-09-14 21:20:22 +03:00
e443351341
Fix to MXS-279: https://mariadb.atlassian.net/browse/MXS-279
...
Added NULL checks to block buffer initialization and checks for return values to functions that use it.
2015-09-14 16:29:14 +03:00
