2231d0870c
Place checks in callback routines because DCB will not always contain a reference to a router session, and the associated data will be invalid in this case.
2015-09-25 12:17:18 +01:00
2dfb9e3c11
Merge branch 'develop' into MXS-329
2015-09-24 17:59:36 +03:00
89667294b3
Fix exceptional cases in DCB dcb_call_callback and in MySQL backend gw_error_backend_event - close DCB and return.
2015-09-24 07:39:47 +01:00
6a318836fb
Removed obsolete code.
...
The read and write buffers are now emptied in dcb_final_free, so
no need to do it explicitly here.
2015-09-23 15:16:19 +03:00
f7946a05fa
Fix in extract_message
...
Fix in extract_message
2015-09-23 14:05:02 +02:00
95a4daecc9
Add GWBUF_POINTER_IN_BUFFER macro; add extra free calls to remove memory leaks.
2015-09-22 11:54:47 +01:00
7aa36b77ea
Guarantee router session is present for call to clientReply; properly free callbacks; attempt to set all necessary values for dbusers; do more to ensure buffers freed.
2015-09-21 14:25:12 +01:00
11c8ef5b92
Cleaned up code based on the review of the code.
2015-09-21 14:02:01 +03:00
988a8d7008
Fixed error messages not being printed and cleaned up the function.
2015-09-21 14:02:01 +03:00
561891aac5
Fix for double free, possible fix for bug601.
...
In the end of execute_sescmd_in_backend the buffer was consumed
in case the protocol function failed. Or actually if it returned
something else but 1.
In the case of mysql_backend, the buffer is always freed when
authorizing and either consumed or placed on the dcb writequeue
when the data is written.
That is, it is never ok to consume the buffer in this function.
The end-result is likely to be an abort.
2015-09-21 13:45:15 +03:00
88716c35fb
Various changes to block loopholes in different cases and tidy up.
2015-09-21 09:23:22 +01:00
de8e54da8b
Fix for compile error
...
Fix for compile error
2015-09-21 09:00:39 +02:00
2c12ba3d16
Various fixes
...
Various fixes for initialisation and packet size allocation
2015-09-21 09:00:20 +02:00
8d5ca11374
Fixed: spinlock_release is before free
...
Fixed: spinlock_release is before free
2015-09-18 16:05:22 +02:00
2a2582067a
Added fix blr_slave_register reply
...
Added fix blr_slave_register reply
2015-09-18 11:06:03 +02:00
e507933c48
Need to mark the DCB dcb_errhandle_called indicator if the router error handler is not called.
2015-09-18 09:19:32 +01:00
f3560512ff
Suppress call to router error handling where there is no router session.
2015-09-18 09:04:32 +01:00
c69658889c
Handle client input case where no router session exists by sending error message to client.
2015-09-18 08:59:06 +01:00
31c6666278
Ensure DCB for closing session does not become persistent; remove bref_was_not_in_use.
2015-09-17 14:38:56 +01:00
dc3b0b067b
Revert the dcb_close changes in handleError.
2015-09-17 13:35:18 +01:00
1ad8e27c91
Try a different arrangement of DCB closures in handleError of read-write split.
2015-09-17 13:27:25 +01:00
357c4bcae5
Add to or take from persistent pool only if server is running; add conditions to DCB close in read-write handleError to check backend reference was in use.
2015-09-17 12:53:59 +01:00
583c9b62fe
Close DCB in handleError only if it can be found in a backend reference.
2015-09-17 11:58:19 +01:00
0cba9b797f
Changes to deal with failed session creation by keeping the new session in existence until all related DCBs have closed; minor changes in response to reviews.
2015-09-17 08:15:32 +01:00
6ad89cb986
Removed boolean value assignment to an integer variable.
2015-09-16 13:36:33 +03:00
6c75e09f29
Fixed multi-source replication not working.
2015-09-16 11:54:56 +03:00
30239f395a
Fix bref when backend server fails, error message if fails.
2015-09-15 20:07:56 +01:00
fdbe070e80
Change abort to error message when read connection router finds mismatch between router client session DCB and given backend DCB; improve order of actions when closing DCB in read-write router.
2015-09-15 15:22:44 +01:00
0cf4b2cf68
Fix to overcome failure on certain packets.
2015-09-15 08:37:41 +01:00
2829a8ce05
Added missing check for empty result set in binlogrouter.
2015-09-14 21:20:22 +03:00
955974d06b
Removed unused XID var
...
Removed unused XID var
2015-09-14 09:43:13 +02:00
bb72b0c892
Fixed compiler warnings.
2015-09-12 04:46:47 +03:00
3b0b740e47
Fixed monitor scripts and added extra logging.
2015-09-11 18:49:20 +03:00
743fb5774b
Improved logging.
2015-09-11 18:49:20 +03:00
535523f9d7
Added an upper limit to trace log message length for queries.
2015-09-11 14:29:58 +03:00
9fda8dcc26
Changed link order.
...
Did not link on Ubuntu.
2015-09-11 13:57:24 +03:00
7d00a3670d
Addition of maxbinlogcheck, a new utility in bin
...
Addition of maxbinlogcheck, a new utility in bin
2015-09-10 14:37:49 +02:00
cfeaf7d6e9
Merge remote-tracking branch 'origin/develop' into MXS-329
...
Conflicts:
server/core/session.c
2015-09-10 13:07:27 +01:00
296e306daa
Set session pointer to client dcb to null when dcb is closed.
2015-09-10 12:54:44 +01:00
9f01d0ec3f
Fix type.
2015-09-10 10:54:33 +01:00
67f8520c38
Added missing include to sharding_common.h
2015-09-09 13:00:10 +03:00
f6916a23bd
Move responsibility for closing DCB on error to router error handling. Check that routers remove or disable links to closed DCB.
2015-09-09 09:33:00 +01:00
2e50dfd484
Readjust indentation in handleError function of read connection router.
2015-09-09 08:37:40 +01:00
986c918d52
Remove ERRACT_RESET action from router error handler; remove sole call from mysql_client. Correct comments on parameters for router error handlers.
2015-09-09 08:31:59 +01:00
160bbb70ee
MXS-251: strerror
...
Replaces all calls to strerror with calls to strerror_r. The former
is non-thread safe while the latter is.
2015-09-05 15:52:13 +03:00
4a1ad3df69
Attempt solution to crash caused by leaving link to backend DCB in router session.
2015-09-05 08:53:19 +01:00
d74990833b
Move capture of user name for persistent connections; expand error message in mysql client to give more information.
2015-09-01 09:59:34 +01:00
c564b40c54
Fixed gw_send_authentication_to_backend expecting a negative return value when dcb_write fails.
2015-08-31 10:23:51 +03:00
b6f5108d29
Fix for MXS-335
...
Response handling as aborted if there is not enough data.
2015-08-31 08:30:21 +03:00
a711b25fec
Improve user name setting in DCB for persistent connections and to fix bug; change name of session_alloc_dummy to session_set_dummy to be more informative.
2015-08-28 18:20:32 +01:00
