14632 Commits

Author SHA1 Message Date
Johan Wikman
44c04a5d44 2.4 Update maintenance release number 2020-07-07 10:06:36 +03:00
Johan Wikman
fc9c9fcd77 2.4.11 Update change date 2020-07-07 10:01:38 +03:00
Johan Wikman
4c1b42b9cd 2.4.11 Add release notes and update change log 2020-07-07 09:40:51 +03:00
Markus Mäkelä
32fa7b6800
MXS-3069: Fix plugin name comparison
Connectors that wouldn't send the plugin name even when the plugin
authentication capability was enabled would have to do an extra step in
the authentication.
2020-07-07 09:23:23 +03:00
Markus Mäkelä
6c9249131f
MXS-3064: Use latin1 charset
This prevents the server from selecting the charset under which the
queries are processed which can result in conflicts if the tables used are
not compatible with the charset of the string literals used in the query.
2020-07-07 09:23:22 +03:00
Markus Mäkelä
4fe71b41ed
MXS-3038: Don't connect to lagging slaves
There's no use connecting to a lagging slave if a replication lag limit
has been set.
2020-07-07 09:23:22 +03:00
Markus Mäkelä
9e91cfdded
MXS-3039: Document qlafilter log rotation
The interaction with the log rotation in MaxScale was not documented.
2020-07-07 09:23:22 +03:00
Markus Mäkelä
7520efd218
MXS-3059: Don't use STL containers concurrently
The diagnostics_json call could access the std::unordered_map at the same
time it was being updated by the monitoring thread. This leads to
undefined behavior which in the case of MXS-3059 manifested as a segfault.
2020-07-07 09:23:22 +03:00
Markus Mäkelä
ad4bd26ff0
MXS-2585: Check for failed allocations
Since nothrow was used, the return value should be checked. By moving the
null-check after the node allocation part, we'll detect it.
2020-07-07 09:23:22 +03:00
Markus Mäkelä
ba289dc589
Fix debug assertion in cache
The call to gwbuf_length will fail if the pointed to buffer isn't the head
of the chain. To prevent this, the length is calculated before the buffer
is appended.

Also fixed the use of gwbuf_append. The return value should be assigned
and the code shouldn't reply on the value passed to the function being
correct.
2020-07-07 09:23:22 +03:00
Markus Mäkelä
7ad3485892
MXS-3054: Fix crash on malformed mapping reply
The code used a null GWBUF with gwbuf_append which causes a crash. The
return value of the function that used it was also not correctly handled
and would be mistaken for a different error.
2020-07-02 11:34:40 +03:00
Markus Mäkelä
608eb95284
MXS-3055: Prevent sending of an extra COM_QUIT
If the protocol routes a COM_QUIT packet to the backend, it must not
generate a packet when it is shutting down. This could cause unexpected
write errors if the backend server managed to close the socket before the
write was done.
2020-07-02 11:34:40 +03:00
Markus Mäkelä
a655c5d08c
MXS-619: Allow backend authentication to complete
By deferring the closing of a DCB until the protocol tells that it's in a
stable state, we avoid closing the connection mid-authentication. This
makes sure that all connections have reached a stable state before they
are closed which in turn prevents the connections from counting towards
aborted connects (or failed authentications like it did with the old fix).
2020-07-02 11:34:39 +03:00
Markus Mäkelä
ae2cad9254
MXS-619: Revert the partial fix
The fix causes a lot of confusion with the failed authentication messages
and is not worth it to fix the problem.
2020-07-02 11:22:22 +03:00
Markus Mäkelä
1ad8ae97d3
MXS-3054: Prevent pooling of DCBs with inbound data
If a DCB is expecting a response from the server, it must not be placed
into the connection pool. This prevents the case where unexpected
responses would be delivered to DCBs taken out of the connection pool.
2020-07-02 11:22:22 +03:00
Markus Mäkelä
9f07613330
Merge branch '2.3' into 2.4 2020-07-02 10:38:54 +03:00
Markus Mäkelä
c9badcb09c
Fix installation order of signal handlers
The shutdown signal handlers were installed before the workers were
initialized and weren't removed before the workers were deleted. This
would lead to a debug assertion and an eventual crash when a SIGTERM
signal was received outside of the expected scope.

The proper way to do this is to install the handlers only after the system
is up and running and to disable them as soon as the shutdown process
starts.

This mostly happened with the mxs621_unreadable_cnf test as it seemed to
receive a SIGTERM during the execution of the at-exit handlers.
2020-07-02 10:33:18 +03:00
Markus Mäkelä
637bc6ff6d
Silence test errors about missing cores
`cp` and `ls` complain if the files do not exist, using `test` is more
appropriate to test whether the files exist.
2020-07-02 06:26:35 +03:00
Markus Mäkelä
1756857f5d
Fix galera initialization with 10.4
For whatever reason, galera complains on startup about
wsrep_cluster_address missing even when mysql_install_db is run. By making
sure that we configure it before we initialize the database, the problems
seem to go away.
2020-07-01 15:15:15 +03:00
Markus Mäkelä
31591dbf00
MXS-3057: Fix session_trace
The log priority check must not check session trace as it is used inside
the logging code.
2020-07-01 11:12:32 +03:00
Esa Korhonen
564f16e0e2 MXS-2900 Move common mariadbmonitor test source files 2020-06-23 15:22:41 +03:00
Johan Wikman
e1363cee9f MXS-3020 Remove links to removed documents
The documents themselves were removed by MXS-2944, so the links
should not be there. Their presence will also prevent the documents
from being removed in KB.
2020-06-23 14:56:47 +03:00
Esa Korhonen
680ba80870 MXS-2900 maxtest includes cleanup, part 3 2020-06-23 13:23:02 +03:00
Esa Korhonen
238725b72e MXS-2900 maxtest includes cleanup, part 2 2020-06-23 13:23:01 +03:00
Esa Korhonen
9951d27762 MXS-2900 maxtest includes cleanup 2020-06-23 13:23:01 +03:00
Johan Wikman
31eade1a75 Merge branch '2.3' into 2.4 2020-06-18 11:58:38 +03:00
Johan Wikman
c2c0b4ef60 Merge branch '2.3' into 2.4 2020-06-18 11:43:01 +03:00
Johan Wikman
9fb5336615 MXS-2996 Fix classification of "SELECT ... LOCK IN SHARE MODE"
And also of "SELECT ... FOR SHARE"
2020-06-18 10:17:08 +03:00
Johan Wikman
1dd06c3ebc MXS-2996 Add test that reveals problem
SELECT * FROM test LOCK IN SHARE MODE
  SELECT * FROM test FOR SHARE

should be classified as QUERY_TYPE_WRITE.
2020-06-18 10:14:16 +03:00
Johan Wikman
3972e372ae MXS-3041 Fix 'SELECT handler FROM t FOR UPDATE'
Problem was that 'handler' is a keyword. To make it work,
the keyword must be listed as one of those that turns into
an id where it cannot be used as a keyword.
2020-06-18 08:40:22 +03:00
Johan Wikman
f96c8d3a97 MXS-3041 Add test that reveals problem 2020-06-18 08:35:33 +03:00
Esa Korhonen
c8700a94ab MXS-2900 Cleanup maxtest compilation
The cdc-connector source does not need to be included, linking is enough.
2020-06-12 20:08:40 +03:00
Esa Korhonen
63d1f66797 MXS-2900 Include from predefined search directories in maxtest
Similar style is used in other MaxScale libraries.
2020-06-12 19:26:47 +03:00
Esa Korhonen
3c0021828c MXS-2900 Remove StopWatch from maxtest
Was similar to the one in maxbase. Also changes a variable name
inside a macro to less likely shadow one in surrounding scope.
2020-06-12 19:26:02 +03:00
Johan Wikman
a4a7a52150 Merge branch '2.4.10' into 2.4 2020-06-08 11:40:41 +03:00
Johan Wikman
5793c53916 2.4 Bump maintenance release 2020-06-08 11:40:09 +03:00
Johan Wikman
8799bbbb95 2.4.10 Update release date 2020-06-08 10:50:32 +03:00
Esa Korhonen
098ffde13c Remove obsolete debug assert from PamAuth
Would be always hit in debug mode.
2020-06-05 19:04:44 +03:00
Johan Wikman
7781f7042a 2.4.10 Update change date 2020-06-05 10:21:37 +03:00
Johan Wikman
a1a4834182 2.4.10 Add release notes and update change log 2020-06-05 10:11:26 +03:00
Johan Wikman
5ebae9be90 Merge branch '2.3' into 2.4 2020-06-05 09:36:24 +03:00
Johan Wikman
d78aa39765 Update release date 2020-06-05 09:31:45 +03:00
Johan Wikman
ddb4064563 Fix typo in documentation 2020-06-05 09:31:45 +03:00
Johan Wikman
aa11c960b1 2.3.20 Update change date 2020-06-05 09:31:45 +03:00
Johan Wikman
dcf0442127 2.3.20 Add release notes and update change log 2020-06-05 09:31:44 +03:00
Markus Mäkelä
00e5cbf51c
Merge branch '2.3' into 2.4 2020-06-05 08:36:07 +03:00
Markus Mäkelä
d025f5123e
MXS-3023: Fix ID generator overflow
The result must always be non-negative.
2020-06-04 15:31:17 +03:00
Markus Mäkelä
a8c8531bbc
MXS-3021: Add test case for strict
Checks that multi-statements are allowed and that rules that match still
cause queries to be blocked.
2020-06-04 08:28:32 +03:00
Markus Mäkelä
da5af75c1c
MXS-3021: Make strictness of dbfwfilter configurable
In some cases the dbfwfilter is too strict and SQL that would not match a
rule is blocked due to it not being fully parsed. To allow a more lenient
mode of operation, the requirement for full parsing must be made
configurable.
2020-06-04 08:28:23 +03:00
Markus Mäkelä
ac1e2d4202
Merge branch '2.3' into 2.4 2020-06-03 10:40:24 +03:00