11682 Commits

Author SHA1 Message Date
Markus Mäkelä
4e41978069
Merge branch '2.2' into develop 2018-09-14 10:41:43 +03:00
Markus Mäkelä
c600b8ab92
MXS-2046: Fix double freeing of GWBUF
The response buffer from the master was freed twice.
2018-09-13 20:38:55 +03:00
Markus Mäkelä
5e6abe71f1
Fix local_address
The test did not create a grant for the gateway IP address where the
client was connecting from.
2018-09-13 15:36:31 +03:00
Markus Mäkelä
bee7cc2002
MXS-2046: Fix additional memory leaks
A set of memory leaks were revealed by Valgrind.
2018-09-13 14:27:21 +03:00
Esa Korhonen
8c561c6e55 Merge branch '2.2' into develop 2018-09-13 12:26:58 +02:00
Markus Mäkelä
ce602daf10
Enable log_info for bug664 2018-09-13 13:14:28 +03:00
Markus Mäkelä
fa96923983
MXS-2035: Add mariabackup support to Galeramon
The mariabackup is now treated the same way as xtrabackup.
2018-09-13 13:02:32 +03:00
Markus Mäkelä
a952255c19
MXS-2046: Fix binlogrouter memory leak
The client queries were never freed.
2018-09-13 13:02:31 +03:00
Esa Korhonen
b3d6e49061 Shorten mysqlmon_failover_stress
The test fails since slaves are constantly going out-of-sync and cannot rejoin
the cluster. After three failovers, the cluster has three standalone server and
the monitor gets confused which server is the master. For now, limit the test to
two failovers.
2018-09-13 11:33:19 +03:00
Esa Korhonen
d65d815b99 Add format attribute to test functions, fix resulting errors
Fixes mysqlmon_failover_stress.
2018-09-13 11:33:19 +03:00
Markus Mäkelä
7ec2f77708
Merge branch '2.2' into develop 2018-09-12 23:18:08 +03:00
Markus Mäkelä
e1f2b81734
Wait for monitor in bug547
The test expects the monitor to respond within 5 seconds. This is not
guaranteed to happen so waiting for a monitor interval instead of a
hard-coded duration provides for a more stable test.
2018-09-12 22:09:51 +03:00
Markus Mäkelä
b3e2bf58d9
Wait two monitor intervals in mysqlmon_failover_auto
The master failover require two monitor intervals to complete.
2018-09-12 22:09:51 +03:00
Markus Mäkelä
6f5d089131
Use expect in mxs1947_composite_roles
`assert` was renamed to `expect`.
2018-09-12 22:09:38 +03:00
Markus Mäkelä
96a78685bc
Fix possible buffer overrun in readwritesplit
If the GWBUF length was larger than the stack buffer length, the code
would write past the buffer.
2018-09-12 22:09:38 +03:00
Markus Mäkelä
f6840fbded
Remove implicit initialization of all maxscales
The extra maxscale instances are only started if the test explicitly
requests it.
2018-09-12 22:09:38 +03:00
Markus Mäkelä
643480240c
Simplify MaxCtrl version extraction
Instead of using the correct version in in-source builds, a dummy file is
copied in place. This removes the need to explicitly include the
VERSION.cmake file.
2018-09-12 22:09:37 +03:00
Marko
077f344a20 MXS-2037 Add test case 2018-09-12 20:59:47 +03:00
Johan Wikman
12092d1a90 test_cycle_find.cc: Initialize the log 2018-09-12 14:23:09 +03:00
Markus Mäkelä
1bffb1c26d
Fix release note generation script
The CMake command that reads the VERSION.cmake file needs to be executed
in the source root.
2018-09-12 11:05:17 +03:00
Johan Wikman
d04c7135b0 Update change log and release notes 2018-09-12 09:43:36 +03:00
Johan Wikman
d881630204 Allow programatic control of galera restarting
If a test program needs other than the default Galera config
(e.g. log_slave_updates enabled), then it should be able to
programmatically cause galera to be restarted as part of the
TestConnections construction.
2018-09-12 09:09:52 +03:00
Markus Mäkelä
9b0f016aba
Fix minor formatting oversights
Code that was not formatted was merged into develop unformatted.
2018-09-12 08:58:15 +03:00
Markus Mäkelä
65c50ca8b7
Fix uncrustify script
Add explicit path to the root source directory and allow invocation from
other directories. Also included qc_sqlite sources but excluded the SQLite
sources. Explicitly define the configuration in the MaxScale sources as
the one that will be used.

Changed from N invocations of uncrustify to one invocation with all files
as the program arguments. This should give a slight speedup when
formatting all sources.
2018-09-12 08:58:15 +03:00
Markus Mäkelä
d7b7f43efb
Rename misleading function
The expecting resultset function does not expect a resultset but a text
protocol result.
2018-09-12 08:44:31 +03:00
Markus Mäkelä
e15b0e2147
MXS-2041: Fix crash on failed schemarouter session
When the setting up of filters for a session fails, the DCB is closed and
the client DCB's session pointer is set to NULL. This needs to be checked
in the schemarouter before the `m_client->session` pointer is used.

The act of setting the session pointer to NULL should not be necessary as
the session is freed once the reference count drops down to zero. Due to
the fact that changing this would require moderate changes in session code
means that it should not be done in a patch release as the risks are too
high.
2018-09-12 08:44:31 +03:00
Markus Mäkelä
9c08d78304
Add missing error messages
If tee filter creation fails, it would not log an error message.
2018-09-12 08:44:31 +03:00
Johan Wikman
81a3c73c74 Fix assert -> expect breakage 2018-09-12 08:39:54 +03:00
Esa Korhonen
fd176c4122 Merge branch '2.2' into develop 2018-09-11 12:57:19 +03:00
Esa Korhonen
c04073a96c MXS-2040 Increase default monitor timeouts
All three timeouts are now three seconds. This should reduce the amount of
timeout errors users get during failover/switchover.
2018-09-11 12:31:41 +03:00
Esa Korhonen
ad71655a36 MXS-2036 Redirect slaves with stopped SQL threads
This is somewhat questionable, as the slaves won't be able to really
replicate from the new master. However, not doing this causes the wrong
master to be selected after failover unless the new master has a majority
of slaves under it.
2018-09-11 10:27:31 +03:00
dapeng huang
087272c3e4 fix multistatment hang (#180) 2018-09-11 08:39:12 +03:00
Markus Mäkelä
c878146c24
MXS-1947: Add test case
The test checks that composite roles work.
2018-09-10 21:47:47 +03:00
Markus Mäkelä
889877c0ab
MXS-1947: Add support for composite roles
Added support for composite roles for 10.2 and newer versions. As
recursive CTEs are required to extract the role mappings, composite roles
aren't supported on 10.1.
2018-09-10 21:47:47 +03:00
Markus Mäkelä
9e0042b3b5
Fix symbolic VERSION file
The file is included from locations other than the source root. Due to
this, it needs to be prefixed with ${CMAKE_SOURCE_DIR}.
2018-09-10 21:47:03 +03:00
Markus Mäkelä
31f6d49ddb
Add symbolic VERSION file
The VERSION.cmake file defines which VERSION.cmake file is included. By
changing the file that it points to, the version can be changed without it
affecting other parts of the code that use it.
2018-09-10 15:11:18 +03:00
Markus Mäkelä
8896b0275f
Recreate 2.2.14 release notes
Generated the release notes with the release note generation script.
2018-09-10 15:02:15 +03:00
Markus Mäkelä
64177276be
Automatically generate relese notes
As most of the release notes are "boilerplate text", the changing parts
can be easily scripted.
2018-09-10 15:01:41 +03:00
Markus Mäkelä
eed2628cff
Rewrite issue listing script
Rewrote the script in python and leveraged the dictionary CSV processor to
prevent field number mismatches. Combined the two scripts into one so that
all user-facing issues that are fixed can be easily shown in the release
notes.
2018-09-10 15:01:29 +03:00
Markus Mäkelä
73405c8ff9
Stabilize bug676
The test should now be stabler as it waits for a monitor interval instead
of a set amount of seconds.
2018-09-10 15:01:29 +03:00
Markus Mäkelä
6938df0d62
Use default member initializers in WORKER_STATISTICS
Makes the class simpler and removes the need for an explicit
constructor. Also switched to std::array to enable easy iteration over the
array.
2018-09-10 14:15:10 +03:00
Markus Mäkelä
94a567f4ca
Remove redundant Worker method
The Worker::get_local_statistics was a duplicate of Worker::statistics.
2018-09-10 14:14:21 +03:00
Markus Mäkelä
1e7d088aed
Make combination of rworker_local values easier
The `values` helper method provides a convenient way to access all of the
internal values as a vector.
2018-09-10 14:14:21 +03:00
Markus Mäkelä
58c0b4f5f4
MXS-1632: Remove the unused statistics code
The statistics code was almost completely unused.
2018-09-10 14:14:20 +03:00
Markus Mäkelä
108638b0cf
Format with Uncrustify 0.67 2018-09-10 13:31:39 +03:00
Markus Mäkelä
d11c78ad80
Format all sources with Uncrustify
Formatted all sources and manually tuned some files to make the code look
neater.
2018-09-10 13:22:49 +03:00
Johan Wikman
edd5ddcc88 Merge branch '2.2' into develop 2018-09-10 12:29:00 +03:00
Markus Mäkelä
03017c6aad
Fix develop build failures
The macro in testrules.cc needed to be chagned to use string literals to
work correctly with uncrustify. Also change <cmath> to <math.h> in C
headers.
2018-09-10 11:34:09 +03:00
Markus Mäkelä
d16fbd4cdf
Expand list users output in maxctrl
The output now lists the type and privileges of each user.
2018-09-10 11:21:06 +03:00
Markus Mäkelä
8c03b626c4
Make users diagnostic deterministic
The output from Users::diagnostic is now ordered by first inserting the
usernames into a std::set.
2018-09-10 11:21:06 +03:00