12686 Commits

Author SHA1 Message Date
Esa Korhonen
a1697e2aa6 MXS-2479 PAMBackendAuth is more tolerant of extra messages.
The authenticator can now receive additional questions from the server even
after the original password-query.
2019-05-24 11:31:55 +03:00
Esa Korhonen
bd8aa64547 MXS-2479 Accept additional messages in PAM authenticator
Plugins may send additional messages during authentication. These messages
often contain notifications such as password expiration dates. Both the client
and backend side authenticators now handle such messages. The messages are not
sent to the user, only the log. The requirement that only "Password: " is queried
still stands.
2019-05-23 14:14:25 +03:00
Markus Mäkelä
8317fec745
MXS-2496: Check for ALL PRIVILEGES grant
If a user has ALL PRIVILEGES as a global privilege, it overshadows the
SHOW DATABASES grant.
2019-05-22 09:56:35 +03:00
Markus Mäkelä
365efb9d3a
Ignore SIGHUP termination in ssh_node
Sometimes the command appears to complete and terminate with a SIGHUP
instead of the proper return value.
2019-05-22 09:56:35 +03:00
Markus Mäkelä
b294acf276
MXS-2496: Fix SHOW DATABASES grant check
The code expected that the grant was given to the actual user, not a role.
2019-05-21 13:43:51 +03:00
Esa Korhonen
bb706394f6 MXS-2473 Simplify regular expression settings documentation
The settings "match", "exclude" and "options" are now explained once
in the general documentation. The individual filter documentation refers
to the general explanation.
2019-05-20 11:18:03 +03:00
Markus Mäkelä
96a477ec89
MXS-2490: Send error to client on unknown PS handle
If a client requests an unknown binary protocol prepared statement handle,
a custom error shows the actual ID used instead of the "empty" ID of 0
that the backend sends.
2019-05-17 14:13:44 +03:00
Markus Mäkelä
f94355770f
Merge branch '2.2' into 2.3 2019-05-17 14:10:28 +03:00
Markus Mäkelä
bf63698991
MXS-2464: Bring back the runtime query queue check
The code that checked that only non-empty queries are stored in the query
queue was left out when the query queue fix was backported to 2.3. Since
MXS-2464 is caused by a still unknown bug, the runtime check should help
figure out in which cases the problem occurs.
2019-05-17 13:03:03 +03:00
Timofey Turenko
ca682a5b1c Merge branch '2.2' of github.com:mariadb-corporation/MaxScale into 2.2 2019-05-17 09:40:07 +03:00
Timofey Turenko
677023a18f Move version pronting from call_mdcbi() directly to TestConnectios()
mdbci call can heppen before maxsales object creation and segfault hapens
To avoid it call of ssh for 'maxscale --version-full' is moved to the end
of Testconnections constructor
2019-05-16 14:36:37 +03:00
Johan Wikman
1c820f6ae3 Merge branch '2.3.7' into 2.3 2019-05-16 10:55:02 +03:00
Johan Wikman
1dbe599b2a Update 2.3.7 release date
Also remove the MXS-2475 'Fix mxs1980_blr_galera_server_ids_' "bug"
that was changed into a task as it has no impact on users of MaxScale.
2019-05-16 10:47:46 +03:00
Markus Mäkelä
2cd4da32a7
MXS-2494: Fix user loading queries for MariaDB 10.1+
The queries now properly check for the plugin.
2019-05-16 10:41:04 +03:00
Johan Wikman
0f85baabe1 MXS-2491 Remove global destructor inter-dependency
log.cc:this_unit.slogger depends upon logger.cc:this_unit.ident.
Depending on which one is destructed first, there will be a crash
or then not.

It seems that the destruction order when returning from main()
is not necessarily the same as that when calling exit() in main,
as this bug is triggered with compilers versions and not with other.
2019-05-15 15:46:20 +03:00
Johan Wikman
8a67c702b8 MXS-2475 Final fix for mxs1980_blr_galera_server_ids
In this context wsrep_gtid_domain_id and gtid_domain_id need to
be the same to ensure that all gtids will be the same.
2019-05-15 14:55:21 +03:00
Timofey Turenko
a3e9ce651f Add 'maxscale --version-full' command to call_mdbci()
Previously Maxscale version check was in the 'check_backend', but this was
removed from the tests execution process. Now 'maxscale --version-full'
is added to nodes creation function - to call_mdbci()
2019-05-15 13:18:27 +03:00
Johan Wikman
b80aa081fe Fix test_buffer test case 2019-05-15 12:17:10 +03:00
Johan Wikman
75d50c3411 Update 2.3 maintenance version number 2019-05-15 09:19:09 +03:00
Johan Wikman
74d912195a Add release notes and update change log for 2.3.7 2019-05-15 09:11:40 +03:00
Johan Wikman
01c4beec10 MXS-2470 Update tail pointer in gwbuf_clone 2019-05-14 13:36:33 +03:00
Johan Wikman
600e23ae2d MXS-2470 Add unit test that reveals problem 2019-05-14 13:36:33 +03:00
Johan Wikman
195eeb0c64 Merge branch '2.2' into 2.3 2019-05-14 12:34:40 +03:00
Timofey Turenko
ffecce4153 Fix non_native_setup
The arguments must be passed as-is to the TestConnections constructor.
2019-05-14 10:54:32 +03:00
Johan Wikman
b7d948db3f MXS-2475 Properly setup the Galera nodes 2019-05-14 10:13:09 +03:00
Johan Wikman
79cfd7183d MXS-2475 Fix mxs1980_blr_galera_server_ids test
At some point the replicating slave had been changed to be
a Galera node. Won't work as the Galera node is a master.
2019-05-14 10:13:09 +03:00
Markus Mäkelä
b10fc196a1
Fix maxinfo/maxadmin debug assertion
Both services could write to a DCB from a worker that doesn't own it.
2019-05-10 11:23:10 +03:00
Markus Mäkelä
142038051c
Fix GCC 9 warnings
GCC 9 has warnings about pessimistic return values which are triggered by
returning a local value via std::move.
2019-05-10 09:11:40 +03:00
Markus Mäkelä
1efe3e0b20
Fix avrorouter client notifications
The notifications that tell clients about new data weren't using the
correct mechanism.
2019-05-10 09:11:39 +03:00
Markus Mäkelä
37bfe1cd67
Never exceed persistent connection limits
By doing the persistent connection count incrementation with CAS, value
can be guaranteed to never exceed the configured limit.
2019-05-10 09:11:39 +03:00
Johan Wikman
034dc6a67e MXS-2472 Update BLR docs on secondary masters 2019-05-09 17:14:57 +03:00
Johan Wikman
3c5a932010 Fix masking_mysqltest for 2.3
Since UNIONs that would allow a column to be masked are
rejected, there is no need to check that masking is performed
since we will never get that far.
2019-05-09 17:12:52 +03:00
Markus Mäkelä
c72dbb6f46
MXS-2448: Fix connection counts of persistent DCBs
DCBs that were closed while they were persisted were double decremented.
2019-05-09 13:53:32 +03:00
Markus Mäkelä
d2e49c9591
MXS-2448: Assert that connection counts never go negative
The connections should never go below zero. It seems that at least pers_01
test suffers from this.
2019-05-09 13:06:27 +03:00
Markus Mäkelä
567ad9b8b8
Fix galeramon regression
The comparisons were wrong: strcasecmp returns 0 for equal strings.
2019-05-09 12:30:29 +03:00
Markus Mäkelä
59f2145c00
Allocate blr heartbeat buffer on correct worker
The buffer was allocated on one worker and written on another.
2019-05-09 12:30:29 +03:00
Markus Mäkelä
788dc429f8
Do client callback on owning worker
The callback should've been done on the worker that owns the DCB instead
of the main worker.
2019-05-09 12:30:26 +03:00
Johan Wikman
b313c6d0e7 MXS-2474 Ignore attempts to re-register a housekeeper task
It is an error to register the same task multiple times, but
for a maintenance release it is simpler and less risky to simply
ignore an attempt (that BLR does) to do that.

Allowing a task to be registered anew causes behaviour akin
to a leak.
2019-05-09 10:58:35 +03:00
Johan Wikman
5ea2bab88c Merge branch '2.2' into 2.3 2019-05-08 15:56:08 +03:00
Johan Wikman
ff1959fda7 Merge branch '2.2.21' into 2.2 2019-05-08 15:55:42 +03:00
Johan Wikman
73f8bf1f6f Update 2.2.21 release date 2019-05-08 15:49:11 +03:00
Esa Korhonen
1df6495d9a Update release notes on MariaDB-Monitor change 2019-05-08 15:32:08 +03:00
Markus Mäkelä
a652b6bd5b
Add advance(int) to mxs::Buffer iterators
This makes iterating over packets in buffers faster while still
maintaining the requirements for forward iterators. Not using operator+=
makes it clear that this is not a random access iterator.
2019-05-08 10:33:27 +03:00
Markus Mäkelä
0638ea736e
Write slave heartbeat in correct thread
The writing should be done on the worker that owns the DCB.
2019-05-08 09:44:55 +03:00
Johan Wikman
9ae25e67a8 Update maintenance number in 2.2 minor branch 2019-05-07 15:27:48 +03:00
Johan Wikman
a7a2215681 Update release notes and change log 2019-05-07 15:22:37 +03:00
Marko
4e3a581c94 Merge branch '2.2' into 2.3 2019-05-06 20:09:37 +03:00
Marko
adde085b7d Fix incorrect closing bracket in strlen call
The bracketing was causing heap overflow when trying to run the system
tests.
2019-05-06 13:50:18 +03:00
Esa Korhonen
31a6668420 Add PAM authenticator test
Both a normal PAM user and anonymous user mapping are tested.
2019-05-06 10:44:18 +03:00
Esa Korhonen
96b6acecff MXS-2427 Extend namedserverfilter test
Tests with two targets.
2019-05-06 10:31:51 +03:00