ef8a20cceb
Fix silly mistakes.
2016-02-22 11:16:51 +00:00
5077933e41
Fix bug in mysql_client.c (over optimisation of protocol setting); various clarifications and improvements re code review.
2016-02-22 11:05:02 +00:00
866e91c088
Changes to improve robustness of SSL processing, separate it so far as possible from protocols. Separate the detailed mechanism of authentication from the MySQL protocol with a view to making it into a module later.
2016-02-15 09:29:07 +00:00
971d1d5de2
Redesign logic of SSL connections to work with status in client DCB instead of in the protocol. This eases the way to moving SSL logic out of a specific protocol (currently MySQL) so as to be available across any protocol. Also, some simplification.
2016-02-03 08:54:55 +00:00
05fa498dc0
Add an SSL header needed to support extra data in DCB.
2016-01-27 15:46:50 +00:00
8367d93746
Migrate SSL functionality out of service and into listener. Develop config handling accordingly, including making provision for SSL parameters in servers for future use in implementing SSL to backend servers. Some elements still to be tidied mainly in mysql_client.c - but that will be part of detaching the SSL authentication from the MySQL protocol.
2016-01-27 15:46:19 +00:00
e58148356d
Split off listener functionality and move SSL initiation from service to listener. Put GWPROTOCOL in its own header file.
2016-01-26 16:08:02 +00:00
1f241a5ed1
Rearrange libraries and build files.
...
This is the first change in an attempt to arrange the linking so that
more errors are detected at link-time.
- All files in server/core but for gateway.c are linked to one shared
library called maxscale-common.
- The files log_manager/log_manager.cc and utils/skygw_utils.cc are
built into maxscale-common as well.
- MaxScale itself consists now only of gateway.c and is linked with
maxscale-common.
- All plugins link with maxscale-common.
- All executables link in addition with {EMBEDDED_LIB}.
After this change, the change (MXS-517) where query_classifier is the
only component that uses ${EMBEDDED_LIB} and the rest mysqlclient can
be made much cleaner.
After a few additional steps, all shared libraries can be linked with
the linker flags "-Wl,-z,defs", which directs the linker to resolve
all symbols. That will require that all shared libraries list all the
libraries they need, but will at the same time ensure that any
missing symbols are detected at link-time and not at run-time.
2016-01-22 23:26:17 +02:00
a61cedb1aa
Fixed freeing of wrong pointer
...
The wrong pointer in server_free was used to clear the server parameters.
2016-01-22 18:55:54 +02:00
5ac1ab412e
Formatted utils library sources
...
Formatted all utils library sources according to the style guide.
2016-01-22 18:55:54 +02:00
cceeb2d234
Formatted maxadmin.c
...
Formatted maxadmin.c according to the style guide.
2016-01-22 18:55:54 +02:00
608924beba
Build pcre2 as PIC.
...
If pcre2 is to be included in a shared library, it needs to be PIC.
2016-01-22 15:09:50 +02:00
c8253cc767
Pass CMAKE_C_FLAGS to pcre2.
...
Now possible to affect CFLAGS of pcre2 build.
2016-01-22 15:08:02 +02:00
872d02db3e
Finalized configuration processing cleanup
...
All parts of the configuration processing are now in their own functions.
This allows new objects to be created after MaxScale has started.
2016-01-20 09:25:03 +02:00
508c91be32
Cleaned up monitor configuration processing
...
Moved the monitor configuration processing into its own function and cleaned
it up.
2016-01-19 14:23:44 +02:00
53ac88a1a1
Cleaned up the process of adding filters and servers to a service
...
Moved the adding of filters, servers and router options to its own function.
2016-01-19 14:23:44 +02:00
0aaba891a3
Cleaned up server configuration processing
...
Moved the creation of new servers into a separate function and cleaned up
the configuration processing.
2016-01-19 14:23:44 +02:00
c6dfcb66f5
Cleaned up service configuration processing
...
Moved the allocation and configuration of services into their own function.
Moved SSL parameter validation into a separate function.
2016-01-19 14:23:44 +02:00
f12be9fea2
MXS-549: Change MaxScale's working directory on startup
...
MaxScale now changes the working directory to the log directory when it is
started. If this fails, the file system root is used instead.
2016-01-19 13:59:38 +02:00
c2310327fc
Fixed idle session processing
...
The current implementation of idle connection timeouts is not safe. The sessions
are handled in a way which is not thread-safe and the checking is done from
a non-polling thread.
With this change, the checks for the session timeouts are done in one of the
polling threads in a thread-safe manner only if at least one service has enabled
the timing out of idle client connections.
2016-01-19 10:53:55 +02:00
cdeb921b1b
Added missing freeing of monitor resources
...
Monitor servers were not freed.
2016-01-15 21:38:40 +02:00
d41fe5b9c7
Added extra checks to readwritesplit
...
Added a check that the master server reference is actually in use before
doing anything with it. Also removed a false assertion.
2016-01-15 16:25:05 +02:00
c5947285cf
Added missing freeing of filter resources
...
Filters were not freeing their options or parameters.
2016-01-15 16:24:32 +02:00
1656840417
Added missing freeing of service resources
...
The service resources weren't freed when the service is freed.
2016-01-15 16:23:41 +02:00
a2bc15c870
Removed obsolete functions from dbfwfilter
...
The filter defined its own hashing and string comparison functions even though
there are common functions for both.
2016-01-15 16:22:18 +02:00
47f6c6613e
Added missing freeing of server resources
...
The server did not release the parameters or the slave ID list.
2016-01-15 12:42:12 +02:00
5515c71988
Reapply MXS-504 changes subsequent to optimisation changes. Merge SSL processing into non-SSL processing so far as possible, correct usage of OpenSSL, simplify where possible.
2016-01-13 10:08:37 +00:00
d13bec0647
Reformat testprotocol.c
2016-01-12 15:52:29 +02:00
183202466d
Reformat telnetd.c
2016-01-12 15:49:09 +02:00
fd9698e705
Reformat mysql_common.c
2016-01-12 15:43:33 +02:00
da29ee0f4a
Reformat mysql_client.c
2016-01-12 15:21:33 +02:00
244d7ee86c
Reformat mysql_backend.c
2016-01-12 14:57:26 +02:00
1b94c5b519
Reformat mascaled.c
2016-01-12 14:20:11 +02:00
018b87d304
Reformat httpd.c
2016-01-12 14:14:40 +02:00
040c67127a
Reindent schemarouter.c
...
- Untabify
- 4 space indent
- Allman + other style issues.
2016-01-12 13:54:23 +02:00
0a3e6b4352
MXS-498: Username and source address added to QLA filter output
...
The filter now logs the username and remote address of each client. This will
make tracking of users and their queries a lot easier.
2016-01-12 09:30:03 +02:00
985543dbb2
Fixed merge conflict
...
One function in the query classifier used the old name which led to undefined
symbols.
2016-01-12 09:19:46 +02:00
54ca1ab2de
Canonicalized queries remove non-executable comments
...
The comments which do not alter the functionality of a query are now removed
from canonicalized queries.
Also fixed missing semicolon in the comment removal regex and added tests
for comment removal.
2016-01-11 17:14:57 +02:00
8ee110efa8
Fixed canonicalization and added more tests
...
Fixed mistakes in the canonicalization regular expressions and altered the
functions to use a source and destination buffers. This reduces the amount
of memory allocations that take place.
Added more canonical query tests to the internal test suite.
2016-01-11 17:14:44 +02:00
e0c84e0fe3
Added removal of MySQL style comments to query canonicalization.
...
Also fixed minor issues with the canonicalization regular expressions.
2016-01-11 17:13:14 +02:00
c067bbe34a
Formatted the canonical query test.
...
The file is now formatted according to the style guide.
2016-01-11 17:13:01 +02:00
9c9e30fa08
Fixed value replacement and added more tests for canonicalization of queries
...
The value replacement was not taking session or system variables into notice.
2016-01-11 17:09:40 +02:00
995ed8c9d2
Improved query canonicalization
...
The query does not need to be parsed for it to be canonicalized and the parsing
uses the PCRE2 library. The regular expressions were changed so that only one
call to the function which replaces literal unquoted values is made.
2016-01-11 17:08:03 +02:00
b01e8b2eec
Added utils library initialization function and improved replace_quoted
...
Currently the initialization function only prepares PCRE2 patterns for use.
Added the call to the new utils_init() function to MaxScale and all relevant
tests.
The replace_quoted now uses a shared PCRE2 pattern which should remove some
of the overhead of the function.
2016-01-11 17:04:39 +02:00
f57df4b967
Hide unused public functions
...
parse_query and query_is_parsed are not used outside query classifier
anymore. Consequently, they can be made internal.
2016-01-11 15:28:00 +02:00
4d155f70b0
Remove call to parse_query.
...
Not needed anymore.
2016-01-11 15:14:27 +02:00
20bc6a4ab7
Reindent canonizer.c
...
- Untabify
- Remove trailing whitespace.
- Allman braces.
2016-01-11 15:08:27 +02:00
79fa226000
Move private type to implementation.
...
parsing_info_t is only used by the query_classifier implementation.
No need to keep it public.
2016-01-11 14:58:15 +02:00
23a7562d3a
Replace skygw_ type prefix with qc_.
...
- skygw_query_type_t renamed to qc_query_type_t.
- skygw_query_op_t renamed to qc_query_op_t.
2016-01-11 12:06:21 +02:00
2f42246880
Rename query classifier functions consistently.
...
All public query classifier functions now have the prefix qc_.
2016-01-11 12:04:52 +02:00
