7399 Commits

Author SHA1 Message Date
Markus Mäkelä
f06c34f66c MXS-1456: Fix crash on empty script value
If a script variable resolves to an empty string, the replacement attempt
will fail with an out-of-memory error. The following realloc call will
fail as it requires a positive value for the new size.
2017-09-27 10:32:26 +03:00
Johan Wikman
df4f3cb302 MXS-1450 Remove leading whitespace
Leading whitespace is removed from a sent maxadmin command
before the command is interpreted.
2017-09-26 13:47:08 +03:00
Johan Wikman
bfe387b73f MXS-1450 Remove manual history, sort includes
Remove manually maintained revision history and sort include
files.
2017-09-26 13:43:59 +03:00
Johan Wikman
4220e3ca6a MXS-1450 Add more string trimming functions
- trim_leading
- trim_trailing

Implemented trim in terms of trim_leading and trim_trailing
2017-09-26 13:36:10 +03:00
Johan Wikman
bb95074e88 MXS-1450 Add test case for trim 2017-09-26 13:19:09 +03:00
Johan Wikman
e0dcb2da38 Update version number 2017-09-26 10:44:19 +03:00
Markus Mäkelä
753c61997d MXS-1451: Expand test case
The test now checks that both users with passwords and users without
passwords work through MaxScale when skip_authentication is enabled. In
addition to this, the test also makes sure that the wrong password and a
missing password are properly detected.
2017-09-26 07:48:45 +03:00
Markus Mäkelä
2079bba49c MXS-1451: Calculate password even with skip_authentication=true
The result of the authentication should be ignored but the scramble that
is calculated as a side-effect still needs to be stored. This can be done
by altering the SQL used to get the matching row to only match on the
username, not the network address.

Also expanded the test case to cover the use of bad credentials.
2017-09-25 19:00:44 +03:00
Markus Mäkelä
6601f15ff8 MXS-1451: Add test case
Added test case for MXS-1451 that reproduces the problem.
2017-09-25 13:27:55 +03:00
Johan Wikman
f5b329a0a3 Update 2.1.9 release date 2017-09-25 12:05:40 +03:00
Johan Wikman
8d136d7979 Scripts work without . in the PATH
Scripts work without . in the path and also if invoked from anywhere.
2017-09-21 10:13:12 +03:00
Johan Wikman
c015adfe92 Update 2.1 release notes 2017-09-21 10:08:50 +03:00
Markus Mäkelä
db7e2c2ffb Use /usr/bin/env perl instead of /bin/perl
This allows Perl to be installed in other locations.
2017-09-21 09:51:58 +03:00
Markus Mäkelä
eb3a9667fc Discard connections on interrupted COM_CHANGE_USER
Close the connection if a COM_QUIT is received while the COM_CHANGE_USER
is in progress.
2017-09-21 09:25:56 +03:00
Markus Mäkelä
b2d53a963a Fix the bug listing script
The script had the Markdown links in the wrong order.
2017-09-21 09:25:32 +03:00
Markus Mäkelä
9c0dbb5511 Add 2.1.9 release notes
Added 2.1.9 release notes.
2017-09-21 09:25:32 +03:00
Johan Wikman
2067079a44 Update ChangeLog and Upgrading 2017-09-20 12:31:02 +03:00
Johan Wikman
f5cbd4a0bc Fix links
The link syntax was the wrong way around.
2017-09-20 12:27:18 +03:00
Markus Mäkelä
481ad080ef MXS-1295: Add test case
The test case checks that the strict_sp_calls parameter works as expected.
2017-09-20 11:18:16 +03:00
Markus Mäkelä
9046db06c5 MXS-1295: Add strict_sp_calls parameter
The new parameter allows the session to be "locked" to the master server
after a stored procedure is called. This will keep the session state
consistent if the stored procedure call modifies the state of the session.
2017-09-20 11:18:16 +03:00
Johan Wikman
9d9cffe4c7 MXS-1377 Always delete the pid-file
Earlier the pid-file was deleted only if the MaxScale startup
succeeded and MaxScale exited in normal fashion.
2017-09-20 10:57:13 +03:00
Johan Wikman
b5ec55dea8 Update version to 2.1.9 2017-09-20 10:51:48 +03:00
Johan Wikman
8ff0c0ad6d Update release date 2017-09-20 10:01:27 +03:00
Markus Mäkelä
15c16e378b Add fixed bugs to 2.1.8 release notes
Added MXS-1418 and MXS-1409 to release notes.
2017-09-18 23:12:01 +03:00
Markus Mäkelä
e8a9a393ae Fix bug and issue list scripts
The scripts now properly handle quoted CSV values with the help of a Perl
script.
2017-09-18 22:57:37 +03:00
Markus Mäkelä
aaa60d37e6 Add missing parameter documentation to maxrows
Documented new parameters.
2017-09-18 22:03:30 +03:00
Markus Mäkelä
d72375ebb5 Reset resultset offset when discarding response
The offset into the resultset buffer needs to be reset before each
processed packet if the resultset is being discarded.
2017-09-18 20:51:52 +03:00
Markus Mäkelä
d168493ddf Fix maxrows offset calculation
The code that handles the resultset rows added the extra offset given as a
parameter into the total offset when it should've be ignored.
2017-09-18 20:32:28 +03:00
Markus Mäkelä
a4bad5ffd2 Use shorter timeouts in mxs1323_retry_read
The configuration for mxs1323_retry_read now uses shorter timeouts for
monitors. This should help the monitors detect the server failures before
the result of the SELECT returns. also increased the time the query sleeps
before returning.
2017-09-18 13:46:20 +03:00
Markus Mäkelä
d003983e5a MXS-1409: Improve MaxAdmin error messages
If both socket and network options are listed, a clear error message is
printed. The usage is also split into two lines to make it clear that the
options should be used separately.
2017-09-16 07:44:25 +03:00
Markus Mäkelä
9267f8ad70 MXS-1418: Keep connections open if server is removed
The removal of a server from a service is intended to affect only new
sessions.

Added a test that checks that the connections are kept open even if the
server is removed from the service.
2017-09-16 07:28:17 +03:00
Johan Wikman
2d02cc9973 Update ChangeLog, Upgrading and Release Notes 2017-09-15 17:23:20 +03:00
Johan Wikman
3fc498e4cc Update version number to 2.1.8 2017-09-15 17:14:47 +03:00
Johan Wikman
d1b742eaa5 Log details if cache received unexpected packet from server 2017-09-15 17:14:21 +03:00
MassimilianoPinto
fb12e4c0aa MXS-1411: additional fix to error message
MXS-1411: additional fix to error message
2017-09-15 15:30:39 +02:00
MassimilianoPinto
9dd7f2174c MXS-1412: while discarding a result set don't buffer any data.
MXS-1412: while discarding a result set don't buffer any data: this
avoids to store useless data.

Additionally the colum definitions buffer is used instead of the offset
value.
2017-09-15 12:05:28 +02:00
MassimilianoPinto
8905c3aa34 MXS-1411: fix error message and log priority
MXS-1411: fix error message and log priority
2017-09-14 15:33:39 +02:00
Markus Mäkelä
7e48941a04 MXS-1412: Process response buffers individually
By processing each buffer individually, the need to iterate over the whole
resultset is removed. Profiling showed that most of the time was spent
navigating the linked list of buffers when an offset into the whole
resultset was used instead of an offset to the individual response buffer.
2017-09-14 09:50:05 +03:00
Johan Wikman
49ab5797a2 MXS-1406 Report CALL operation
Basically it would be trivial to report far more operations
explicitly, but for the fact that the values in qc_query_op_t
currently, quite unnecessarily, form a bitmask.

In 2.2 that is no longer the case, so other operations will be
added there.
2017-09-12 15:38:25 +03:00
Markus Mäkelä
362234b5d2 Merge branch '2.1.7' into 2.1 2017-09-12 09:43:12 +03:00
Markus Mäkelä
4a42ddfe5f Null-terminate decrypted passwords
The decrypted passwords returned by `decrypt_password` are now properly
null-terminated.
2017-09-12 09:29:26 +03:00
Markus Mäkelä
7a8a12dd28 Update CDash drop site address
The drop site was not set to the correct one.
2017-09-12 09:29:26 +03:00
Markus Mäkelä
40f846cbb0 Add MXS-1396 into 2.1.7 release notes
The bug was included in the 2.1.7 tag but it was not in the release notes.
2017-09-12 09:28:54 +03:00
Markus Mäkelä
81202eac89 MXS-1400: Fix crash with OpenSSL 1.1
Added the missing parameter for the RSA key generation function.
2017-09-11 12:50:24 +03:00
Markus Mäkelä
9ceb23dd65 MXS-1396: Fix persistent connection hangs
When a COM_CHANGE_USER was executed, it is possible that the server
responds with a AuthSwitchRequest packet instead of an OK packet. In this
case, the server sends a new scramble which must be used to create the 20
byte hash that is expected as the response.
2017-09-11 12:50:24 +03:00
Johan Wikman
faa1cc815d Merge branch '2.1' into 2.1.7 2017-09-11 12:28:02 +03:00
Johan Wikman
5337a5092f Update release date for 2.1.7 2017-09-11 10:55:01 +03:00
Markus Mäkelä
f4cd2c62b6 Backport mxs1110_16mb fixes to 2.1
Backported changes to mxs1110_16mb from develop into 2.1.
2017-09-08 09:54:17 +03:00
Markus Mäkelä
0daa167873 Fix bug519
The test attempted to copy the generated CSV file from the MaxScale server
when in fact it was on the master server. Removed HEAVY label from the
test as it takes about 10 seconds to run.

Cherry-picked from commit f80cde2af149fda9c47d8f9131f82527b76af487.
2017-09-08 09:54:17 +03:00
Johan Wikman
db51d94b76 Update release notes 2017-09-07 10:20:35 +03:00