hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix all_rows_active wrong value when detect skew detection

Browse Source
This commit is contained in:
lucky-sinx
2024-09-02 06:41:57 +00:00
committed by ob-robot
parent 72ccbd990f
commit 312ef888db
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/engine/aggregate/ob_hash_groupby_vec_op.cpp
View File

@ -2252,6 +2252,7 @@ int ObHashGroupByVecOp::by_pass_prepare_one_batch(const int64_t batch_size)
int ret = OB_SUCCESS;
bool last_group = false;
bool insert_group_ht = false;
bool has_by_pass_agg_row = false;
LOG_TRACE("by pass prepare one batch", K(batch_size));
if (ObThreeStageAggrStage::FIRST_STAGE == MY_SPEC.aggr_stage_
&& by_pass_nth_group_ <= MY_SPEC.dist_col_group_idxs_.count()
@ -2352,11 +2353,12 @@ int ObHashGroupByVecOp::by_pass_prepare_one_batch(const int64_t batch_size)
LOG_WARN("fail to process row", K(ret));
} else {
brs_.set_skip(i);
has_by_pass_agg_row = true; // need to set all_rows_active = false
}
}
}
if (OB_FAIL(ret) || no_non_distinct_aggr_) {
if (last_group && no_non_distinct_aggr_) {
if ((last_group && no_non_distinct_aggr_) || has_by_pass_agg_row) {
// in bypass && last_group && no_non_distinct_aggr_, brs_.skip_ will be set_all (all skip)
brs_.all_rows_active_ = false;
} else {