hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix lose ret code in alloc expr

Browse Source
This commit is contained in:
ChangerR
2024-04-23 10:23:39 +00:00
committed by ob-robot
parent 4286335ac3
commit 3dde2243e3
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/optimizer/ob_logical_operator.cpp
View File

@ -321,7 +321,7 @@ int ObAllocExprContext::add(const ExprProducer &producer)
if (OB_FAIL(expr_producers_.push_back(producer))) { if (OB_FAIL(expr_producers_.push_back(producer))) {
LOG_WARN("failed to push back producer", K(ret)); LOG_WARN("failed to push back producer", K(ret));
} else if (expr_producers_.count() == 1 && } else if (expr_producers_.count() == 1 &&
expr_map_.create(128, "ExprAlloc")) { OB_FAIL(expr_map_.create(128, "ExprAlloc"))) {
LOG_WARN("failed to init hash map", K(ret)); LOG_WARN("failed to init hash map", K(ret));
} else if (OB_FAIL(expr_map_.set_refactored(reinterpret_cast<uint64_t>(producer.expr_), } else if (OB_FAIL(expr_map_.set_refactored(reinterpret_cast<uint64_t>(producer.expr_),
expr_producers_.count() - 1))) { expr_producers_.count() - 1))) {

1
src/sql/optimizer/ob_skyline_prunning.cpp
View File

@ -652,7 +652,6 @@ int ObSkylineDimRecorder::add_index_dim(const ObIndexSkylineDim &dim, bool &has_
OPT_TRACE("Index can not be pruning"); OPT_TRACE("Index can not be pruning");
} else { } else {
if (OB_FAIL(has_dominate_dim(dim, remove_idxs, need_add))) { if (OB_FAIL(has_dominate_dim(dim, remove_idxs, need_add))) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("check has dominate index failed", K(dim)); LOG_WARN("check has dominate index failed", K(dim));
} else if (need_add) { } else if (need_add) {
//remove from back, idx id is in ascending order //remove from back, idx id is in ascending order