hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix mview fast refresh bug when query contain special expr

Browse Source
This commit is contained in:
chimyue 2024-04-22 06:19:31 +00:00 committed by ob-robot
parent 54c98d2a93
commit 772c61d04b
4 changed files with 49 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/sql/resolver/dml/ob_dml_stmt.cpp
View File

@ -3681,6 +3681,26 @@ int ObDMLStmt::has_special_expr(const ObExprInfoFlag flag, bool &has) const
return ret;
}
int ObDMLStmt::has_special_exprs(const ObSqlBitSet<> &flags, bool &has) const
{
int ret = OB_SUCCESS;
ObSEArray<ObRawExpr*, 16> exprs;
has = false;
if (OB_FAIL(get_relation_exprs(exprs))) {
LOG_WARN("failed to get relation exprs", K(ret));
} else {
for (int64_t i = 0; OB_SUCC(ret) && !has && i < exprs.count(); i++) {
if (OB_ISNULL(exprs.at(i))) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("get unexpected null", K(ret));
} else if (exprs.at(i)->get_expr_info().overlap(flags)) {
has = true;
}
}
}
return ret;
}
int ObDMLStmt::rebuild_tables_hash()
{
int ret = OB_SUCCESS;

1
src/sql/resolver/dml/ob_dml_stmt.h
View File

@ -1106,6 +1106,7 @@ public:
int get_udf_exprs(common::ObIArray<ObRawExpr *> &exprs) const;
int has_rand(bool &has_rand) const { return has_special_expr(CNT_RAND_FUNC, has_rand); }
virtual int has_special_expr(const ObExprInfoFlag, bool &has) const;
int has_special_exprs(const ObSqlBitSet<> &flags, bool &has) const;
const TransposeItem *get_transpose_item() const { return transpose_item_; }
void set_transpose_item(const TransposeItem *transpose_item) { transpose_item_ = transpose_item; }
const ObUnpivotInfo get_unpivot_info() const

31
src/sql/resolver/mv/ob_mv_checker.cpp
View File

@ -122,11 +122,10 @@ int ObMVChecker::check_mv_stmt_refresh_type_basic(const ObSelectStmt &stmt, bool
if (OB_SUCC(ret)) {
bool has_rownum = false;
bool has_special_expr = false;
const ObExprInfoFlag flag = CNT_RAND_FUNC;
if (OB_FAIL(stmt.has_rownum(has_rownum))) {
LOG_WARN("failed to check has rownum", K(ret));
} else if (OB_FAIL(stmt.has_special_expr(flag, has_special_expr))) {
LOG_WARN("failed to check has special expr", K(ret));
} else if (OB_FAIL(check_mv_stmt_use_special_expr(stmt, has_special_expr))) {
LOG_WARN("failed to check mv stmt use special expr", K(ret));
} else if (has_special_expr || has_rownum || stmt.has_ora_rowscn()) {
is_valid = false;
append_fast_refreshable_note("rownum/ora_rowscn/rand_func not support");
@ -153,6 +152,30 @@ int ObMVChecker::check_mv_stmt_refresh_type_basic(const ObSelectStmt &stmt, bool
return ret;
}
int ObMVChecker::check_mv_stmt_use_special_expr(const ObSelectStmt &stmt, bool &has_special_expr)
{
int ret = OB_SUCCESS;
ObSqlBitSet<> flags;
ObExprInfoFlag flag_arr[] = { CNT_RAND_FUNC,
CNT_STATE_FUNC,
CNT_SEQ_EXPR,
CNT_VOLATILE_CONST,
CNT_DYNAMIC_USER_VARIABLE,
CNT_CUR_TIME,
/* add new check flag above CNT_ASSOCIATED_FLAG_END */
CNT_ASSOCIATED_FLAG_END };
for (int64_t i = 0; OB_SUCC(ret) && CNT_ASSOCIATED_FLAG_END != flag_arr[i] ; ++i) {
if (OB_FAIL(flags.add_member(flag_arr[i]))) {
LOG_WARN("failed to add member", K(ret), K(i), K(flag_arr[i]));
}
}
if (OB_FAIL(ret)) {
} else if (OB_FAIL(stmt.has_special_exprs(flags, has_special_expr))) {
LOG_WARN("failed to check has special exprs", K(ret));
}
return ret;
}
int ObMVChecker::check_mv_duplicated_exprs(const ObSelectStmt &stmt, bool &has_dup_exprs)
{
int ret = OB_SUCCESS;
@ -657,7 +680,7 @@ int ObMVChecker::check_mjv_refresh_type(const ObSelectStmt &stmt, ObMVRefreshabl
} else if (OB_FAIL(check_select_contains_all_tables_primary_key(stmt, select_valid))) {
LOG_WARN("failed to check check select contains all tables primary key", K(ret));
} else if (!select_valid) {
append_fast_refreshable_note("outer join not support");
append_fast_refreshable_note("base table primary key need in select for MJV");
} else {
refresh_type = OB_MV_FAST_REFRESH_SIMPLE_MJV;
}

1
src/sql/resolver/mv/ob_mv_checker.h
View File

@ -80,6 +80,7 @@ private:
int check_mv_join_type(const ObSelectStmt &stmt, bool &join_type_valid);
bool is_mv_join_type_valid(const TableItem *table);
int check_select_contains_all_tables_primary_key(const ObSelectStmt &stmt, bool &contain_all_rowkey);
int check_mv_stmt_use_special_expr(const ObSelectStmt &stmt, bool &has_special_expr);
int check_mv_dependency_mlog_tables(const ObSelectStmt &stmt, bool &is_valid);
int check_mv_duplicated_exprs(const ObSelectStmt &stmt, bool &has_dup_exprs);
bool check_mlog_table_valid(const share::schema::ObTableSchema *table_schema,