hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix filter reorder

Browse Source
This commit is contained in:
DengzhiLiu
2024-04-24 16:16:38 +00:00
committed by ob-robot
parent 3eb25e28bc
commit 8bed77888c
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/storage/column_store/ob_co_where_optimizer.cpp
View File

@ -50,7 +50,7 @@ int ObCOWhereOptimizer::analyze_impl(sql::ObPushdownFilterExecutor &filter)
if (OB_SUCC(ret) && filter.is_logic_and_node()) {
bool reorder = true;
for (uint32_t i = 0; i < child_cnt; ++i) {
for (uint32_t i = 0; reorder && i < child_cnt; ++i) {
sql::ObPushdownFilterExecutor &child_filter = *children[i];
// if (child_filter.is_filter_dynamic_node()) {
// reorder = false;
@ -81,12 +81,10 @@ int ObCOWhereOptimizer::analyze_impl(sql::ObPushdownFilterExecutor &filter)
std::sort(&filter_conditions_[0], &filter_conditions_[0] + child_cnt);
const uint64_t best_filter_idx = filter_conditions_[0].idx_;
best_filter = children[best_filter_idx];
if (best_filter == children[0]) {
reorder = false;
} else if (!can_choose_best_filter(&filter_conditions_[0], *best_filter, filter)) {
reorder = false;
if (0 == best_filter_idx ||
!can_choose_best_filter(&filter_conditions_[0], *best_filter, filter)) {
} else {
for (uint32_t i = 1; i <= best_filter_idx; ++i) {
for (uint32_t i = best_filter_idx; i > 0; i--) {
children[i] = children[i - 1];
}
children[0] = best_filter;
@ -198,4 +196,4 @@ bool ObCOWhereOptimizer::can_choose_best_filter(
}
}
}
}