hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[BUG] remove unnecessary log

Browse Source
This commit is contained in:
Handora 2023-08-07 01:12:22 +00:00 committed by ob-robot
parent 0c76c61d10
commit 8f6117fd11
7 changed files with 9 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/storage/concurrency_control/ob_multi_version_garbage_collector.cpp
View File

@ -785,6 +785,7 @@ int ObMultiVersionGarbageCollector::report(const share::SCN min_unallocated_GTS,
min_active_txn_version.get_val_for_inner_table_field()))) {
MVCC_LOG(WARN, "format sql fail", KR(ret), K(sql));
} else if (OB_ISNULL(GCTX.sql_proxy_)) {
ret = OB_NOT_INIT;
MVCC_LOG(WARN, "sql_proxy_ not init yet, report abort", KR(ret), K(sql));
} else if (OB_FAIL(GCTX.sql_proxy_->write(meta_tenant_id, sql.ptr(), affected_rows))) {
MVCC_LOG(WARN, "execute sql fail", KR(ret), K(sql));
@ -823,6 +824,7 @@ int ObMultiVersionGarbageCollector::update_status(const ObMultiVersionGCStatus s
self_addr.get_port()))) {
MVCC_LOG(WARN, "format sql fail", KR(ret), K(sql));
} else if (OB_ISNULL(GCTX.sql_proxy_)) {
ret = OB_NOT_INIT;
MVCC_LOG(WARN, "sql_proxy_ not init yet, report abort", KR(ret), K(sql));
} else if (OB_FAIL(GCTX.sql_proxy_->write(meta_tenant_id, sql.ptr(), affected_rows))) {
MVCC_LOG(WARN, "execute sql fail", KR(ret), K(sql));
@ -1128,6 +1130,7 @@ int ObMultiVersionGarbageCollector::reclaim_(const ObArray<ObAddr> &reclaimable_
addr.get_port()))) {
MVCC_LOG(WARN, "format sql fail", KR(ret), K(sql));
} else if (OB_ISNULL(GCTX.sql_proxy_)) {
ret = OB_NOT_INIT;
MVCC_LOG(WARN, "sql_proxy_ not init yet, report abort", KR(ret), K(sql));
} else if (OB_FAIL(GCTX.sql_proxy_->write(meta_tenant_id, sql.ptr(), affected_rows))) {
MVCC_LOG(WARN, "execute sql fail", KR(ret), K(sql));

2
src/storage/ls/ob_freezer.cpp
View File

@ -1379,7 +1379,7 @@ int ObFreezer::create_memtable_if_no_active_memtable(ObTablet *tablet)
} else {
ret = OB_SUCCESS;
}
} else if (last_frozen_memtable_handle.get_data_memtable(last_frozen_memtable)) {
} else if (OB_FAIL(last_frozen_memtable_handle.get_data_memtable(last_frozen_memtable))) {
LOG_WARN("[Freezer] fail to get memtable", K(ret), K(ls_id), K(tablet_id));
}
if (OB_FAIL(ret)) {

4
src/storage/ob_i_memtable_mgr.cpp
View File

@ -327,10 +327,6 @@ int ObIMemtableMgr::add_memtable_(ObTableHandleV2 &memtable_handle)
} else {
tables_[idx]->inc_ref();
memtable_tail_++;
ObTaskController::get().allow_next_syslog();
// FIXME : delete lbt()
STORAGE_LOG(INFO, "succeed to add memtable", KP(this), K(get_memtable_count_()),
K(memtable_handle));
}
}
return ret;

2
src/storage/tablelock/ob_lock_memtable_mgr.cpp
View File

@ -123,7 +123,7 @@ int ObLockMemtableMgr::create_memtable(const SCN clog_checkpoint_scn,
} else if (OB_FAIL(ls_tx_svr->register_common_checkpoint(checkpoint::LOCK_MEMTABLE_TYPE, memtable))) {
LOG_WARN("lock memtable register_common_checkpoint failed", K(ret), K(ls_id_));
} else {
LOG_INFO("create lock memtable successfully", K_(ls_id), K(memtable));
LOG_INFO("create lock memtable successfully", K_(ls_id), K(memtable), KPC(this));
}
return ret;

22
src/storage/tablet/ob_tablet_memtable_mgr.cpp
View File

@ -300,7 +300,7 @@ int ObTabletMemtableMgr::create_memtable(const SCN clog_checkpoint_scn,
clean_tail_memtable_();
} else if (FALSE_IT(time_guard.click("add to data_checkpoint"))) {
} else {
LOG_INFO("succeed to create memtable", K(ret), K(ls_id), KPC(memtable));
LOG_INFO("succeed to create memtable", K(ret), K(ls_id), KPC(memtable), KPC(this));
}
}
}
@ -516,7 +516,7 @@ int ObTabletMemtableMgr::set_is_tablet_freeze_for_active_memtable(ObTableHandleV
ret = OB_NOT_INIT;
LOG_WARN("not inited", K(ret), K_(is_inited));
} else if (OB_FAIL(get_active_memtable(handle))) {
LOG_WARN("fail to get active memtable", K(ret));
LOG_DEBUG("fail to get active memtable", K(ret));
} else if (OB_FAIL(handle.get_memtable(active_memtable))) {
LOG_WARN("fail to get active memtable", K(ret));
if (ret == OB_NOT_INIT) {
@ -875,24 +875,6 @@ int64_t ObTabletMemtableMgr::to_string(char *buf, const int64_t buf_len) const
J_COLON();
pos += ObIMemtableMgr::to_string(buf + pos, buf_len - pos);
J_COMMA();
/************* memtable array **************/
MemMgrRLockGuard lock_guard(lock_);
J_OBJ_START();
J_ARRAY_START();
for (int64_t i = memtable_head_; i < memtable_tail_; ++i) {
ObMemtable *memtable = get_memtable_(i);
if (nullptr != memtable) {
J_OBJ_START();
J_KV(K(i), "table_key", memtable->get_key(), "ref", memtable->get_ref());
J_OBJ_END();
J_COMMA();
}
}
J_ARRAY_END();
J_OBJ_END();
/************* memtable array **************/
J_KV(K_(schema_recorder));
J_OBJ_END();
}

2
src/storage/tx_table/ob_tx_ctx_memtable_mgr.cpp
View File

@ -105,7 +105,7 @@ int ObTxCtxMemtableMgr::create_memtable(const SCN last_replay_scn,
LOG_WARN("tx ctx memtable register_common_checkpoint failed", K(ret), K(ls_id_));
} else {
LOG_INFO("tx ctx memtable mgr create memtable successfully",
K(ls_id_));
K(ls_id_), KPC(tx_ctx_memtable));
}
}

2
src/storage/tx_table/ob_tx_data_memtable_mgr.cpp
View File

@ -180,7 +180,7 @@ int ObTxDataMemtableMgr::create_memtable_(const SCN clog_checkpoint_scn,
STORAGE_LOG(WARN, "add memtable fail.", KR(ret));
} else {
// create memtable success
STORAGE_LOG(INFO, "create tx data memtable done", KR(ret), KPC(tx_data_memtable));
STORAGE_LOG(INFO, "create tx data memtable done", KR(ret), KPC(tx_data_memtable), KPC(this));
}
return ret;