hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

remove links.

Browse Source
This commit is contained in:
obdev
2023-03-09 13:44:23 +00:00
committed by ob-robot
parent b89fe9aaa5
commit 91d94ce27a
4 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
deps/oblib/src/lib/number/ob_number_v2.h vendored
View File

@ -3494,7 +3494,7 @@ OB_INLINE bool ObNumber::try_fast_add(ObNumber &l_num, ObNumber &r_num,
} }
} }
res_desc.sign_ = POSITIVE; res_desc.sign_ = POSITIVE;
res_desc.reserved_ = 0; // must assign 0 explicitly here, due to optimization in sql, https://work.aone.alibaba-inc.com/issue/40852179. res_desc.reserved_ = 0; // must assign 0 explicitly here, due to optimization in sql.
} }
return is_fast_panel; return is_fast_panel;

1
src/sql/engine/expr/ob_expr_add.cpp
View File

@ -882,7 +882,6 @@ int ObExprAdd::add_number_number_batch(BATCH_EVAL_FUNC_ARG_DECL)
ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc()); ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc());
// Notice that, space of tmp is allocated in frame but without memset operation, which causes random memory content. // Notice that, space of tmp is allocated in frame but without memset operation, which causes random memory content.
// And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc. // And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc.
// Reference: https://work.aone.alibaba-inc.com/issue/40852179
ObNumber::Desc *res_desc = new (&desc_buf) ObNumber::Desc(); ObNumber::Desc *res_desc = new (&desc_buf) ObNumber::Desc();
// speedup detection // speedup detection
if (ObNumber::try_fast_add(l_num, r_num, res_digits, *res_desc)) { if (ObNumber::try_fast_add(l_num, r_num, res_digits, *res_desc)) {

1
src/sql/engine/expr/ob_expr_minus.cpp
View File

@ -995,7 +995,6 @@ int ObExprMinus::minus_number_number_batch(BATCH_EVAL_FUNC_ARG_DECL)
ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc()); ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc());
// Notice that, space of desc_buf is allocated in frame but without memset operation, which causes random memory content. // Notice that, space of desc_buf is allocated in frame but without memset operation, which causes random memory content.
// And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc. // And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc.
// Reference: https://work.aone.alibaba-inc.com/issue/40852179
ObNumber::Desc *res_desc = new (&desc_buf) ObNumberDesc(); ObNumber::Desc *res_desc = new (&desc_buf) ObNumberDesc();
// speedup detection // speedup detection
if (ObNumber::try_fast_minus(l_num, r_num, res_digits, *res_desc)) { if (ObNumber::try_fast_minus(l_num, r_num, res_digits, *res_desc)) {

1
src/sql/engine/expr/ob_expr_mul.cpp
View File

@ -762,7 +762,6 @@ int ObExprMul::mul_number_batch(BATCH_EVAL_FUNC_ARG_DECL)
ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc()); ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc());
// Notice that, space of desc_buf is allocated in frame but without memset operation, which causes random memory content. // Notice that, space of desc_buf is allocated in frame but without memset operation, which causes random memory content.
// And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc. // And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc.
// Reference: https://work.aone.alibaba-inc.com/issue/40852179
ObNumber::Desc *res_desc = new (&desc_buf) ObNumber::Desc(); ObNumber::Desc *res_desc = new (&desc_buf) ObNumber::Desc();
// speedup detection // speedup detection
if (ObNumber::try_fast_mul(l_num, r_num, res_digits, *res_desc)) { if (ObNumber::try_fast_mul(l_num, r_num, res_digits, *res_desc)) {