hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix missing error code

Browse Source
This commit is contained in:
XIAO-HOU
2024-03-19 07:55:48 +00:00
committed by ob-robot
parent c84bbbaff6
commit a0db539f24
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/engine/aggregate/ob_aggregate_processor.cpp
View File

@ -1154,7 +1154,7 @@ int ObAggregateProcessor::inner_process(
} else if (aggr_info.is_implicit_first_aggr()) {
if (!aggr_cell.get_is_evaluated()) {
ObDatum *result = NULL;
if (aggr_info.expr_->eval(eval_ctx_, result)) {
if (OB_FAIL(aggr_info.expr_->eval(eval_ctx_, result))) {
LOG_WARN("eval failed", K(ret));
} else if (OB_FAIL(clone_aggr_cell(aggr_cell, *result))) {
LOG_WARN("failed to clone non_aggr cell", K(ret));
@ -8253,7 +8253,7 @@ struct ObDecIntSumBatchOpFunc<ObNumber, CALC_T, ARG_T, SELECTOR>
number::ObNumber right_nmb;
if (OB_FAIL(wide::to_number(accum, scale, tmp_alloc, right_nmb))) {
LOG_WARN("fail to cast decimal int to number", K(ret));
} else if (processor->clone_number_cell(right_nmb, aggr_cell)) {
} else if (OB_FAIL(processor->clone_number_cell(right_nmb, aggr_cell))) {
LOG_WARN("fail to clone number", K(ret));
}
} else {

1
src/storage/blocksstable/ob_macro_block_writer.cpp
View File

@ -1024,6 +1024,7 @@ int ObMacroBlockWriter::get_estimate_meta_block_size(const ObDataMacroBlockMeta
estimate_size = 0;
if (OB_ISNULL(builder_)) {
ret = OB_ERR_UNEXPECTED;
STORAGE_LOG(WARN, "unexpected null builder", K(ret));
} else if (OB_FAIL(builder_->cal_macro_meta_block_size(macro_meta.end_key_, estimate_size))) {
STORAGE_LOG(WARN, "fail to cal macro meta size", K(ret), K(macro_meta));