hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Update pull_request_template.md

Browse Source
This commit is contained in:
wangyunlai
2023-05-08 15:59:47 +08:00
committed by GitHub
parent ccde264e06
commit aeed38e1e0
1 changed files with 20 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
.github/pull_request_template.md vendored
View File

@ -1,48 +1,43 @@
<!--
Thank you for contributing to **OceanBase**! Please read the [How to Contribute](https://github.com/oceanbase/oceanbase/wiki/how_to_contribute) document **BEFORE** filing this PR.
Thank you for contributing to **OceanBase**!
Please read the [How to Contribute](https://github.com/oceanbase/oceanbase/wiki/how_to_contribute) document **BEFORE** filling this PR.
**If this pull request have a significant impact, please make sure you have discussed with OceanBase group.**
-->
### What changes were proposed in this pull request?
### Task Description
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some nGQL features, you can provide some references.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
The problem you resolved by this pull request.
You can link the issue via the "close #xxx" or "ref #xxx".
-->
### Why are the changes needed?
### Solution Description
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
Please clearly and consice descipt the solution.
-->
### Will break the compatibility? How if so?
### Passed Regressions
<!--
Please make sure it do not break the system compatibility, such as
1. nGQL grammar changes;
2. RPC protocol can't be compatible with previous;
3. Storage format; etc.
Unittest, mysql test or test it manually?
-->
### Does this PR introduce any user-facing change?
### Upgrade Compatibility
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
Please make sure this is compatible with old version or you should give us upgrading solution.
-->
### How was this patch tested?
### Other Info
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
Any information helping to review this pull request.
-->
### Release Note
<!--
A concise release note can help users to understand how your pull request makes difference.
-->
### Checklist
@ -50,4 +45,3 @@ If tests were not added, please describe why they were not added and/or why it w
- [ ] I've run the tests to see all new and existing tests pass.
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above.
- [ ] I've informed the technical writer about the documentation change if necessary.