hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

add error log when pthread join failed

Browse Source
This commit is contained in:
obdev
2023-01-10 13:16:02 +00:00
committed by ob-robot
parent 28eb43f457
commit b4afba40e5
2 changed files with 48 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
deps/oblib/src/lib/thread/thread.cpp vendored
View File

@ -128,10 +128,55 @@ void Thread::stop()
stop_ = true; stop_ = true;
} }
void Thread::dump_pth() // for debug pthread join faileds
{
#ifndef OB_USE_ASAN
int ret = OB_SUCCESS;
int fd = 0;
int64_t len = 0;
ssize_t size = 0;
char path[PATH_SIZE];
len = (char*)stack_addr_ + stack_size_ - (char*)pth_;
snprintf(path, PATH_SIZE, "log/dump_pth.%p.%d", (char*)pth_, (int)tid_);
LOG_WARN("dump pth start", K(path), K(pth_), K(tid_), K(len), K(stack_addr_), K(stack_size_));
if (NULL == (char*)pth_ || len >= stack_size_ || len <= 0) {
LOG_WARN("invalid member", K(pth_), K(stack_addr_), K(stack_size_));
} else if ((fd = ::open(path, O_WRONLY | O_CREAT | O_TRUNC,
S_IRUSR | S_IWUSR | S_IRGRP)) < 0) {
ret = OB_IO_ERROR;
LOG_WARN("fail to create file", KERRMSG, K(ret));
} else if (len != (size = write(fd, (char*)(pth_), len))) {
ret = OB_IO_ERROR;
LOG_WARN("dump pth fail", K(errno), KERRMSG, K(len), K(size), K(ret));
if (0 != close(fd)) {
LOG_WARN("fail to close file fd", K(fd), K(errno), KERRMSG, K(ret));
}
} else if (::fsync(fd) != 0) {
ret = OB_IO_ERROR;
LOG_WARN("sync pth fail", K(errno), KERRMSG, K(len), K(size), K(ret));
if (0 != close(fd)) {
LOG_WARN("fail to close file fd", K(fd), K(errno), KERRMSG, K(ret));
}
} else if (0 != close(fd)) {
ret = OB_IO_ERROR;
LOG_WARN("fail to close file fd", K(fd), KERRMSG, K(ret));
} else {
LOG_WARN("dump pth done", K(path), K(pth_), K(tid_), K(size));
}
#endif
}
void Thread::wait() void Thread::wait()
{ {
int ret = OB_SUCCESS;
if (pth_ != 0) { if (pth_ != 0) {
pthread_join(pth_, nullptr); if (OB_FAIL(pthread_join(pth_, nullptr))) {
LOG_ERROR("pthread_join failed", K(ret), K(errno));
#ifndef OB_USE_ASAN
dump_pth();
abort();
#endif
}
destroy_stack(); destroy_stack();
pth_ = 0; pth_ = 0;
pid_ = 0; pid_ = 0;

2
deps/oblib/src/lib/thread/thread.h vendored
View File

@ -24,6 +24,7 @@ namespace lib {
class Thread { class Thread {
public: public:
using Runnable = std::function<void()>; using Runnable = std::function<void()>;
static constexpr int PATH_SIZE = 128;
Thread(); Thread();
Thread(int64_t stack_size); Thread(int64_t stack_size);
Thread(Runnable runnable, int64_t stack_size=0); Thread(Runnable runnable, int64_t stack_size=0);
@ -34,6 +35,7 @@ public:
void stop(); void stop();
void wait(); void wait();
void destroy(); void destroy();
void dump_pth();
pid_t get_pid() const; pid_t get_pid() const;
pid_t get_tid() const; pid_t get_tid() const;