hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix some typo error

Browse Source
This commit is contained in:
csch
2023-04-18 11:45:35 +08:00
parent 8cd9103c3d
commit bf3c79679d
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/engine/opt_statistics/ob_optimizer_stats_gathering_op.cpp
View File

@ -155,7 +155,7 @@ int ObOptimizerStatsGatheringOp::inner_open()
"ColStatNode"))) {
LOG_WARN("fail to create column stats map", K(ret));
}
LOG_TRACE("succeed to open optmizer_stats_gathering op",
LOG_TRACE("succeed to open optimizer_stats_gathering op",
K(ret), K(map_size), K(MY_SPEC.column_ids_.count()), K(MY_SPEC.table_id_));
}
return ret;
@ -353,7 +353,7 @@ int ObOptimizerStatsGatheringOp::calc_column_stats(ObExpr *expr, uint64_t column
ret = OB_ERR_UNEXPECTED;
LOG_WARN("get unexpected null", K(ret));
} else if (!ObColumnStatParam::is_valid_opt_col_type(expr->obj_meta_.get_type())) {
// do nothing yet, shoul use the plain stats.
// do nothing yet, should use the plain stats.
} else if (OB_FAIL(expr->eval(eval_ctx_, datum))) {
LOG_WARN("failed to eval expr", K(*expr));
} else if (OB_ISNULL(datum) ) {

8
src/sql/engine/px/ob_px_tenant_target_monitor.cpp
View File

@ -107,7 +107,7 @@ int ObPxTenantTargetMonitor::refresh_statistics(bool need_refresh_all)
role_ = FOLLOWER;
// from leader to follower, refresh all the statistics
if (OB_FAIL(reset_follower_statistics(-1))) {
LOG_WARN("reset statisitcs failed", K(ret));
LOG_WARN("reset statistics failed", K(ret));
}
}
if (OB_FAIL(query_statistics(leader))) {
@ -120,7 +120,7 @@ int ObPxTenantTargetMonitor::refresh_statistics(bool need_refresh_all)
role_ = LEADER;
// from follower to leader or observer is not longer alive, refresh all the statistics
if (OB_FAIL(reset_leader_statistics())) {
LOG_WARN("reset statisitcs failed", K(ret));
LOG_WARN("reset statistics failed", K(ret));
}
LOG_INFO("refresh global_target_usage_", K(tenant_id_), K(version_), K(server_), K(need_refresh_all));
}
@ -465,14 +465,14 @@ int ObPxTenantTargetMonitor::apply_target(hash::ObHashMap<ObAddr, int64_t> &work
}
}
if (OB_SUCC(ret) && need_wait) {
// when got no resource, wait for next avaliable resource
// when got no resource, wait for next available resource
//
// NOTE: when any resource returned , ALL waiting threads are waken up
// this is because the returned resource maybe a very big chunk,
// which can feed many waiting threads
LOG_DEBUG("wait begin", K(wait_time_us), K(session_target), K(req_cnt));
int64_t wait_us = min(wait_time_us, 1000000L);
target_cond_.wait(wait_us); // sleep at most 1sec, in order to check interrput
target_cond_.wait(wait_us); // sleep at most 1sec, in order to check interrupt
LOG_DEBUG("wait finish");
}
return ret;

2
src/sql/engine/px/ob_px_worker.cpp
View File

@ -108,7 +108,7 @@ int ObPxCoroWorker::deep_copy_assign(const ObPxRpcInitTaskArgs &src,
ret = OB_ALLOCATE_MEMORY_FAILED;
LOG_WARN("fail alloc memory", K(ser_arg_len), KP(ser_ptr), K(ret));
} else if (OB_FAIL(src.serialize(static_cast<char *>(ser_ptr), ser_arg_len, ser_pos))) {
LOG_WARN("fail serialzie init task arg", KP(ser_ptr), K(ser_arg_len), K(ser_pos), K(ret));
LOG_WARN("fail serialize init task arg", KP(ser_ptr), K(ser_arg_len), K(ser_pos), K(ret));
} else if (OB_FAIL(dest.deserialize(static_cast<const char *>(ser_ptr), ser_pos, des_pos))) {
LOG_WARN("fail des task arg", KP(ser_ptr), K(ser_pos), K(des_pos), K(ret));
} else if (ser_pos != des_pos) {

12
src/sql/engine/window_function/ob_window_function_op.cpp
View File

@ -101,7 +101,7 @@ int ObWindowFunctionOpInput::sync_wait(
// guarantee next wait loop to get lock for one thread
has_process = true;
if (0 == ATOMIC_AAF(&sync_cnt, 1) % exit_cnt) {
// last thread, it will singal and exit by self
// last thread, it will signal and exit by self
shared_info->cond_.signal();
LOG_DEBUG("debug sync_cnt", K(ret), K(sync_cnt), K(lbt()));
break;
@ -347,7 +347,7 @@ int ObWindowFunctionOp::AggrCell::trans_self(const ObRADatumStore::StoredRow &ro
}
if (OB_SUCC(ret)) {
// uppon invoke trans(), forbiden it to reuse the last_result
// uppon invoke trans(), forbidden it to reuse the last_result
got_result_ = false;
}
return ret;
@ -376,7 +376,7 @@ int ObWindowFunctionOp::AggrCell::inv_trans_self(const ObRADatumStore::StoredRow
}
}
if (OB_SUCC(ret)) {
// uppon invoke inv_trans(), forbiden it to reuse the last_result
// uppon invoke inv_trans(), forbidden it to reuse the last_result
got_result_ = false;
}
aggr_processor_.get_removal_info().is_inv_aggr_ = false;
@ -796,7 +796,7 @@ int ObWindowFunctionOp::NonAggrCellNtile::eval(RowsReader &row_reader,
LOG_WARN("get_param_int_value failed", K(ret));
}
} else if (is_null) {
// return NULL when backets_num is NULL
// return NULL when bucket_num is NULL
val.set_null();
} else if (!is_oracle_mode()
&& !param->obj_meta_.is_numeric_type()) {
@ -1331,7 +1331,7 @@ int ObWindowFunctionOp::init()
if (OB_SUCC(ret) && MY_SPEC.is_participator()) {
if (wf_info.can_push_down_) {
if (common::OB_INVALID_COUNT == next_wf_pby_expr_cnt_to_transmit_) {
// next_wf_pby_expr_cnt_to_transmit_ is for pushdown tranmit to datahub
// next_wf_pby_expr_cnt_to_transmit_ is for pushdown transmit to datahub
next_wf_pby_expr_cnt_to_transmit_ = wf_info.partition_exprs_.count();
}
if (wf_info.partition_exprs_.count() != prev_pushdown_pby_col_count) {
@ -2342,7 +2342,7 @@ int ObWindowFunctionOp::rd_output_final_row(const int64_t idx,
if (OB_FAIL(output_row(idx, &Stores::cur_, &cur_row))) {
LOG_WARN("output row failed", K(ret));
} else {
// apply patchs
// apply patches
if (patch_first) {
reset_first_row_same_order_cache();
for (int64_t wf_idx = 0; OB_SUCC(ret) && wf_idx < MY_SPEC.rd_wfs_.count(); wf_idx++) {