hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[CP] [to #48858145] fix stack leak of while stmt

Browse Source
This commit is contained in:
obdev 2023-04-11 12:00:39 +08:00 committed by ob-robot
parent b5e961e8a0
commit c15c195237
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pl/ob_pl_code_generator.cpp
View File

@ -829,6 +829,7 @@ int ObPLCodeGenerateVisitor::visit(const ObPLWhileStmt &s)
ObLLVMBasicBlock continue_begin;
ObLLVMBasicBlock do_body;
ObLLVMBasicBlock alter_while;
ObLLVMValue count_value;
if (OB_FAIL(generator_.get_helper().create_block(ObString("while_begin"), generator_.get_func(), while_begin))) {
LOG_WARN("failed to create block", K(s), K(ret));
@ -839,6 +840,8 @@ int ObPLCodeGenerateVisitor::visit(const ObPLWhileStmt &s)
LOG_WARN("failed to create block", K(s), K(ret));
} else if (OB_FAIL(generator_.get_helper().create_block(ObString("after_while"), generator_.get_func(), alter_while))) {
LOG_WARN("failed to create block", K(s), K(ret));
} else if (OB_FAIL(generator_.get_helper().create_ialloca(ObString("count_value"), ObIntType, 0, count_value))) {
LOG_WARN("failed to create_ialloca", K(ret));
} else if (s.has_label() && OB_FAIL(generator_.set_label(s.get_label(), s.get_level(), while_begin, alter_while))) {
LOG_WARN("failed to set current", K(s), K(ret));
} else if (OB_FAIL(generator_.get_helper().create_br(while_begin))) {
@ -849,13 +852,10 @@ int ObPLCodeGenerateVisitor::visit(const ObPLWhileStmt &s)
ObLLVMValue p_result_obj;
ObLLVMValue result;
ObLLVMValue is_false;
ObLLVMValue count_value;
ObLLVMValue stack;
if (OB_ISNULL(s.get_body()) || OB_ISNULL(s.get_cond_expr())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("a if must have then body", K(s), K(s.get_body()), K(s.get_cond()), K(ret));
} else if (OB_FAIL(generator_.get_helper().create_ialloca(ObString("count_value"), ObIntType, 0, count_value))) {
LOG_WARN("failed to create_ialloca", K(ret));
} else if (OB_FAIL(generator_.get_helper().create_br(continue_begin))) {
LOG_WARN("failed to create_br", K(ret));
} else if (OB_FAIL(generator_.set_current(continue_begin))) {