hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[CP] Fix dynamic sampling bug

Browse Source
This commit is contained in:
xianyu-w
2025-01-13 04:44:52 +00:00
committed by ob-robot
parent fda4f79146
commit c8f1346492
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/sql/optimizer/ob_dynamic_sampling.cpp
View File

@ -1215,15 +1215,27 @@ int ObDynamicSampling::gen_partition_str(const ObIArray<PartInfo> &partition_inf
ObSqlString &partition_str)
{
int ret = OB_SUCCESS;
ObArenaAllocator allocator("ObOptDS");
if (OB_UNLIKELY(partition_infos.empty())) {
ret = OB_ERR_UNEXPECTED;
LOG_WARN("get unexpected error", K(ret), K(partition_infos));
} else {
for (int64_t i = 0; OB_SUCC(ret) && i < partition_infos.count(); ++i) {
char prefix = i == 0 ? ' ' : ',';
if (OB_FAIL(partition_str.append_fmt("%c%.*s", prefix, partition_infos.at(i).part_name_.length(),
partition_infos.at(i).part_name_.ptr()))) {
LOG_WARN("failed to append fmt", K(ret));
const char *quot = lib::is_mysql_mode() ? "`" : "\"";
ObString print_name;
if (i > 0 && OB_FAIL(partition_str.append(","))) {
LOG_WARN("failed to append", K(ret));
} else if (OB_FAIL(partition_str.append(quot))) {
LOG_WARN("failed to append", K(ret));
} else if (OB_FAIL(ObSQLUtils::generate_new_name_with_escape_character(allocator,
partition_infos.at(i).part_name_,
print_name,
lib::is_oracle_mode()))) {
LOG_WARN("failed to generate new name with escape character", K(ret));
} else if (OB_FAIL(partition_str.append(print_name))) {
LOG_WARN("failed to append", K(ret));
} else if (OB_FAIL(partition_str.append(quot))) {
LOG_WARN("failed to append", K(ret));
}
}
}