hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix ob thread performance

Browse Source
This commit is contained in:
obdev
2024-02-09 02:54:46 +00:00
committed by ob-robot
parent fa3a80e541
commit da940d060b
2 changed files with 66 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

113
src/observer/virtual_table/ob_all_virtual_thread.cpp
View File

@ -228,54 +228,8 @@ int ObAllVirtualThread::inner_get_next_row(common::ObNewRow *&row)
cells[i].set_varchar("");
} else {
int64_t pid = getpid();
char path[256];
snprintf(path, 256, "/proc/%ld/task/%ld/cgroup", pid, tid);
FILE *file = fopen(path, "r");
if (NULL == file) {
cells[i].set_varchar("");
} else {
/*
file content
7:perf_event:/
6:cpuset,cpu,cpuacct:/oceanbase/tenant_0001
5:blkio:/system.slice/staragentctl.service
4:devices:/system.slice/staragentctl.service
3:hugetlb:/
cgroup_path = /tenant_0001
*/
bool is_find = false;
int min_len = 2;
int discard_len = 1;
char read_buff[PATH_BUFSIZE];
cgroup_path_buf_[0] = '\0';
while (fgets(read_buff, sizeof(read_buff), file) != NULL && !is_find) {
const char* match_begin = strstr(read_buff, ":/");
const char* match_cpu = strstr(read_buff, "cpu");
if (match_begin != NULL && match_cpu != NULL) {
is_find = true;
match_begin += discard_len;
snprintf(cgroup_path_buf_, PATH_BUFSIZE, "%s", match_begin);
}
}
if (is_find) {
int cgroup_path_len = strlen(cgroup_path_buf_);
if (min_len < cgroup_path_len) {
if (cgroup_path_buf_[cgroup_path_len - 1] == '\n') {
cgroup_path_buf_[cgroup_path_len - 1] = '\0';
}
cells[i].set_varchar(cgroup_path_buf_);
} else {
cells[i].set_varchar("");
}
} else {
cells[i].set_varchar("");
}
}
cells[i].set_collation_type(
ObCharset::get_default_collation(ObCharset::get_default_charset()));
if (NULL != file) {
fclose(file);
}
snprintf(cgroup_path_buf_, PATH_BUFSIZE, "/proc/%ld/task/%ld/cgroup", pid, tid);
cells[i].set_varchar(cgroup_path_buf_);
}
break;
}
@ -307,6 +261,8 @@ int ObAllVirtualThread::inner_get_next_row(common::ObNewRow *&row)
if (OB_ITER_END != ret) {
SERVER_LOG(WARN, "fail to get next row", K(ret));
}
} else if (OB_FAIL(read_real_cgroup_path())){
SERVER_LOG(WARN, "fail to get cgroup path real path", K(ret));
} else {
row = &cur_row_;
}
@ -314,5 +270,66 @@ int ObAllVirtualThread::inner_get_next_row(common::ObNewRow *&row)
return ret;
}
int ObAllVirtualThread::read_real_cgroup_path()
{
int ret = OB_SUCCESS;
const int64_t col_count = output_column_ids_.count();
for (int64_t i = 0; i < col_count && OB_SUCC(ret); ++i) {
const uint64_t col_id = output_column_ids_.at(i);
ObObj *cells = cur_row_.cells_;
if (col_id == CGROUP_PATH) {
char path[PATH_BUFSIZE];
snprintf(path, cells[i].get_val_len() + 1, "%s", cells[i].get_varchar().ptr());
FILE *file = fopen(path, "r");
if (NULL == file) {
cells[i].set_varchar("");
} else {
/*
file content
7:perf_event:/
6:cpuset,cpu,cpuacct:/oceanbase/tenant_0001
5:blkio:/system.slice/staragentctl.service
4:devices:/system.slice/staragentctl.service
3:hugetlb:/
cgroup_path = /tenant_0001
*/
bool is_find = false;
int min_len = 2;
int discard_len = 1;
char read_buff[PATH_BUFSIZE];
cgroup_path_buf_[0] = '\0';
while (fgets(read_buff, sizeof(read_buff), file) != NULL && !is_find) {
const char* match_begin = strstr(read_buff, ":/");
const char* match_cpu = strstr(read_buff, "cpu");
if (match_begin != NULL && match_cpu != NULL) {
is_find = true;
match_begin += discard_len;
snprintf(cgroup_path_buf_, PATH_BUFSIZE, "%s", match_begin);
}
}
if (is_find) {
int cgroup_path_len = strlen(cgroup_path_buf_);
if (min_len < cgroup_path_len) {
if (cgroup_path_buf_[cgroup_path_len - 1] == '\n') {
cgroup_path_buf_[cgroup_path_len - 1] = '\0';
}
cells[i].set_varchar(cgroup_path_buf_);
} else {
cells[i].set_varchar("");
}
} else {
cells[i].set_varchar("");
}
}
cells[i].set_collation_type(
ObCharset::get_default_collation(ObCharset::get_default_charset()));
if (NULL != file) {
fclose(file);
}
}
}
return ret;
}
} // namespace observer
} // namespace oceanbase

1
src/observer/virtual_table/ob_all_virtual_thread.h
View File

@ -55,6 +55,7 @@ private:
char locks_addr_[256];
char trace_id_buf_[40];
char cgroup_path_buf_[PATH_BUFSIZE];
int read_real_cgroup_path();
private:
DISALLOW_COPY_AND_ASSIGN(ObAllVirtualThread);